Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/graph/Grid.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function DoStroke has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    public function DoStroke($aTicksPos, $aType, $aColor, $aWeight)
    {
        $nbrgrids = safe_count($aTicksPos);
        if (!$this->show || $nbrgrids === 0) {
            return;
Severity: Minor
Found in src/graph/Grid.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method DoStroke has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function DoStroke($aTicksPos, $aType, $aColor, $aWeight)
    {
        $nbrgrids = safe_count($aTicksPos);
        if (!$this->show || $nbrgrids === 0) {
            return;
Severity: Major
Found in src/graph/Grid.php - About 2 hrs to fix

    The method DoStroke() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
    Open

        public function DoStroke($aTicksPos, $aType, $aColor, $aWeight)
    {
        $nbrgrids = safe_count($aTicksPos);
        if (!$this->show || $nbrgrids === 0) {
            return;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method Show has a boolean flag argument $aShowMajor, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function Show($aShowMajor = true, $aShowMinor = false)
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method SetFill has a boolean flag argument $aFlg, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function SetFill($aFlg = true, $aColor1 = 'lightgray', $aColor2 = 'lightblue')
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method SetColor has a boolean flag argument $aMinColor, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function SetColor($aMajColor, $aMinColor = false)
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method Show has a boolean flag argument $aShowMinor, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function Show($aShowMajor = true, $aShowMinor = false)
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'DoStroke'.
    Open

                Util\JpGraphError::RaiseL(25054, $this->scale->type); //('Internal error: Unknown grid axis ['.$this->scale->type.']');
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method DoStroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            Util\JpGraphError::RaiseL(25054, $this->scale->type); //('Internal error: Unknown grid axis ['.$this->scale->type.']');
        }
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $this->DoStroke($this->scale->ticks->maj_ticks_pos, $this->majortype, $this->majorcolor, $this->majorweight);
        }
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid variables with short names like $y. Configured minimum length is 3.
    Open

                    $y = $aTicksPos[$i];
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x1. Configured minimum length is 3.
    Open

                        $x1 = $x2;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $xr. Configured minimum length is 3.
    Open

                $xr = $this->img->width - $this->img->right_margin;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x2. Configured minimum length is 3.
    Open

                    $x2 = $aTicksPos[0];
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $xl. Configured minimum length is 3.
    Open

                $xl = $this->img->left_margin;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x. Configured minimum length is 3.
    Open

                $x = $aTicksPos[$i];
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y1. Configured minimum length is 3.
    Open

                        $y1 = $y2;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $yl. Configured minimum length is 3.
    Open

                $yl    = $this->img->height - $this->img->bottom_margin;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

                    $i  = 1;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y2. Configured minimum length is 3.
    Open

                    $y2 = $aTicksPos[0];
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $yu. Configured minimum length is 3.
    Open

                $yu    = $this->img->top_margin;
    Severity: Minor
    Found in src/graph/Grid.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method name "Grid::Show" is not in camel caps format
    Open

        public function Show($aShowMajor = true, $aShowMinor = false)
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::DoStroke" is not in camel caps format
    Open

        public function DoStroke($aTicksPos, $aType, $aColor, $aWeight)
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::Stroke" is not in camel caps format
    Open

        public function Stroke()
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::SetWeight" is not in camel caps format
    Open

        public function SetWeight($aMajorWeight, $aMinorWeight = 1)
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::SetLineStyle" is not in camel caps format
    Open

        public function SetLineStyle($aMajorType, $aMinorType = 'solid')
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::SetColor" is not in camel caps format
    Open

        public function SetColor($aMajColor, $aMinColor = false)
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::SetStyle" is not in camel caps format
    Open

        public function SetStyle($aMajorType, $aMinorType = 'solid')
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Method name "Grid::SetFill" is not in camel caps format
    Open

        public function SetFill($aFlg = true, $aColor1 = 'lightgray', $aColor2 = 'lightblue')
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

                $this->DoStroke($this->scale->ticks->maj_ticks_pos, $this->majortype, $this->majorcolor, $this->majorweight);
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

                $this->DoStroke($this->scale->ticks->maj_ticks_pos, $this->majortype, $this->majorcolor, $this->majorweight);
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    Line exceeds 120 characters; contains 131 characters
    Open

                Util\JpGraphError::RaiseL(25054, $this->scale->type); //('Internal error: Unknown grid axis ['.$this->scale->type.']');
    Severity: Minor
    Found in src/graph/Grid.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status