The method ShowFrame has a boolean flag argument $aShow, which is a certain sign of a Single Responsibility Principle violation. Open
public function ShowFrame($aShow = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'SetDensity'. Open
Util\JpGraphError::RaiseL(16001, $aDens);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'. Open
Util\JpGraphError::RaiseL(16002);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Method name "RectPattern::SetDensity" is not in camel caps format Open
public function SetDensity($aDens)- Exclude checks
Method name "RectPattern::ShowFrame" is not in camel caps format Open
public function ShowFrame($aShow = true)- Exclude checks
Method name "RectPattern::SetBackground" is not in camel caps format Open
public function SetBackground($aBackgroundColor)- Exclude checks
Method name "RectPattern::SetPos" is not in camel caps format Open
public function SetPos($aRect)- Exclude checks
Method name "RectPattern::Stroke" is not in camel caps format Open
public function Stroke($aImg)- Exclude checks