Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/image/DigitalLED74.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method _GetLED has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _GetLED($aLedIdx, $aColor = 0)
    {
        $width  = $this->iLED_X * $this->iRad * 2 + ($this->iLED_X + 1) * $this->iMarg + $this->iRad;
        $height = $this->iLED_Y * $this->iRad * 2 + ($this->iLED_Y) * $this->iMarg + $this->iRad * 2;
Severity: Minor
Found in src/image/DigitalLED74.php - About 1 hr to fix

    Method StrokeNumber has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function StrokeNumber($aValStr, $aColor = 0, $aFileName = '')
    {
        if ($aColor < 0 || $aColor >= safe_count($this->iColorSchema)) {
            $aColor = 0;
        }
    Severity: Minor
    Found in src/image/DigitalLED74.php - About 1 hr to fix

      Function StrokeNumber has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function StrokeNumber($aValStr, $aColor = 0, $aFileName = '')
    {
        if ($aColor < 0 || $aColor >= safe_count($this->iColorSchema)) {
            $aColor = 0;
        }
      Severity: Minor
      Found in src/image/DigitalLED74.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _GetLED has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _GetLED($aLedIdx, $aColor = 0)
    {
        $width  = $this->iLED_X * $this->iRad * 2 + ($this->iLED_X + 1) * $this->iMarg + $this->iRad;
        $height = $this->iLED_Y * $this->iRad * 2 + ($this->iLED_Y) * $this->iMarg + $this->iRad * 2;
      Severity: Minor
      Found in src/image/DigitalLED74.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid using undefined variables such as '$digit_img' which will lead to PHP notices.
      Open

              $h = imagesy($digit_img[0]->img);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$digit_img' which will lead to PHP notices.
      Open

              $w = imagesx($digit_img[0]->img);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$digit_img' which will lead to PHP notices.
      Open

                  $number_img->Copy($digit_img[$i]->img, $i * $w, 0, 0, 0, $w, $h, $w, $h);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$digit_img' which will lead to PHP notices.
      Open

                  $digit_img[$i] = $this->_GetLED($d, $aColor);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid assigning values to variables in if clauses and the like (line '268', column '14').
      Open

          public function StrokeNumber($aValStr, $aColor = 0, $aFileName = '')
    {
        if ($aColor < 0 || $aColor >= safe_count($this->iColorSchema)) {
            $aColor = 0;
        }
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      The method StrokeNumber uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                $d = strtoupper($d);
            }
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method _GetLED uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $d = [0, 0, 0, 0, 0, 0, 0];
        }
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method _GetLED uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $color = $this->iColorSchema[$aColor][1];
                }
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method StrokeNumber uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $number_img->Headers();
            $number_img->Stream();
        }
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 22 and the first side effect is on line 41.
      Open

      <?php
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      Avoid variables with short names like $dr. Configured minimum length is 3.
      Open

                  $dr = $d[$r];
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $d. Configured minimum length is 3.
      Open

                  $d = mb_substr($aValStr, $i, 1, 'utf8');
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $h. Configured minimum length is 3.
      Open

              $h = imagesy($digit_img[0]->img);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              if (($n = mb_strlen($aValStr, 'utf8')) == 0) {
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $y. Configured minimum length is 3.
      Open

                      $y = 2 * $rad * $r + $rad + ($r + 1) * $marg + $rad;
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $x. Configured minimum length is 3.
      Open

                      $x = 2 * $rad * $c + $rad + ($c + 1) * $marg + $rad;
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $d. Configured minimum length is 3.
      Open

                  $d = $this->iLEDSpec[$aLedIdx];
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $w. Configured minimum length is 3.
      Open

              $w = imagesx($digit_img[0]->img);
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Method name "DigitalLED74::SetSupersampling" is not in camel caps format
      Open

          public function SetSupersampling($aSuperSampling = 2)
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      Method name "DigitalLED74::_GetLED" is not in camel caps format
      Open

          public function _GetLED($aLedIdx, $aColor = 0)
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      Method name "DigitalLED74::Stroke" is not in camel caps format
      Open

          public function Stroke($aValStr, $aColor = 0, $aFileName = '')
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      Method name "DigitalLED74::StrokeNumber" is not in camel caps format
      Open

          public function StrokeNumber($aValStr, $aColor = 0, $aFileName = '')
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      Method name "_GetLED" should not be prefixed with an underscore to indicate visibility
      Open

          public function _GetLED($aLedIdx, $aColor = 0)
      Severity: Minor
      Found in src/image/DigitalLED74.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status