Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/image/FlagImages.php

Summary

Maintainability
C
7 hrs
Test Coverage

File FlagImages.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * JPGraph v4.0.3
 */
Severity: Minor
Found in src/image/FlagImages.php - About 4 hrs to fix

    Function GetIdxByName has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function GetIdxByName($aName, &$outFullName)
    {
        if (is_integer($aName)) {
            $idx = $this->GetIdxByOrdinal($aName, $outFullName);
    Severity: Minor
    Found in src/image/FlagImages.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method GetIdxByName has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function GetIdxByName($aName, &$outFullName)
    {
        if (is_integer($aName)) {
            $idx = $this->GetIdxByOrdinal($aName, $outFullName);
    Severity: Minor
    Found in src/image/FlagImages.php - About 1 hr to fix

      Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method '__construct'.
      Open

                      Util\JpGraphError::RaiseL(5001, $aSize);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Amenadiel\JpGraph\Image\Image' in method 'GetImgByIdx'.
      Open

                  return Image::CreateFromString($d);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'GetImgByIdx'.
      Open

              Util\JpGraphError::RaiseL(5002, $aIdx);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'GetIdxByOrdinal'.
      Open

              Util\JpGraphError::RaiseL(5003, $aOrd);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'GetIdxByName'.
      Open

              Util\JpGraphError::RaiseL(5004, $aName);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid variables with short names like $fp. Configured minimum length is 3.
      Open

                      $fp              = fopen($file, 'rb');
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $d. Configured minimum length is 3.
      Open

                  $d = $this->iFlagData[$aIdx][1];
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              $n = safe_count($this->iOrdIdx);
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $i. Configured minimum length is 3.
      Open

                  $i             = 0;
      Severity: Minor
      Found in src/image/FlagImages.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Method name "FlagImages::GetNum" is not in camel caps format
      Open

          public function GetNum()
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      Method name "FlagImages::GetImgByName" is not in camel caps format
      Open

          public function GetImgByName($aName, &$outFullName)
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      Method name "FlagImages::GetIdxByOrdinal" is not in camel caps format
      Open

          public function GetIdxByOrdinal($aOrd, &$outFullName)
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      Method name "FlagImages::GetIdxByName" is not in camel caps format
      Open

          public function GetIdxByName($aName, &$outFullName)
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      Method name "FlagImages::GetImgByIdx" is not in camel caps format
      Open

          public function GetImgByIdx($aIdx)
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      Line exceeds 120 characters; contains 189 characters
      Open

              //("The (partial) country name \"$aName\" does not have a cooresponding flag image. The flag may still exist but under another name, e.g. insted of \"usa\" try \"united states\".");
      Severity: Minor
      Found in src/image/FlagImages.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status