Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/image/ImgData_Diamonds.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method __construct has 120 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct()
    {
        /*
         * File: diam_red.png
         */
Severity: Major
Found in src/image/ImgData_Diamonds.php - About 4 hrs to fix

    The method __construct() has 154 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function __construct()
    {
        /*
         * File: diam_red.png
         */
    Severity: Minor
    Found in src/image/ImgData_Diamonds.php by phpmd

    Avoid variables with short names like $an. Configured minimum length is 3.
    Open

        protected $an     = [MARK_IMG_DIAMOND => 'imgdata'];
    Severity: Minor
    Found in src/image/ImgData_Diamonds.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Class name "ImgData_Diamonds" is not in camel caps format
    Open

    class ImgData_Diamonds extends ImgData
    Severity: Minor
    Found in src/image/ImgData_Diamonds.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status