HuasoFoundries/jpgraph

View on GitHub
src/plot/BarPlot.php

Summary

Maintainability
F
1 wk
Test Coverage

Function Stroke has a Cognitive Complexity of 142 (exceeds 5 allowed). Consider refactoring.
Open

    public function Stroke($img, $xscale, $yscale)
    {
        $numpoints = safe_count($this->coords[0]);
        if (isset($this->coords[1])) {
            if (safe_count($this->coords[1]) != $numpoints) {
Severity: Minor
Found in src/plot/BarPlot.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Stroke has 306 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function Stroke($img, $xscale, $yscale)
    {
        $numpoints = safe_count($this->coords[0]);
        if (isset($this->coords[1])) {
            if (safe_count($this->coords[1]) != $numpoints) {
Severity: Major
Found in src/plot/BarPlot.php - About 1 day to fix

    File BarPlot.php has 595 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * JPGraph v4.0.3
     */
    Severity: Major
    Found in src/plot/BarPlot.php - About 1 day to fix

      The class BarPlot has an overall complexity of 113 which is very high. The configured complexity threshold is 50.
      Open

      class BarPlot extends Plot
      {
          public $fill                = false;
          public $fill_color          = 'lightblue'; // Default is to fill with light blue
          public $iPattern            = -1;
      Severity: Minor
      Found in src/plot/BarPlot.php by phpmd

      Method Legend has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function Legend($graph)
          {
              if ($this->grad && $this->legend != '' && !$this->fill) {
                  $color = [$this->grad_fromcolor, $this->grad_tocolor];
                  // In order to differentiate between gradients and cooors specified as an Image\RGB triple
      Severity: Major
      Found in src/plot/BarPlot.php - About 2 hrs to fix

        Function Legend has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function Legend($graph)
            {
                if ($this->grad && $this->legend != '' && !$this->fill) {
                    $color = [$this->grad_fromcolor, $this->grad_tocolor];
                    // In order to differentiate between gradients and cooors specified as an Image\RGB triple
        Severity: Minor
        Found in src/plot/BarPlot.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _SetPatternHelper has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _SetPatternHelper($aPattern, &$aPatternValue, &$aDensity)
            {
                switch ($aPattern) {
                    case PATTERN_DIAG1:
                        $aPatternValue = 1;
        Severity: Minor
        Found in src/plot/BarPlot.php - About 1 hr to fix

          Function PreStrokeAdjust has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function PreStrokeAdjust($graph)
              {
                  parent::PreStrokeAdjust($graph);
          
                  // If we are using a log Y-scale we want the base to be at the
          Severity: Minor
          Found in src/plot/BarPlot.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function SetPattern has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function SetPattern($aPattern, $aColor = 'black')
              {
                  if (is_array($aPattern)) {
                      $n                     = safe_count($aPattern);
                      $this->iPattern        = [];
          Severity: Minor
          Found in src/plot/BarPlot.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class BarPlot has 22 fields. Consider redesigning BarPlot to keep the number of fields under 15.
          Open

          class BarPlot extends Plot
          {
              public $fill                = false;
              public $fill_color          = 'lightblue'; // Default is to fill with light blue
              public $iPattern            = -1;
          Severity: Minor
          Found in src/plot/BarPlot.php by phpmd

          TooManyFields

          Since: 0.1

          Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

          Example

          class Person {
             protected $one;
             private $two;
             private $three;
             [... many more fields ...]
          }

          Source https://phpmd.org/rules/codesize.html#toomanyfields

          Function _SetPatternHelper has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function _SetPatternHelper($aPattern, &$aPatternValue, &$aDensity)
              {
                  switch ($aPattern) {
                      case PATTERN_DIAG1:
                          $aPatternValue = 1;
          Severity: Minor
          Found in src/plot/BarPlot.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                  if ($this->grad && $this->legend != '' && !$this->fill) {
                      $color = [$this->grad_fromcolor, $this->grad_tocolor];
                      // In order to differentiate between gradients and cooors specified as an Image\RGB triple
                      $graph->legend->Add(
                          $this->legend,
          Severity: Major
          Found in src/plot/BarPlot.php - About 40 mins to fix

            The method Stroke() has 373 lines of code. Current threshold is set to 100. Avoid really long methods.
            Open

                public function Stroke($img, $xscale, $yscale)
                {
                    $numpoints = safe_count($this->coords[0]);
                    if (isset($this->coords[1])) {
                        if (safe_count($this->coords[1]) != $numpoints) {
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            The method Stroke() has an NPath complexity of 381024024. The configured NPath complexity threshold is 200.
            Open

                public function Stroke($img, $xscale, $yscale)
                {
                    $numpoints = safe_count($this->coords[0]);
                    if (isset($this->coords[1])) {
                        if (safe_count($this->coords[1]) != $numpoints) {
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
                function bar() {
                    // lots of complicated code
                }
            }

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The method Legend() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
            Open

                public function Legend($graph)
                {
                    if ($this->grad && $this->legend != '' && !$this->fill) {
                        $color = [$this->grad_fromcolor, $this->grad_tocolor];
                        // In order to differentiate between gradients and cooors specified as an Image\RGB triple
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method PreStrokeAdjust() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
            Open

                public function PreStrokeAdjust($graph)
                {
                    parent::PreStrokeAdjust($graph);
            
                    // If we are using a log Y-scale we want the base to be at the
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method _SetPatternHelper() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
            Open

                public function _SetPatternHelper($aPattern, &$aPatternValue, &$aDensity)
                {
                    switch ($aPattern) {
                        case PATTERN_DIAG1:
                            $aPatternValue = 1;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method Stroke() has a Cyclomatic Complexity of 55. The configured cyclomatic complexity threshold is 10.
            Open

                public function Stroke($img, $xscale, $yscale)
                {
                    $numpoints = safe_count($this->coords[0]);
                    if (isset($this->coords[1])) {
                        if (safe_count($this->coords[1]) != $numpoints) {
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[11] = $pts[7] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                            $img->FilledPolygon($sp);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[2]  = $pts[4];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[0]  = $pts[4];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[4] = $pts[4] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[3]  = $pts[5];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[7]  = $pts[3] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[10] = $pts[4] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[7] = $pts[5] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[9]  = $pts[5] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[11] = $pts[5] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[3] = $pts[7];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[3] = $pts[1];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[1]  = $pts[7];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[5]  = $pts[3];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[3]  = $pts[7];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[1] = $pts[7];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[7] = $pts[7] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[0] = $pts[4];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[1] = $pts[5];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[6] = $pts[4] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[2] = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[0]  = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[4]  = $pts[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[4] = $pts[0] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                            $img->FilledPolygon($sp1);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[6]  = $pts[2] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[1]  = $pts[5];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[1] = $pts[5];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[8]  = $pts[4] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[5] = $pts[5] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[6] = $pts[6] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[7]  = $pts[1] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[0] = $pts[4];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[10] = $pts[6] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[7] = $pts[5] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[2]  = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[3] = $pts[5];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                            $img->FilledPolygon($sp2);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[2] = $pts[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[8]  = $pts[6] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[9]  = $pts[7] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[0] = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[6] = $pts[6] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[2] = $pts[2];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[5] = $pts[3] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[5]  = $pts[1];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[3] = $pts[3];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[0] = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[1] = $pts[7];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[4]  = $pts[2];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp' which will lead to PHP notices.
            Open

                                $sp[6]  = $pts[0] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[2] = $pts[4];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[4] = $pts[6] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[5] = $pts[1] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[7] = $pts[7] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[5] = $pts[7] - $ssv;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp2' which will lead to PHP notices.
            Open

                                $sp2[4] = $pts[2] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$sp1' which will lead to PHP notices.
            Open

                                $sp1[6] = $pts[4] + $ssh;
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            The method SetShadow has a boolean flag argument $aShow, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function SetShadow($aColor = 'black', $aHSize = 3, $aVSize = 3, $aShow = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method Set3D has a boolean flag argument $aShow, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function Set3D($aHSize = 3, $aVSize = 3, $aShow = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method RotatePattern has a boolean flag argument $aRotate, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function RotatePattern($aPat, $aRotate = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method __construct has a boolean flag argument $datax, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function __construct($datay, $datax = false)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
                public function bar($flag = true) {
                }
            }

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                $img->PushColor($this->bar_shadow_color);
                            }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Legend uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $p1 = $this->RotatePattern($this->iPattern, $graph->img->a == 90);
                            $p2 = $this->iPatternColor;
                            $p3 = $this->iPatternDensity;
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method '_SetPatternHelper'.
            Open

                            Util\JpGraphError::RaiseL(2002);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                if ($val < 0) {
                                    $this->value->SetMargin(-5);
                                    $y = $pts[1];
                                    $this->value->SetAlign('center', 'bottom');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $this->value->SetAlign('center', 'bottom');
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $exist_x = false;
                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $rx = $pts[2];
                                    $ry = $pts[3];
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'.
            Open

                            Util\JpGraphError::RaiseL(2004, $i, $val);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\Amenadiel\JpGraph\Image\RGB' in method 'SetFillColor'.
            Open

                    $aColor           = Image\RGB::tryHexConversion($aColor);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $abswidth = round($this->width * $xscale->scale_factor, 0);
                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            if ($this->iPattern > -1) {
                                $f     = new Graph\RectPatternFactory();
                                $prect = $f->Create($this->iPattern, $this->iPatternColor, 1);
                                $prect->SetDensity($this->iPatternDensity);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $zp = $yscale->Translate(0);
                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                $img->PushColor($this->fill_color);
                            }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $this->value->SetAlign('left', 'center');
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $img->SetColor($this->color);
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $this->value->SetAlign('right', 'center');
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method SetWidth uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $this->width = $aWidth;
                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'SetPattern'.
            Open

                                Util\JpGraphError::RaiseL(2001); //('NUmber of colors is not the same as the number of patterns in BarPlot::SetPattern()');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                    } else {
                                        $fromcolor = $this->grad_fromcolor[$i % $ng][0];
                                        $tocolor   = $this->grad_fromcolor[$i % $ng][1];
                                        $style     = $this->grad_fromcolor[$i % $ng][2];
                                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'.
            Open

                            Util\JpGraphError::RaiseL(2006, $this->valuepos);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Legend uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $graph->legend->Add(
                                $this->legend,
                                $this->fill_color,
                                '',
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $x = $i;
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                $rx = $pts[2];
                                $ry = $pts[3];
                            }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $this->value->SetAlign('center', 'top');
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            Util\JpGraphError::RaiseL(2006, $this->valuepos);
                            //'Unknown position for values on bars :'.$this->valuepos);
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $exist_x = true;
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                $pcolor = $this->iPatternColor;
                            }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $fromcolor = $this->grad_fromcolor[$i % $ng][0];
                                    $tocolor   = $this->grad_fromcolor[$i % $ng][1];
                                    $style     = $this->grad_fromcolor[$i % $ng][2];
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                $grad->FilledRectangle(
                                    $pts[2],
                                    $pts[3],
                                    $pts[6],
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'.
            Open

                                    Util\JpGraphError::RaiseL(2005); //('You have specified an empty array for shadow colors in the bar plot.');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                            } else {
                                if ($val < 0) {
                                    $this->value->SetAlign('center', 'bottom');
                                } else {
                                    $this->value->SetAlign('center', 'top');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method PreStrokeAdjust uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            if ($this->align == 'center') {
                                $graph->SetTextScaleOff(0.5 - $this->width / 2);
                            } elseif ($this->align == 'right') {
                                $graph->SetTextScaleOff(1 - $this->width);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method SetPattern uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                        } else {
                            $this->iPatternColor = $aColor;
                        }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method SetPattern uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        $this->_SetPatternHelper($aPattern, $this->iPattern, $this->iPatternDensity);
                        $this->iPatternColor = $aColor;
                    }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'.
            Open

                            Util\JpGraphError::RaiseL(2003, safe_count($this->coords[1]), $numpoints);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method Stroke uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                                } else {
                                    $this->value->SetAlign('left', 'center');
                                }
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ($val > 0) {
                                $sp1[0] = $pts[6];
                                $sp1[1] = $pts[7];
                                $sp1[2] = $pts[4];
                                $sp1[3] = $pts[5];
            Severity: Major
            Found in src/plot/BarPlot.php and 1 other location - About 1 day to fix
            src/plot/BarPlot.php on lines 595..613

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 273.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            } elseif ($val < 0) {
                                $sp1[0] = $pts[4];
                                $sp1[1] = $pts[5];
                                $sp1[2] = $pts[6];
                                $sp1[3] = $pts[7];
            Severity: Major
            Found in src/plot/BarPlot.php and 1 other location - About 1 day to fix
            src/plot/BarPlot.php on lines 577..613

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 273.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            } elseif ($val < 0) {
                                $sp[0]  = $pts[4];
                                $sp[1]  = $pts[5];
                                $sp[2]  = $pts[6];
                                $sp[3]  = $pts[7];
            Severity: Major
            Found in src/plot/BarPlot.php and 1 other location - About 6 hrs to fix
            src/plot/BarPlot.php on lines 532..558

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 205.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ($val > 0) {
                                $sp[0]  = $pts[6];
                                $sp[1]  = $pts[7];
                                $sp[2]  = $pts[4];
                                $sp[3]  = $pts[5];
            Severity: Major
            Found in src/plot/BarPlot.php and 1 other location - About 6 hrs to fix
            src/plot/BarPlot.php on lines 545..558

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 205.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (isset($this->coords[1])) {
                        if (safe_count($this->coords[1]) != $numpoints) {
                            Util\JpGraphError::RaiseL(2003, safe_count($this->coords[1]), $numpoints);
                        //"Number of X and Y points are not equal. Number of X-points:". safe_count($this->coords[1])."Number of Y-points:$numpoints");
                        } else {
            Severity: Minor
            Found in src/plot/BarPlot.php and 2 other locations - About 30 mins to fix
            src/plot/LinePlot.php on lines 236..245
            src/plot/StockPlot.php on lines 98..107

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid variables with short names like $m. Configured minimum length is 3.
            Open

                    $m = parent::Min();
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $np. Configured minimum length is 3.
            Open

                        $np = safe_count($this->iPattern);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $x. Configured minimum length is 3.
            Open

                            $x = $this->coords[1][$i];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $sp. Configured minimum length is 3.
            Open

                                $sp[0]  = $pts[6];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $m. Configured minimum length is 3.
            Open

                    $m = parent::Max();
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $ng. Configured minimum length is 3.
            Open

                                $ng = safe_count($this->grad_fromcolor);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $f. Configured minimum length is 3.
            Open

                            $f = new Graph\RectPatternFactory();
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $zp. Configured minimum length is 3.
            Open

                        $zp = $yscale->scale_abs[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $rx. Configured minimum length is 3.
            Open

                                $rx = $pts[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $y. Configured minimum length is 3.
            Open

                            $y = $pts[3];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $p1. Configured minimum length is 3.
            Open

                            $p1 = $this->RotatePattern($this->iPattern[0], $graph->img->a == 90);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $p2. Configured minimum length is 3.
            Open

                            $p2 = $this->iPatternColor[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $ry. Configured minimum length is 3.
            Open

                                $ry = $pts[1];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $p3. Configured minimum length is 3.
            Open

                            $p3 = $this->iPatternDensity[0];
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $n. Configured minimum length is 3.
            Open

                        $n                     = safe_count($aPattern);
            Severity: Minor
            Found in src/plot/BarPlot.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            Method name "BarPlot::Set3D" is not in camel caps format
            Open

                public function Set3D($aHSize = 3, $aVSize = 3, $aShow = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetPattern" is not in camel caps format
            Open

                public function SetPattern($aPattern, $aColor = 'black')
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::PreStrokeAdjust" is not in camel caps format
            Open

                public function PreStrokeAdjust($graph)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetValuePos" is not in camel caps format
            Open

                public function SetValuePos($aPos)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetYBase" is not in camel caps format
            Open

                public function SetYBase($aYStartValue)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::RotatePattern" is not in camel caps format
            Open

                public function RotatePattern($aPat, $aRotate = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetWidth" is not in camel caps format
            Open

                public function SetWidth($aWidth)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::Stroke" is not in camel caps format
            Open

                public function Stroke($img, $xscale, $yscale)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetAlign" is not in camel caps format
            Open

                public function SetAlign($aAlign)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetYMin" is not in camel caps format
            Open

                public function SetYMin($aYStartValue)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetAbsWidth" is not in camel caps format
            Open

                public function SetAbsWidth($aWidth)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetNoFill" is not in camel caps format
            Open

                public function SetNoFill()
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetFillColor" is not in camel caps format
            Open

                public function SetFillColor($aColor)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "_SetPatternHelper" should not be prefixed with an underscore to indicate visibility
            Open

                public function _SetPatternHelper($aPattern, &$aPatternValue, &$aDensity)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::_SetPatternHelper" is not in camel caps format
            Open

                public function _SetPatternHelper($aPattern, &$aPatternValue, &$aDensity)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::Max" is not in camel caps format
            Open

                public function Max()
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetFillGradient" is not in camel caps format
            Open

                public function SetFillGradient($aFromColor, $aToColor = null, $aStyle = null)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::Legend" is not in camel caps format
            Open

                public function Legend($graph)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::Min" is not in camel caps format
            Open

                public function Min()
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Method name "BarPlot::SetShadow" is not in camel caps format
            Open

                public function SetShadow($aColor = 'black', $aHSize = 3, $aVSize = 3, $aShow = true)
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 139 characters
            Open

                        //"Number of X and Y points are not equal. Number of X-points:". safe_count($this->coords[1])."Number of Y-points:$numpoints");
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 132 characters
            Open

                                    Util\JpGraphError::RaiseL(2005); //('You have specified an empty array for shadow colors in the bar plot.');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 133 characters
            Open

                                    if (is_numeric($this->grad_fromcolor[0]) && $this->grad_fromcolor[0] > 0 && $this->grad_fromcolor[0] < 256) {
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 123 characters
            Open

                                // an array to specify both (from, to style) for each individual bar. The way to know the difference is
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 127 characters
            Open

                                // to investgate the first element. If this element is an integer [0,255] then we assume it is an Image\RGB
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 129 characters
            Open

                                // then we have two choices. It can either a) be a single color specified as an Image\RGB triple or it can be
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            Line exceeds 120 characters; contains 143 characters
            Open

                                Util\JpGraphError::RaiseL(2001); //('NUmber of colors is not the same as the number of patterns in BarPlot::SetPattern()');
            Severity: Minor
            Found in src/plot/BarPlot.php by phpcodesniffer

            There are no issues that match your filters.

            Category
            Status