Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/plot/ErrorLinePlot.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using undefined variables such as '$ly' which will lead to PHP notices.
Open

            $ly[] = ($datay[$i] + $datay[$i + 1]) / 2;
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$ly' which will lead to PHP notices.
Open

        $this->line = new LinePlot($ly, $datax);
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

The method __construct has a boolean flag argument $datax, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($datay, $datax = false)
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid variables with short names like $ly. Configured minimum length is 3.
Open

            $ly[] = ($datay[$i] + $datay[$i + 1]) / 2;
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $n. Configured minimum length is 3.
Open

        $n = safe_count($datay);
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method name "ErrorLinePlot::Legend" is not in camel caps format
Open

    public function Legend($graph)
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpcodesniffer

Method name "ErrorLinePlot::Stroke" is not in camel caps format
Open

    public function Stroke($img, $xscale, $yscale)
Severity: Minor
Found in src/plot/ErrorLinePlot.php by phpcodesniffer

There are no issues that match your filters.

Category
Status