Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/plot/FieldPlot.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function Stroke has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function Stroke($img, $xscale, $yscale)
    {
        // Remeber base color and size
        $bc  = $this->arrow->iColor;
        $bs  = $this->arrow->iSize;
Severity: Minor
Found in src/plot/FieldPlot.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Stroke has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function Stroke($img, $xscale, $yscale)
    {
        // Remeber base color and size
        $bc  = $this->arrow->iColor;
        $bs  = $this->arrow->iSize;
Severity: Minor
Found in src/plot/FieldPlot.php - About 1 hr to fix

    Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method '__construct'.
    Open

                Util\JpGraphError::RaiseL(20002);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method '__construct'.
    Open

                Util\JpGraphError::RaiseL(20001);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $cs. Configured minimum length is 3.
    Open

                    list($cc, $cs, $cas) = call_user_func($f, $this->coords[1][$i], $this->coords[0][$i], $this->iAngles[$i]);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $bc. Configured minimum length is 3.
    Open

            $bc  = $this->arrow->iColor;
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $xt. Configured minimum length is 3.
    Open

                $xt = $xscale->Translate($this->coords[1][$i]);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $cc. Configured minimum length is 3.
    Open

                    list($cc, $cs, $cas) = call_user_func($f, $this->coords[1][$i], $this->coords[0][$i], $this->iAngles[$i]);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $yt. Configured minimum length is 3.
    Open

                $yt = $yscale->Translate($this->coords[0][$i]);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $bs. Configured minimum length is 3.
    Open

            $bs  = $this->arrow->iSize;
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $f. Configured minimum length is 3.
    Open

                $f = $this->iCallback;
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method name "FieldPlot::SetCallback" is not in camel caps format
    Open

        public function SetCallback($aFunc)
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpcodesniffer

    Method name "FieldPlot::Legend" is not in camel caps format
    Open

        public function Legend($aGraph)
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpcodesniffer

    Method name "FieldPlot::Stroke" is not in camel caps format
    Open

        public function Stroke($img, $xscale, $yscale)
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

                    list($cc, $cs, $cas) = call_user_func($f, $this->coords[1][$i], $this->coords[0][$i], $this->iAngles[$i]);
    Severity: Minor
    Found in src/plot/FieldPlot.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status