Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/themes/OrangeTheme.php

Summary

Maintainability
F
4 days
Test Coverage

Method ApplyPlot has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function ApplyPlot($plot)
    {
        switch (get_class($plot)) {
            case 'GroupBarPlot':
                    foreach ($plot->plots as $_plot) {
Severity: Minor
Found in src/themes/OrangeTheme.php - About 1 hr to fix

    Method SetupGraph has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function SetupGraph($graph)
    {
        // graph
        /*
        $img = $graph->img;
    Severity: Minor
    Found in src/themes/OrangeTheme.php - About 1 hr to fix

      Function ApplyPlot has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function ApplyPlot($plot)
    {
        switch (get_class($plot)) {
            case 'GroupBarPlot':
                    foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/OrangeTheme.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

/**
 * JPGraph v4.0.3
 */
      Severity: Major
      Found in src/themes/OrangeTheme.php and 1 other location - About 4 days to fix
      src/themes/RoseTheme.php on lines 1..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 825.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method name "OrangeTheme::SetupPieGraph" is not in camel caps format
      Open

          public function SetupPieGraph($graph)
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Method name "OrangeTheme::ApplyPlot" is not in camel caps format
      Open

          public function ApplyPlot($plot)
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Method name "OrangeTheme::PreStrokeApply" is not in camel caps format
      Open

          public function PreStrokeApply($graph)
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Method name "OrangeTheme::GetColorList" is not in camel caps format
      Open

          public function GetColorList()
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Method name "OrangeTheme::SetupGraph" is not in camel caps format
      Open

          public function SetupGraph($graph)
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $this->ApplyPlot($_plot);
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $this->ApplyPlot($_plot);
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          foreach ($plot->plots as $_plot) {
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          }
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      Line indented incorrectly; expected 16 spaces, found 20
      Open

                          }
      Severity: Minor
      Found in src/themes/OrangeTheme.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status