The method _fileCheck has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation. Open
private function _fileCheck($filename, &$ownFixtures = [], $debug = false, $dims = [])- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method _fileCheck uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
Debug::debug(
'testing ' . $filename .
' for dims ' . \implode('x', [$__width, $__height])
);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Codeception\Util\Debug' in method '_fileCheck'. Open
Debug::debug(
'testing ' . $filename .
' for dims ' . \implode('x', [$__width, $__height])
);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Codeception\Util\Debug' in method '_fileCheck'. Open
Debug::debug(
'testing ' . $filename .
' for image/jpeg headers '
);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class ImgTest extends \Codeception\Test\Unit- Exclude checks
Method name "_fileCheck" should not be prefixed with an underscore to indicate visibility Open
private function _fileCheck($filename, &$ownFixtures = [], $debug = false, $dims = [])- Exclude checks
Method name "_before" should not be prefixed with an underscore to indicate visibility Open
protected function _before()- Exclude checks
Method name "_after" should not be prefixed with an underscore to indicate visibility Open
protected function _after()- Exclude checks
Whitespace found at end of line Open
* - Exclude checks