Sign upLogin

HumanCellAtlas/ingest-client

View on GitHub
Star

Showing 924 of 924 total issues

Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed.
Open

    def get_user_friendly_column_name(self, template, column_name, primary_schema=None):
Severity: Critical
Found in ingest/template/spreadsheet_builder.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Remove this commented out code.
Open

    # report = bundle_manifest_service.update_bundle_manifest_links(project_uuid)
Severity: Major
Found in fix_bundle_links.py by sonar-python

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

See

  • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
  • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
  • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
  • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

Method "_write_column_head" has 8 parameters, which is greater than the 7 authorized.
Open

    def _write_column_head(self, worksheet, col_number, uf, hf, desc, prog_name, tab_name):
Severity: Major
Found in ingest/template/linked_spreadsheet_builder.py by sonar-python

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

Refactor this function to reduce its Cognitive Complexity from 65 to the 15 allowed.
Open

    def build(self, spreadsheet_tabs_template):
Severity: Critical
Found in ingest/template/linked_spreadsheet_builder.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Severity
Category
Status
Source
Language