Sign upLogin

HurricaneJames/react-immutable-proptypes

View on GitHub
Star

Showing 53 of 53 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        PropTypes.mapContains({
          data: PropTypes.listOf(PropTypes.mapContains({
            id: React.PropTypes.number.isRequired
          })).isRequired
        }),
Severity: Major
Found in src/__tests__/ImmutablePropTypes-test.js and 3 other locations - About 55 mins to fix
src/__tests__/ImmutablePropTypes-test.js on lines 1630..1634
src/__tests__/ImmutablePropTypes-test.js on lines 1749..1753
src/__tests__/ImmutablePropTypes-test.js on lines 1760..1764

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      typeCheckPass(
        PropTypes.mapOf(React.PropTypes.instanceOf(Thing)),
        Immutable.Map({ 1: new Thing(), 2: new Thing() })
      );
Severity: Major
Found in src/__tests__/ImmutablePropTypes-test.js and 2 other locations - About 55 mins to fix
src/__tests__/ImmutablePropTypes-test.js on lines 778..781
src/__tests__/ImmutablePropTypes-test.js on lines 1179..1182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        PropTypes.mapContains({
          data: PropTypes.listOf(PropTypes.mapContains({
            id: React.PropTypes.number.isRequired
          })).isRequired
        }),
Severity: Major
Found in src/__tests__/ImmutablePropTypes-test.js and 3 other locations - About 55 mins to fix
src/__tests__/ImmutablePropTypes-test.js on lines 1619..1623
src/__tests__/ImmutablePropTypes-test.js on lines 1749..1753
src/__tests__/ImmutablePropTypes-test.js on lines 1760..1764

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        PropTypes.orderedMapContains({
          data: PropTypes.listOf(PropTypes.orderedMapContains({
            id: React.PropTypes.number.isRequired
          })).isRequired
        }),
Severity: Major
Found in src/__tests__/ImmutablePropTypes-test.js and 3 other locations - About 55 mins to fix
src/__tests__/ImmutablePropTypes-test.js on lines 1619..1623
src/__tests__/ImmutablePropTypes-test.js on lines 1630..1634
src/__tests__/ImmutablePropTypes-test.js on lines 1760..1764

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      typeCheckPass(
        PropTypes.orderedMapOf(React.PropTypes.instanceOf(Thing)),
        Immutable.OrderedMap({ 1: new Thing(), 2: new Thing() })
      );
Severity: Major
Found in src/__tests__/ImmutablePropTypes-test.js and 2 other locations - About 55 mins to fix
src/__tests__/ImmutablePropTypes-test.js on lines 599..602
src/__tests__/ImmutablePropTypes-test.js on lines 1179..1182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function checkType has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function checkType(isRequired, props, propName, componentName, location, propFullName, ...rest) {
Severity: Major
Found in src/ImmutablePropTypes.js - About 50 mins to fix

    Function validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      function validate(props, propName, componentName, location, propFullName, ...rest) {
    Severity: Minor
    Found in src/ImmutablePropTypes.js - About 45 mins to fix

      Function validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        function validate(props, propName, componentName, location, propFullName, ...rest) {
      Severity: Minor
      Found in src/ImmutablePropTypes.js - About 45 mins to fix

        Function validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          function validate(props, propName, componentName, location, propFullName, ...rest) {
        Severity: Minor
        Found in src/ImmutablePropTypes.js - About 45 mins to fix

          Function createChainableTypeChecker has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function createChainableTypeChecker(validate) {
  function checkType(isRequired, props, propName, componentName, location, propFullName, ...rest) {
    propFullName = propFullName || propName;
    componentName = componentName || ANONYMOUS;
    if (props[propName] == null) {
          Severity: Minor
          Found in src/ImmutablePropTypes.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function validate(props, propName, componentName, location, propFullName, ...rest) {
          Severity: Minor
          Found in src/ImmutablePropTypes.js - About 45 mins to fix

            Function validate has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              function validate(props, propName, componentName, location, propFullName) {
            Severity: Minor
            Found in src/ImmutablePropTypes.js - About 35 mins to fix

              Function createKeysTypeChecker has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function createKeysTypeChecker(typeChecker) {

  function validate(props, propName, componentName, location, propFullName, ...rest) {
    var propValue = props[propName];
    if (typeof typeChecker !== 'function') {
              Severity: Minor
              Found in src/ImmutablePropTypes.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language