Sign upLogin

IBM-Swift/Kitura

View on GitHub
Star
Sources/Kitura/MimeTypeAcceptor.swift

Summary

Maintainability
B
4 hrs
Test Coverage

Function handleMatch has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        private static func handleMatch(rawHeaderValue: String, type: String, matchAllPattern: String,
                                        criteriaMatches: inout CriteriaMatches, headerOrder: Int) {
            let parsedHeaderValue = parse(mediaType: rawHeaderValue)
            let headerType = parsedHeaderValue.type
            guard !headerType.isEmpty && parsedHeaderValue.qValue > 0.0 else {
Severity: Minor
Found in Sources/Kitura/MimeTypeAcceptor.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleMatch has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private static func handleMatch(rawHeaderValue: String, type: String, matchAllPattern: String,
                                        criteriaMatches: inout CriteriaMatches, headerOrder: Int) {
            let parsedHeaderValue = parse(mediaType: rawHeaderValue)
            let headerType = parsedHeaderValue.type
            guard !headerType.isEmpty && parsedHeaderValue.qValue > 0.0 else {
Severity: Minor
Found in Sources/Kitura/MimeTypeAcceptor.swift - About 1 hr to fix

    Function handleMatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            private static func handleMatch(rawHeaderValue: String, type: String, matchAllPattern: String,
                                        criteriaMatches: inout CriteriaMatches, headerOrder: Int) {
    Severity: Minor
    Found in Sources/Kitura/MimeTypeAcceptor.swift - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

                  return nil
      Severity: Major
      Found in Sources/Kitura/MimeTypeAcceptor.swift - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status