IBM-Swift/Kitura

View on GitHub
Sources/Kitura/RouterElement.swift

Summary

Maintainability
C
1 day
Test Coverage

Function performSimpleMatch has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private func performSimpleMatch(path: String, request: RouterRequest, response: RouterResponse, next: @escaping () -> Void) {
        guard let pattern = pattern else {
            next()
            return
        }
Severity: Minor
Found in Sources/Kitura/RouterElement.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setParameters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private func setParameters(forRequest request: RouterRequest, fromUrlPath urlPath: NSString, match: NSTextCheckingResult) {
        var parameters = mergeParameters ? request.parameters : [:]

        if let keys = keys {
            for index in 0..<keys.count {
Severity: Minor
Found in Sources/Kitura/RouterElement.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func process(request: RouterRequest, response: RouterResponse, parameterWalker: RouterParameterWalker, next: @escaping () -> Void) {
        guard let path = request.parsedURLPath.path else {
            Log.error("Failed to process request (path is nil)")
            next()
            return
Severity: Minor
Found in Sources/Kitura/RouterElement.swift - About 1 hr to fix

    Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        func process(request: RouterRequest, response: RouterResponse, parameterWalker: RouterParameterWalker, next: @escaping () -> Void) {
            guard let path = request.parsedURLPath.path else {
                Log.error("Failed to process request (path is nil)")
                next()
                return
    Severity: Minor
    Found in Sources/Kitura/RouterElement.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function performSimpleMatch has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private func performSimpleMatch(path: String, request: RouterRequest, response: RouterResponse, next: @escaping () -> Void) {
            guard let pattern = pattern else {
                next()
                return
            }
    Severity: Minor
    Found in Sources/Kitura/RouterElement.swift - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return
      Severity: Major
      Found in Sources/Kitura/RouterElement.swift - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status