Sources/Kitura/RouterRequest.swift
Function parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
fileprivate static func parse(headers: HeadersContainer) -> [String: HTTPCookie] {
var cookies = [String: HTTPCookie]()
guard let cookieHeaders = headers["cookie"] else {
return cookies
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Variable names should be lowerCamelCase Open
Open
private var _parsedURL: URLParser?- Read upRead up
- Exclude checks
lower-camel-case
method and var names should follow lowerCamelCase naming convention: first letter of the entire word is lowercase, but subsequent first letters are uppercase.
Method and selector names
Preferred
func someMethod() {
// method definition goes here
}Not Preferred
func some-method() {
// method definition goes here
}Variable names
Preferred
var someVariable = someValueNot Preferred
var Some_Var1able = someValue