IBM-Swift/Kitura

View on GitHub
Tests/KituraTests/TestRouterHTTPVerbs_generated.swift

Summary

Maintainability
D
2 days
Test Coverage

File TestRouterHTTPVerbs_generated.swift has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import XCTest
import Foundation

@testable import Kitura
@testable import KituraNet
Severity: Minor
Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift - About 3 hrs to fix

    Function testThirdTypeVerbsAdded has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func testThirdTypeVerbsAdded() {
                let router = Router()
                var verbsArray: [String] = []
                let bodyParser = BodyParser()
                verbsArray.append("ALL")
    Severity: Major
    Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift - About 2 hrs to fix

      Function testFourthTypeVerbsAdded has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func testFourthTypeVerbsAdded() {
                  let router = Router()
                  var verbsArray: [String] = []
                  let bodyParser = BodyParser()
                  verbsArray.append("ALL")
      Severity: Major
      Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift - About 2 hrs to fix

        Function testFirstTypeVerbsAdded has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            func testFirstTypeVerbsAdded() {
                    let router = Router()
                    var verbsArray: [String] = []
                    verbsArray.append("ALL")
                    router.all("/bodytest", handler: self.bodyTestHandler)
        Severity: Major
        Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift - About 2 hrs to fix

          Function testSecondTypeVerbsAdded has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              func testSecondTypeVerbsAdded() {
                      let router = Router()
                      var verbsArray: [String] = []
                      verbsArray.append("ALL")
                      router.all("/bodytest", handler: [self.bodyTestHandler, self.bodyTestHandler])
          Severity: Major
          Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift - About 2 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                static var allTests: [(String, (TestRouterHTTPVerbsGenerated) -> () throws -> Void)] {
                    return [
                        ("testFirstTypeVerbsAdded", testFirstTypeVerbsAdded),
                        ("testSecondTypeVerbsAdded", testSecondTypeVerbsAdded),
                        ("testThirdTypeVerbsAdded", testThirdTypeVerbsAdded),
            Severity: Major
            Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift and 2 other locations - About 1 hr to fix
            Tests/KituraTests/TestDecodingErrorExtension.swift on lines 21..29
            Tests/KituraTests/TestMultiplicity.swift on lines 24..31

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        for index in 0...elements.count - 1 {
                            guard elements[index].method.description == verbsArray[index] else {
                                XCTFail("didn't add all verbs")
                                return
                            }
            Severity: Major
            Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift and 3 other locations - About 50 mins to fix
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 114..119
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 261..266
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 335..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        for index in 0...elements.count - 1 {
                            guard elements[index].method.description == verbsArray[index] else {
                                XCTFail("didn't add all verbs")
                                return
                            }
            Severity: Major
            Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift and 3 other locations - About 50 mins to fix
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 114..119
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 187..192
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 335..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        for index in 0...elements.count - 1 {
                            guard elements[index].method.description == verbsArray[index] else {
                                XCTFail("didn't add all verbs")
                                return
                            }
            Severity: Major
            Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift and 3 other locations - About 50 mins to fix
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 187..192
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 261..266
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 335..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        for index in 0...elements.count - 1 {
                            guard elements[index].method.description == verbsArray[index] else {
                                XCTFail("didn't add all verbs")
                                return
                            }
            Severity: Major
            Found in Tests/KituraTests/TestRouterHTTPVerbs_generated.swift and 3 other locations - About 50 mins to fix
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 114..119
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 187..192
            Tests/KituraTests/TestRouterHTTPVerbs_generated.swift on lines 261..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status