ICTU/quality-time

View on GitHub
components/collector/src/base_collectors/source_collector.py

Summary

Maintainability
A
3 hrs
Test Coverage

File source_collector.py has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Source collector base classes."""

import asyncio
import logging
import traceback
Severity: Minor
Found in components/collector/src/base_collectors/source_collector.py - About 3 hrs to fix

    Function get_subclass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_subclass(cls, source_type: str, metric_type: str) -> type["SourceCollector"] | None:
            """Return the subclass registered for the source/metric name.
    
            First try to find a match on both source type and metric type. If no match is found, return the generic
            collector for the source type.
    Severity: Minor
    Found in components/collector/src/base_collectors/source_collector.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status