ICTU/quality-time

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("does not show an error for non-required non-empty fields", () => {
    render(<StringInput options={["Option 1", "Option 2"]} value="Hello" />)
    expect(screen.getByRole("combobox")).toBeValid()
})

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

it("sets the issue tracker password", async () => {
    renderIssueTracker()
    await userEvent.type(screen.getByText(/Password/), "secret{Enter}")
    expect(report_api.set_report_issue_tracker_attribute).toHaveBeenLastCalledWith(
        "report_uuid",

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

export function SubjectTable({
    changed_fields,
    dates,
    handleSort,
    measurements,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("does not show an error for non-required empty fields", () => {
    render(<StringInput options={["Option 1", "Option 2"]} value="" />)
    expect(screen.getByRole("combobox")).toBeValid()
})

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("displays the creation date in the label if configured", async () => {
    history.push("?show_issue_creation_date=true")
    const { queryByText } = renderIssueStatus()
    expect(queryByText(/4 days ago/)).not.toBe(null)
})

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

export function SubjectTableBody({
    changed_fields,
    dates,
    handleSort,
    measurements,

• Read up
  Read up

Function source_options has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function source_options(reports, dataModel, currentMetricType, currentMetricUuid) {
    const metricSources = dataModel.metrics[currentMetricType].sources
    let options = []
    reports.forEach((report) => {
        Object.values(report.subjects).forEach((subject) => {

Identical blocks of code found in 2 locations. Consider refactoring.

Open

console.error = (...args) => {
    if (/Support for defaultProps will be removed from function components/.test(args[0])) return
    if (/findDOMNode is deprecated and will be removed in the next major release./.test(args[0])) return
    error(...args)
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("shows the metric type even when not supported by the subject type", async () => {
    await act(async () => {
        renderSourceType("violations", "unsupported")
    })
    expect(screen.queryAllByText(/Unsupported/).length).toBe(2)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            {notification_destinations.length === 0 ? (
                <Message>
                    <Message.Header>No notification destinations</Message.Header>
                    <p>No notification destinations have been configured yet.</p>
                </Message>

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("shows the supported source versions", async () => {
    await act(async () => {
        renderSourceType("violations", "sonarqube")
    })
    expect(screen.queryAllByText(/Supported SonarQube versions: >=8.2/).length).toBe(1)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

console.error = (...args) => {
    if (/Support for defaultProps will be removed from function components/.test(args[0])) return
    if (/findDOMNode is deprecated and will be removed in the next major release./.test(args[0])) return
    error(...args)
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            {sourceSegments.length === 0 ? (
                <Message>
                    <Message.Header>No sources</Message.Header>
                    <p>No sources have been configured yet.</p>
                </Message>

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    "duplicated_lines": Metric(
        name="Duplicated lines",
        description="The number of lines that are duplicated.",
        rationale="Duplicate code makes software larger and thus potentially harder to maintain. "
        "Also, if the duplicated code contains bugs, they need to be fixed in multiple locations.",

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    "many_parameters": Metric(
        name="Many parameters",
        description="The number of units (functions, methods, procedures) that have too many parameters.",
        rationale="Units with many parameters are deemed harder to maintain.",
        rationale_urls=[

• Read up
  Read up

Function EditableTextInput has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function EditableTextInput(props) {
    let { label, required, set_value, ...otherProps } = props
    const initialValue = props.value || ""
    const [text, setText] = useState(initialValue)

Function StringInputWithSuggestions has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function StringInputWithSuggestions(props) {
    let { editableLabel, label, error, options, placeholder, required, set_value, warning, ...otherProps } = props
    placeholder = placeholder || "none"
    const initialValue = props.value || ""
    const [stringOptions, setStringOptions] = useState([

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("hides a column", async () => {
    renderSettingsPanel()
    fireEvent.click(screen.getByText(/Trend/))
    expect(history.location.search).toBe("?hidden_columns=trend")
})

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

it("hides the metrics not requiring action", async () => {
    renderSettingsPanel()
    fireEvent.click(screen.getByText(/Metrics requiring action/))
    expect(history.location.search).toBe("?metrics_to_hide=no_action_required")
})

• Read up
  Read up

Function labelDetails has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function labelDetails(issueStatus, settings) {
    let details = [<Label.Detail key="name">{issueStatus.name || "?"}</Label.Detail>]
    if (issueStatus.summary && settings.showIssueSummary.value) {
        details.push(<Label.Detail key="summary">{issueStatus.summary}</Label.Detail>)
    }