IHTSDO/component-identifier-service

View on GitHub
java-client/src/main/java/org/snomed/cis/maintenance/MaintenanceApplication.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void run(ApplicationArguments args) throws Exception {
        System.out.println("\nThis process will synchronise the sequence of every partition within every namespace\n" +
                "from the source CIS instance to the target CIS instance\n" +
                "where the partition is available on both sides.\n");

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void run(ApplicationArguments args) throws Exception {
        System.out.println("\nThis process will synchronise the sequence of every partition within every namespace\n" +
                "from the source CIS instance to the target CIS instance\n" +
                "where the partition is available on both sides.\n");

    Avoid deeply nested control flow statements.
    Open

                            for (CISPartition sourcePartition : sourcePartitions) {
                                CISPartition targetPartition = targetPartitionMap.get(sourcePartition.getPartitionId());
                                if (targetPartition != null) {
                                    System.out.println("Source Partition:" + sourcePartition.toString());
                                    System.out.println("Target Partition:" + targetPartition.toString());

      There are no issues that match your filters.

      Category
      Status