IIC2173-2015-2-Grupo2/GUI

Function searchService has 103 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function searchService($http, $window, $sessionStorage, $localStorage, $rootScope) {
    var vm = this;
    vm.newsPath = 'http://arqui8.ing.puc.cl/api/v1/private/news';
    vm.searchPath = 'http://arqui8.ing.puc.cl/api/v1/private/search';
    vm.tagsPath = 'http://arqui8.ing.puc.cl/api/v1/private/tags';

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getPeople = function() {
      return getRequest(vm.peoplePath)
            .success(function(data) { $localStorage.peopleList = _.uniq(data.people.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSPeople(); });
    };

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getCompanies = function() {
      return getRequest(vm.companiesPath)
            .success(function(data) { $localStorage.companyList = _.uniq(data.companies.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSCompanies(); });
    };

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getLocations = function() {
      return getRequest(vm.locationsPath)
            .success(function(data) { $localStorage.locationList = _.uniq(data.locations.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSLocations(); });
    };

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getCategories = function() {
      return getRequest(vm.categoriesPath)
            .success(function(data) { $localStorage.categoryList = _.uniq(data.categories.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSCategories(); });
    };

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getProviders = function() {
      return getRequest(vm.providersPath)
            .success(function(data) { $localStorage.providerList = _.uniq(data.news_providers.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSProviders(); });
    };

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    vm.getTags = function() {
      return getRequest(vm.tagsPath)
            .success(function(data) { $localStorage.tagList = _.uniq(data.tags.map(vm.tagBuilder), JSON.stringify); })
            .then(function() { return vm.getLSTags(); });
    };

• Read up
  Read up

Function navbarController has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function navbarController($rootScope, sessionService, searchService) {
    var vm = this;
    vm.session = {};
    getLSLists();

Function sessionService has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function sessionService($http, $window, $sessionStorage, $localStorage, $rootScope) {
    var vm = this;

    vm.login = function(userForm) {
      return $http({

Consider simplifying this complex logical expression.

Open

      if (sessionService.loggedIn()) {
        vm.tagCollection      = vm.tagCollection      || searchService.getLSTags();
        vm.providerCollection = vm.providerCollection || searchService.getLSProviders();
        vm.categoryCollection = vm.categoryCollection || searchService.getLSCategories();
        vm.peopleCollection   = vm.peopleCollection   || searchService.getLSPeople();

Function searchService has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  function searchService($http, $window, $sessionStorage, $localStorage, $rootScope) {

Function sessionService has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  function sessionService($http, $window, $sessionStorage, $localStorage, $rootScope) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $http({
          method: 'POST',
          url: 'http://arqui8.ing.puc.cl/api/v1/auth/signup',
          data: $.param(userForm),
          headers: {'Content-Type': 'application/x-www-form-urlencoded'}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      return $http({
        method: 'POST',
        url: 'http://arqui8.ing.puc.cl/api/v1/auth/token',
        data: $.param(userForm),
        headers: {'Content-Type': 'application/x-www-form-urlencoded'}

• Read up
  Read up

Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Open

  color: #fff;

• Exclude checks
  • Disable engine
  • Disable check

Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Open

    color: #fff;

• Exclude checks
  • Disable engine
  • Disable check

Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Open

  background: linear-gradient($gradient-initial, #fff);

• Exclude checks
  • Disable engine
  • Disable check