IIC2173-2015-2-Grupo2/GUI

View on GitHub

Showing 6 of 17 total issues

Function searchService has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function searchService($http, $window, $sessionStorage, $localStorage, $rootScope) {
    var vm = this;
    vm.newsPath = 'http://arqui8.ing.puc.cl/api/v1/private/news';
    vm.searchPath = 'http://arqui8.ing.puc.cl/api/v1/private/search';
    vm.tagsPath = 'http://arqui8.ing.puc.cl/api/v1/private/tags';
Severity: Major
Found in source/services/searchService.js - About 4 hrs to fix

    Function navbarController has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function navbarController($rootScope, sessionService, searchService) {
        var vm = this;
        vm.session = {};
        getLSLists();
    
    
    Severity: Minor
    Found in source/directives/navbar.directive.js - About 1 hr to fix

      Function sessionService has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function sessionService($http, $window, $sessionStorage, $localStorage, $rootScope) {
          var vm = this;
      
          vm.login = function(userForm) {
            return $http({
      Severity: Minor
      Found in source/services/sessionService.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

              if (sessionService.loggedIn()) {
                vm.tagCollection      = vm.tagCollection      || searchService.getLSTags();
                vm.providerCollection = vm.providerCollection || searchService.getLSProviders();
                vm.categoryCollection = vm.categoryCollection || searchService.getLSCategories();
                vm.peopleCollection   = vm.peopleCollection   || searchService.getLSPeople();
        Severity: Major
        Found in source/directives/navbar.directive.js - About 1 hr to fix

          Function searchService has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function searchService($http, $window, $sessionStorage, $localStorage, $rootScope) {
          Severity: Minor
          Found in source/services/searchService.js - About 35 mins to fix

            Function sessionService has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              function sessionService($http, $window, $sessionStorage, $localStorage, $rootScope) {
            Severity: Minor
            Found in source/services/sessionService.js - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language