Sign upLogin

IIC2173-2015-2-Grupo2/news-api

View on GitHub
Star

Showing 33 of 33 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if len(companies) != 0 {
        match = match + ", (new:NewsItem)--(co:Company)"

        names := un.MapString(func(company string) string {
            return fmt.Sprintf("\"%s\"", strings.TrimSpace(company))
Severity: Major
Found in models/new.go and 2 other locations - About 40 mins to fix
models/new.go on lines 86..96
models/new.go on lines 109..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if len(people) != 0 {
        match = match + ", (new:NewsItem)--(person:Person)"
        names := un.MapString(func(person string) string {
            return fmt.Sprintf("\"%s\"", strings.TrimSpace(person))
        }, people)
Severity: Major
Found in models/new.go and 2 other locations - About 40 mins to fix
models/new.go on lines 86..96
models/new.go on lines 98..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getOrCreateNode has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func getOrCreateNode(db *neoism.Database, label string, key string, value string, props neoism.Props) *neoism.Node {
Severity: Minor
Found in tasks/seed.go - About 35 mins to fix

    package comment should be of the form "Package tasks ..."
    Open

    //usr/bin/env go run $0 "$@"; exit
    Severity: Minor
    Found in tasks/create.go by golint

    don't use underscores in Go names; var tag_id should be tagID
    Open

                tag_id, _ := strconv.Atoi(row[3])
    Severity: Minor
    Found in tasks/seed.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package util
    Severity: Minor
    Found in util/token.go by gofmt

    2: cannot find package "github.com/IIC2173-2015-2-Grupo2/news-api/models" in any of:
    Open

        "github.com/IIC2173-2015-2-Grupo2/news-api/models"
    Severity: Minor
    Found in controllers/categories.go by govet

    if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
    Open

        } else {
    Severity: Minor
    Found in util/hash.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    //usr/bin/env go run $0 "$@"; exit
    Severity: Minor
    Found in tasks/seed.go by gofmt

    package comment should be of the form "Package tasks ..."
    Open

    //usr/bin/env go run $0 "$@"; exit
    Severity: Minor
    Found in tasks/seed.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    //usr/bin/env go run $0 "$@"; exit
    Severity: Minor
    Found in tasks/create.go by gofmt

    a blank import should be only in a main or test package, or have a comment justifying it
    Open

        _ "github.com/lib/pq"
    Severity: Minor
    Found in tasks/create.go by golint

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package models
    Severity: Minor
    Found in models/new.go by gofmt
    Severity
    Category
    Status
    Source
    Language