Sign upLogin

IL2HorusTeam/il2fb-mission-parser

View on GitHub
Star

Showing 39 of 39 total issues

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, id, belligerent, code, pos, rotation_angle, type):
Severity: Minor
Found in il2fb/parsers/mission/sections/nstationary.py - About 45 mins to fix

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_target_parser():
    with ParserWrapper(TargetSectionParser, 'Target', generate_target_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_buildings_parser():
    with ParserWrapper(BuildingsSectionParser, 'Buildings', generate_buildings_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_chief_road_parser():
    with ParserWrapper(ChiefRoadSectionParser, '0_Chief_Road', generate_cheif_road_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_front_marker_parser():
    with ParserWrapper(FrontMarkerSectionParser, 'FrontMarker', generate_front_marker_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_rocket_parser():
    with ParserWrapper(RocketSectionParser, 'Rocket', generate_rocket_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_born_place_parser():
    with ParserWrapper(BornPlaceSectionParser, 'BornPlace', generate_born_place_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_nstationary_parser():
    with ParserWrapper(NStationarySectionParser, 'NStationary', generate_nstationary_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113
    profiling/profiling.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    @profile
def profile_flight_route_parser():
    with ParserWrapper(FlightRouteSectionParser, '3GvIAP01_Way', generate_flight_route_lines) as pw:
        for line in pw.lines:
            pw.parse_line(line)
    Severity: Major
    Found in profiling/profiling.py and 8 other locations - About 45 mins to fix
    profiling/profiling.py on lines 60..64
    profiling/profiling.py on lines 67..71
    profiling/profiling.py on lines 74..78
    profiling/profiling.py on lines 81..85
    profiling/profiling.py on lines 88..92
    profiling/profiling.py on lines 95..99
    profiling/profiling.py on lines 102..106
    profiling/profiling.py on lines 109..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    Severity: Minor
    Found in il2fb/parsers/__init__.py and 1 other location - About 40 mins to fix
    il2fb/__init__.py on lines 0..7

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    Severity: Minor
    Found in il2fb/__init__.py and 1 other location - About 40 mins to fix
    il2fb/parsers/__init__.py on lines 0..7

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, id, belligerent, code, pos, rotation_angle):
    Severity: Minor
    Found in il2fb/parsers/mission/sections/buildings.py - About 35 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, type, pos, speed, formation, radio_silence):
      Severity: Minor
      Found in il2fb/parsers/mission/sections/wing.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, pos, is_checkpoint, delay=None, section_length=None,
        Severity: Minor
        Found in il2fb/parsers/mission/sections/chiefs.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  pos, radius, params = params[1:3], params[3], params[4:]
          Severity: Minor
          Found in il2fb/parsers/mission/sections/target.py and 1 other location - About 35 mins to fix
          il2fb/parsers/mission/sections/wing.py on lines 221..221

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(
        self, type, pos, speed, formation, radio_silence,
        target_id=None, target_route_point=None,
    ):
        super(FlightRouteAttackPoint, self).__init__(
          Severity: Minor
          Found in il2fb/parsers/mission/sections/wing.py and 1 other location - About 35 mins to fix
          il2fb/parsers/mission/sections/wing.py on lines 151..156

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, type, pos, speed, formation, radio_silence, delay,
                 spacing):
        super(FlightRouteTakeoffPoint, self).__init__(
            type, pos, speed, formation, radio_silence)
        self.delay = delay
          Severity: Minor
          Found in il2fb/parsers/mission/sections/wing.py and 1 other location - About 35 mins to fix
          il2fb/parsers/mission/sections/wing.py on lines 182..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      pos, speed, params = params[0:3], params[3], params[4:]
          Severity: Minor
          Found in il2fb/parsers/mission/sections/wing.py and 1 other location - About 35 mins to fix
          il2fb/parsers/mission/sections/target.py on lines 93..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _parse_extra has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _parse_extra(self, params):
        if self._is_new_game_version(params):
            radio_silence, formation, params = self._parse_new_version_extra(params)
            if params:
                self._parse_target(params)
          Severity: Minor
          Found in il2fb/parsers/mission/sections/wing.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language