Sign upLogin

IMcPwn/browser-backdoor

View on GitHub
Star

Showing 714 of 714 total issues

Use 2 (not 4) spaces for indentation.
Open

    @@configfile = nil
Severity: Minor
Found in server/lib/bbs/config.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Trailing whitespace detected.
Open
Severity: Minor
Found in server/lib/bbs/config.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in server/lib/bbs/config.rb by rubocop

Redundant return detected.
Open

        return @@log
Severity: Minor
Found in server/lib/bbs/config.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

1 trailing blank lines detected.
Open

Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

Line is too long. [142/80]
Open

        "exec" => "Execute commands on the targeted session interactively. Provide an argument to execute a file's contents (e.g. a module).",
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

Use self.getCommands instead of Constants.getCommands.
Open

    def Constants.getCommands()
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cop checks for uses of the class/module name instead of self, when defining class/module methods.

Example:

# bad
class SomeClass
  def SomeClass.class_method
    # ...
  end
end

# good
class SomeClass
  def self.class_method
    # ...
  end
end

Redundant return detected.
Open

        return @commands
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        "target" => "Select or show targeted session.",
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use 2 (not 4) spaces for indentation.
Open

                    Bbs::WebSocket.sendCommand(cmd, wsList[selected])
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

                file = File.open(cmdIn[1], "r")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

                begin
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

            Bbs::PrintColor.print_notice("Currently targeted session is #{wss.getSelected()}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

            system("./" + path)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Space missing to the left of {.
Open

            puts Dir.glob('*').select{ |e| File.directory? e }.join(' ').colorize(:blue)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

1 trailing blank lines detected.
Open

Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Use 2 (not 4) spaces for indentation.
Open

                log.info("Help command called.")
Severity: Minor
Found in server/bbsconsole.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [93/80]
Open

                    log.error("Could not open file to execute in execCommand: #{e.message}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Use 2 (not 4) spaces for indentation.
Open

                log.info("Ls command called.")
Severity: Minor
Found in server/bbsconsole.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [86/80]
Open

            Bbs::PrintColor.print_error("Usage is cat FILE_PATH. Type help for help.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop
Severity
Category
Status
Source
Language