Sign upLogin

IMcPwn/browser-backdoor

View on GitHub
Star

Showing 714 of 714 total issues

Use 2 (not 4) spaces for indentation.
Open

                Bbs::PrintColor.print_error("Error reading module #{currModule}: #{e.message}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Extra empty line detected at module body beginning.
Open


module Constants
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Use 2 (not 4) spaces for indentation.
Open

        return @commands
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [81/80]
Open

                Bbs::PrintColor.print_error("Error deleting file: #{e.message}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Use snake_case for variable names.
Open

    @welcomeMessage = ""\
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Omit the parentheses in defs when the method doesn't accept any arguments.
Open

    def Constants.getWelcomeMessage()
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

This cop checks for parentheses in the definition of a method, that does not take any arguments. Both instance and class/singleton methods are checked.

Example:

# bad
def foo()
  # does a thing
end

# good
def foo
  # does a thing
end

# also good
def foo() does_a_thing end

Example:

# bad
def Baz.foo()
  # does a thing
end

# good
def Baz.foo
  # does a thing
end

Use snake_case for method names.
Open

    def Command.catCommand(log, cmdIn)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    @welcomeMessage = ""\
Severity: Minor
Found in server/lib/bbs/constants.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use snake_case for variable names.
Open

            wsSendCmd = "ws.send(" + cmdSend + ");"
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Use 2 (not 4) spaces for indentation.
Open

                current = index.to_s + " / " + Bbs::WebSocket.convertIP(val) + " / " + val.to_s
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

            if !Bbs::WebSocket.validSession?(wss.getSelected(), wss.getWsList())
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

                log.error("Error opening file in cat: #{e.message}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Useless assignment to variable - e.
Open

            rescue => e
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Line is too long. [90/80]
Open

                Bbs::PrintColor.print_error("Error executing info command: #{e.message}.")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Line is too long. [95/80]
Open

        Bbs::PrintColor.print_notice("Selected session is now " + wss.getSelected().to_s + ".")
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Line is too long. [88/80]
Open

            puts Dir.glob('*').select{ |e| File.directory? e }.join(' ').colorize(:blue)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

Use snake_case for method names.
Open

    def Command.targetCommand(wss, cmdIn)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

    def Command.lsCommand(cmdIn)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for variable names.
Open

    def Command.sessionsCommand(selected, wsList)
Severity: Minor
Found in server/lib/bbs/commands.rb by rubocop

This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
fooBar = 1

# good
foo_bar = 1

Example: EnforcedStyle: camelCase

# bad
foo_bar = 1

# good
fooBar = 1

Use 2 (not 4) spaces for indentation.
Open

                if Bbs::WebSocket.validSession?(wss.getSelected(), wss.getWsList())
Severity: Minor
Found in server/bbsconsole.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end
Severity
Category
Status
Source
Language