Sign upLogin

IRC-SPHERE/HyperStream

View on GitHub
Star
hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py

Summary

Maintainability
A
45 mins
Test Coverage

Function _execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _execute(self, sources, alignment_stream, interval):
        # Combine the data, apply the mapping and sort (inefficient!)
        results = dict()
        for source in sources:
            data = source.window(interval, force_calculation=True)
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (81 > 79 characters)
Open

#  The above copyright notice and this permission notice shall be included in all
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (113 > 79 characters)
Open

    This tool aggregates over a given plate, for example, if the input is all the streams in a node on plate A.B,
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (80 > 79 characters)
Open

#  OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Do not use bare 'except'
Open

            except:
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:

Expected 2 blank lines, found 1
Open

class AggregateIntoDictAndApply(AggregateTool):
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Separate top-level function and class definitions with two blank lines.

Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

Line too long (80 > 79 characters)
Open

    and the aggregation is over plate B, the results will live on plate A alone.
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (118 > 79 characters)
Open

    This version differs from Aggregate in that the timestamps are maintained, and the meta data is put into the value
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Missing whitespace after ','
Open

            for timestamp,value in data:
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

Line too long (91 > 79 characters)
Open

    This can also be thought of as marginalising one dimension of a tensor over the plates.
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (111 > 79 characters)
Open

        super(AggregateIntoDictAndApply, self).__init__(func=func, aggregation_meta_data=aggregation_meta_data)
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Blank line at end of file
Open

Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Trailing blank lines are superfluous.

Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

Test for membership should be 'not in'
Open

                if not timestamp in results.keys():
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Negative comparison should be done using "not in" and "is not".

Okay: if x not in y:\n    pass
Okay: assert (X in Y or X is Z)
Okay: if not (X in Y):\n    pass
Okay: zz = x is not y
E713: Z = not X in Y
E713: if not X.B in Y:\n    pass
E714: if not X is Y:\n    pass
E714: Z = not X.B is Y

Line too long (80 > 79 characters)
Open

#  of this software and associated documentation files (the "Software"), to deal
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Missing whitespace after ','
Open

        return sorted(results.values(),key=lambda x: x.timestamp)
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

Missing whitespace after ','
Open

                    results[timestamp] = StreamInstance(timestamp,dict())
Severity: Minor
Found in hyperstream/tools/aggregate_into_dict_and_apply/2017-05-26_v0.0.1.py by pep8

Each comma, semicolon or colon should be followed by whitespace.

Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

There are no issues that match your filters.

Category
Status