Sign upLogin

Ikagaka/ghost-kernel.js

View on GitHub
Star
lib/components/ShioriResources.ts

Summary

Maintainability
A
40 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  constructor(name: string, url: string, banner: string, script: string) {
    this._name = name;
    this._url = url;
    this._banner = banner;
    this._script = script;
Severity: Minor
Found in lib/components/ShioriResources.ts and 1 other location - About 40 mins to fix
lib/components/ShioriVersionInfo.ts on lines 7..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File name must be camelCase
Open

// tslint:disable max-classes-per-file
Severity: Minor
Found in lib/components/ShioriResources.ts by tslint

Rule: file-name-casing

Enforces a consistent file naming convention

Rationale

Helps maintain a consistent style across a file hierarchy

Config

One of the following arguments must be provided:

  • camel-case: File names must be camel-cased: fileName.ts.
  • pascal-case: File names must be Pascal-cased: FileName.ts.
  • kebab-case: File names must be kebab-cased: file-name.ts.
  • snake-case: File names must be snake-cased: file_name.ts.
  • ignore: File names are ignored (useful for the object configuration).

Or an object, where the key represents a regular expression that matches the file name, and the value is the file name rule from the previous list.

  • { ".tsx": "pascal-case", ".ts": "camel-case" }
Examples
"file-name-casing": true,camel-case
"file-name-casing": true,pascal-case
"file-name-casing": true,kebab-case
"file-name-casing": true,snake-case
"file-name-casing": true,[object Object]
"file-name-casing": true,[object Object]
"file-name-casing": true,[object Object]
Schema
{
  "type": "array",
  "items": {
    "anyOf": [
      {
        "type": "array",
        "items": [
          {
            "type": "string",
            "enum": [
              "camel-case",
              "ignore",
              "pascal-case",
              "kebab-case",
              "snake-case"
            ]
          }
        ]
      },
      {
        "type": "object",
        "additionalProperties": {
          "type": "string",
          "enum": [
            "camel-case",
            "ignore",
            "pascal-case",
            "kebab-case",
            "snake-case"
          ]
        },
        "minProperties": 1
      }
    ]
  }
}

For more information see this page.

There are no issues that match your filters.

Category
Status