Sign upLogin

Ilshidur/can-iframe-url

View on GitHub
Star

Showing 4 of 4 total issues

Function canIframeHeader has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

const canIframeHeader = (h, originUrl, domain) => {
  // header is 'X-Frame-Options' value
  const header = h ? h.toLowerCase() : null

  const originDomain = (new URL(originUrl)).hostname
Severity: Minor
Found in index.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return false
Severity: Major
Found in index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return url.hostname === domain
    Severity: Major
    Found in index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return false
      Severity: Major
      Found in index.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language