Sign upLogin

Ilshidur/node-mercure

View on GitHub
Star

Showing 24 of 24 total issues

Function onSseConnection has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async onSseConnection(client, { topic: topics, 'Last-Event-ID': queryLastEventId }) {
    // Check the allowed topics in the subscriber's JWT.
    let claims;
    try {
      claims = await this.authorizeSubscribe(client.req);
Severity: Major
Found in src/hub.js - About 2 hrs to fix

    Function onSseConnection has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      async onSseConnection(client, { topic: topics, 'Last-Event-ID': queryLastEventId }) {
    // Check the allowed topics in the subscriber's JWT.
    let claims;
    try {
      claims = await this.authorizeSubscribe(client.req);
    Severity: Minor
    Found in src/hub.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function publishEndpointHandler has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publishEndpointHandler() {
  return async (req, res, next) => {
    const hub = req.app.get('hub');

    // Authorize publisher
    Severity: Major
    Found in src/server.js - About 2 hrs to fix

      Function useEncryption has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async useEncryption({
    rsaPrivateKey = null,
    // TODO: Support jwks
    passphrase = null
    // TODO: Support RSA key passphrase
      Severity: Minor
      Found in src/publisher.js - About 1 hr to fix

        Function authorize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        async function authorize(req, jwtKey, publishAllowedOrigins = []) {
  const authHeader = req.headers['authorization'];

  let token;
        Severity: Minor
        Found in src/authorization.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function publish has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async publish(topics, message, options = {}) {
    if (this.hub) {
      return await this.hub.dispatchUpdate(topics, message, options)
    }
        Severity: Minor
        Found in src/publisher.js - About 1 hr to fix

          Function authorize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function authorize(req, jwtKey, publishAllowedOrigins = []) {
  const authHeader = req.headers['authorization'];

  let token;
          Severity: Minor
          Found in src/authorization.js - About 1 hr to fix

            Function validateConfig has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function validateConfig(config) {
  const validatedConfig = config;

  // Required configurations
  if (!validatedConfig.host) {
            Severity: Minor
            Found in src/publisher.js - About 1 hr to fix

              Function constructor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                constructor(server, config) {
    super();

    this.config = {
      ...defaultOptions,
              Severity: Minor
              Found in src/hub.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function publish has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                async publish(topics, message, options = {}) {
    if (this.hub) {
      return await this.hub.dispatchUpdate(topics, message, options)
    }
              Severity: Minor
              Found in src/publisher.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function validateConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function validateConfig(config) {
  const validatedConfig = config;

  // Required configurations
  if (!validatedConfig.host) {
              Severity: Minor
              Found in src/publisher.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (!claims && !this.config.allowAnonymous) {
      client.res.writeHead(403);
      client.res.write('Forbidden');
      client.res.end();
      return;
              Severity: Minor
              Found in src/hub.js and 1 other location - About 40 mins to fix
              src/hub.js on lines 93..98

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (!topics) {
      client.res.writeHead(400);
      client.res.write('Missing "topic" parameter');
      client.res.end();
      return;
              Severity: Minor
              Found in src/hub.js and 1 other location - About 40 mins to fix
              src/hub.js on lines 86..91

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                async delete(subscriber) {
    this.list.delete(subscriber);

    if (this.redisClient) {
      await this.syncRedis();
              Severity: Minor
              Found in src/subscribers_store.js and 1 other location - About 35 mins to fix
              src/subscribers_store.js on lines 46..52

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                async add(subscriber) {
    this.list.add(subscriber);

    if (this.redisClient) {
      await this.syncRedis();
              Severity: Minor
              Found in src/subscribers_store.js and 1 other location - About 35 mins to fix
              src/subscribers_store.js on lines 54..60

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                authorizePublish(req) {
    return authorize(req, this.config.pubJwtKey || this.config.jwtKey, this.config.publishAllowedOrigins);
  }
              Severity: Minor
              Found in src/hub.js and 1 other location - About 35 mins to fix
              src/hub.js on lines 70..72

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                authorizeSubscribe(req) {
    return authorize(req, this.config.subJwtKey || this.config.jwtKey, this.config.publishAllowedOrigins);
  }
              Severity: Minor
              Found in src/hub.js and 1 other location - About 35 mins to fix
              src/hub.js on lines 67..69

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                    return res.status(400).send(`Exceeded limit of ${hub.config.maxTopics} topics`);
              Severity: Major
              Found in src/server.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return res.status(401).send('Unauthorized');
                Severity: Major
                Found in src/server.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return;
                  Severity: Major
                  Found in src/hub.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language