Sign upLogin

Ilshidur/node-mercure

View on GitHub
Star

Showing 18 of 24 total issues

Function onSseConnection has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async onSseConnection(client, { topic: topics, 'Last-Event-ID': queryLastEventId }) {
    // Check the allowed topics in the subscriber's JWT.
    let claims;
    try {
      claims = await this.authorizeSubscribe(client.req);
Severity: Major
Found in src/hub.js - About 2 hrs to fix

    Function onSseConnection has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      async onSseConnection(client, { topic: topics, 'Last-Event-ID': queryLastEventId }) {
    // Check the allowed topics in the subscriber's JWT.
    let claims;
    try {
      claims = await this.authorizeSubscribe(client.req);
    Severity: Minor
    Found in src/hub.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function publishEndpointHandler has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publishEndpointHandler() {
  return async (req, res, next) => {
    const hub = req.app.get('hub');

    // Authorize publisher
    Severity: Major
    Found in src/server.js - About 2 hrs to fix

      Function useEncryption has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async useEncryption({
    rsaPrivateKey = null,
    // TODO: Support jwks
    passphrase = null
    // TODO: Support RSA key passphrase
      Severity: Minor
      Found in src/publisher.js - About 1 hr to fix

        Function authorize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        async function authorize(req, jwtKey, publishAllowedOrigins = []) {
  const authHeader = req.headers['authorization'];

  let token;
        Severity: Minor
        Found in src/authorization.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function publish has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async publish(topics, message, options = {}) {
    if (this.hub) {
      return await this.hub.dispatchUpdate(topics, message, options)
    }
        Severity: Minor
        Found in src/publisher.js - About 1 hr to fix

          Function authorize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function authorize(req, jwtKey, publishAllowedOrigins = []) {
  const authHeader = req.headers['authorization'];

  let token;
          Severity: Minor
          Found in src/authorization.js - About 1 hr to fix

            Function validateConfig has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function validateConfig(config) {
  const validatedConfig = config;

  // Required configurations
  if (!validatedConfig.host) {
            Severity: Minor
            Found in src/publisher.js - About 1 hr to fix

              Function constructor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                constructor(server, config) {
    super();

    this.config = {
      ...defaultOptions,
              Severity: Minor
              Found in src/hub.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function publish has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                async publish(topics, message, options = {}) {
    if (this.hub) {
      return await this.hub.dispatchUpdate(topics, message, options)
    }
              Severity: Minor
              Found in src/publisher.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function validateConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function validateConfig(config) {
  const validatedConfig = config;

  // Required configurations
  if (!validatedConfig.host) {
              Severity: Minor
              Found in src/publisher.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                    return res.status(400).send(`Exceeded limit of ${hub.config.maxTopics} topics`);
              Severity: Major
              Found in src/server.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return res.status(401).send('Unauthorized');
                Severity: Major
                Found in src/server.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return;
                  Severity: Major
                  Found in src/hub.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return res.status(400).send('Invalid "retry" parameter');
                    Severity: Major
                    Found in src/server.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return next(err);
                      Severity: Major
                      Found in src/server.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return res.status(200).send(updateId);
                        Severity: Major
                        Found in src/server.js - About 30 mins to fix

                          Function isSubscribed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            isSubscribed(update) {
    for (const subscriberTopic of this.topics) {
      for (const updateTopic of update.topics) {
        if (subscriberTopic.test(updateTopic)) {
          return true;
                          Severity: Minor
                          Found in src/subscriber.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language