Sign upLogin

IlyaGusev/rulm

View on GitHub
Star
data_processing/save_mc4.py

Summary

Maintainability
D
2 days
Test Coverage

Function clean_text has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

def clean_text(text, text_processor):
    text = text_processor(text)
    if not text:
        return
Severity: Minor
Found in data_processing/save_mc4.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def main(
    output_path,
    news_output_path
):
    output_archive = PlainArchive(output_path)
Severity: Minor
Found in data_processing/save_mc4.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return
Severity: Major
Found in data_processing/save_mc4.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return
    Severity: Major
    Found in data_processing/save_mc4.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return
      Severity: Major
      Found in data_processing/save_mc4.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return
        Severity: Major
        Found in data_processing/save_mc4.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return text
          Severity: Major
          Found in data_processing/save_mc4.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return
            Severity: Major
            Found in data_processing/save_mc4.py - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              if __name__ == "__main__":
    parser = argparse.ArgumentParser()
    parser.add_argument("output_path", type=str)
    parser.add_argument("news_output_path", type=str)
    args = parser.parse_args()
              Severity: Major
              Found in data_processing/save_mc4.py and 2 other locations - About 3 hrs to fix
              data_processing/convert_yandex_q.py on lines 78..83
              data_processing/create_librusec.py on lines 76..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status