Sign upLogin

IlyaGusev/rulm

View on GitHub
Star
self_instruct/crowd/aggregate.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function main has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def main(
    token,
    agg_output,
    raw_output,
    pools_file,
Severity: Minor
Found in self_instruct/crowd/aggregate.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function aggregate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def aggregate(records, overlap=5, min_agreement=0.0):
    results = defaultdict(list)
    records.sort(key=lambda x: x["assignment_id"])
    for r in records:
        results[get_key(r)].append(r["result"])
Severity: Minor
Found in self_instruct/crowd/aggregate.py - About 1 hr to fix

    Function main has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def main(
    token,
    agg_output,
    raw_output,
    pools_file,
    Severity: Minor
    Found in self_instruct/crowd/aggregate.py - About 1 hr to fix

      Function get_pool has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_pool(pool_id, toloka_client):
    records = []
    for assignment in toloka_client.get_assignments(pool_id=pool_id):
        solutions = assignment.solutions
        if not solutions:
      Severity: Minor
      Found in self_instruct/crowd/aggregate.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def main(
      Severity: Minor
      Found in self_instruct/crowd/aggregate.py - About 35 mins to fix

        Function aggregate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def aggregate(records, overlap=5, min_agreement=0.0):
    results = defaultdict(list)
    records.sort(key=lambda x: x["assignment_id"])
    for r in records:
        results[get_key(r)].append(r["result"])
        Severity: Minor
        Found in self_instruct/crowd/aggregate.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            with open(os.path.expanduser(token), "r") as r:
        toloka_token = r.read().strip()
        Severity: Minor
        Found in self_instruct/crowd/aggregate.py and 1 other location - About 30 mins to fix
        self_instruct/crowd/upload.py on lines 76..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status