Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star
htdocs/include/notification_functions.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationCategoryInfo'.
Open

    return icms_data_notification_Handler::categoryInfo();
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationEventEnabled'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationCommentCategoryInfo'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::commentCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationCommentCategoryInfo'.
Open

    return icms_data_notification_Handler::commentCategoryInfo();
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationGenerateConfig'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::generateConfig', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationEnabled'.
Open

    return icms_data_notification_Handler::isEnabled($style);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationCategoryInfo'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationSubscribableCategoryInfo'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::subscribableCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationEvents'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationGenerateConfig'.
Open

    return icms_data_notification_Handler::generateConfig($category, $event, $type);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationEnabled'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::isEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_core_Debug' in method 'notificationEventInfo'.
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationEvents'.
Open

    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationEventEnabled'.
Open

    return icms_data_notification_Handler::eventEnabled($category, $event, $module);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationEventInfo'.
Open

    return icms_data_notification_Handler::eventInfo($category_name, $event_name);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'icms_data_notification_Handler' in method 'notificationSubscribableCategoryInfo'.
Open

    return icms_data_notification_Handler::subscribableCategoryInfo($module_id);
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$module_id'.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$module_id'.
Open

function notificationEnabled($style, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$category_name'.
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$module_id'.
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$module_id'.
Open

function &notificationCommentCategoryInfo($module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

TODO found
Open

// TODO: some way to include or exclude admin-only events...
Severity: Minor
Found in htdocs/include/notification_functions.php by fixme

TODO found
Open

 *        all notification categories must have unique item_name. (TODO)
Severity: Minor
Found in htdocs/include/notification_functions.php by fixme

FIXME found
Open

// FIXME: Do some caching, so we don't retrieve the same category / event
Severity: Minor
Found in htdocs/include/notification_functions.php by fixme

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::isEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::subscribableCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::generateConfig', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method subscribableCategoryInfo from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::subscribableCategoryInfo($module_id);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Saw an @param annotation for name, but it was not found in the param list of function notificationCategoryInfo(mixed|string $category_name = '', int $module_id = null) : mixed;
Open

 * @param  string  $name       Category name (default all categories)
Severity: Info
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method commentCategoryInfo from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::commentCategoryInfo();
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method eventEnabled from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::eventEnabled($category, $event, $module);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method isEnabled from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::isEnabled($style);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::subscribableCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::generateConfig', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method categoryInfo from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::categoryInfo();
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Reference to undeclared constant \_CORE_REMOVE_IN_VERSION
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::commentCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Minor
Found in htdocs/include/notification_functions.php by phan

Call to method generateConfig from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::generateConfig($category, $event, $type);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method eventInfo from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::eventInfo($category_name, $event_name);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::isEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method setDeprecated from undeclared class \icms_core_Debug
Open

    icms_core_Debug::setDeprecated('icms_data_notification_Handler::commentCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

Call to method categoryEvents from undeclared class \icms_data_notification_Handler
Open

    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);
Severity: Critical
Found in htdocs/include/notification_functions.php by phan

The parameter $module_id is not named in camelCase.
Open

function &notificationSubscribableCategoryInfo($module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::subscribableCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::subscribableCategoryInfo($module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $module_id is not named in camelCase.
Open

function notificationEnabled($style, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::isEnabled', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::isEnabled($style);
}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $category_name is not named in camelCase.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::eventInfo($category_name, $event_name);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $module_id is not named in camelCase.
Open

function &notificationCommentCategoryInfo($module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::commentCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::commentCategoryInfo();
}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $event_name is not named in camelCase.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::eventInfo($category_name, $event_name);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $category_name is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $module_id is not named in camelCase.
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryInfo();
}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $module_id is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $category_name is not named in camelCase.
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryInfo();
}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $enabled_only is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $module_id is not named in camelCase.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::eventInfo($category_name, $event_name);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Incorrect spacing between argument "$category_name" and equals sign; expected 1 but found 0
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function &notificationSubscribableCategoryInfo($module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$category_name"; expected 1 but found 0
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function notificationEnabled($style, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function notificationEnabled($style, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function &notificationCommentCategoryInfo($module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function &notificationCommentCategoryInfo($module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function &notificationCategoryInfo($category_name='', $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between default value and equals sign for argument "$module_id"; expected 1 but found 0
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Incorrect spacing between argument "$module_id" and equals sign; expected 1 but found 0
Open

function &notificationSubscribableCategoryInfo($module_id=null) {
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpcodesniffer

The variable $module_id is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $event_name is not named in camelCase.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::eventInfo($category_name, $event_name);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $enabled_only is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $module_id is not named in camelCase.
Open

function &notificationSubscribableCategoryInfo($module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::subscribableCategoryInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::subscribableCategoryInfo($module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $category_name is not named in camelCase.
Open

function &notificationEvents($category_name, $enabled_only, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::categoryEvents', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::categoryEvents($category_name, $enabled_only, $module_id);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $category_name is not named in camelCase.
Open

function &notificationEventInfo($category_name, $event_name, $module_id=null) {
    icms_core_Debug::setDeprecated('icms_data_notification_Handler::eventInfo', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
    return icms_data_notification_Handler::eventInfo($category_name, $event_name);

}
Severity: Minor
Found in htdocs/include/notification_functions.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status