Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star
htdocs/install/class/settingmanager.php

Summary

Maintainability
B
7 hrs
Test Coverage

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_SERVER.
Open

    function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

readPost accesses the super-global variable $_POST.
Open

    function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
Severity: Minor
Found in htdocs/install/class/settingmanager.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method confirmForm has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function confirmForm() {
        $yesno = empty($this->db_pconnect) ? _INSTALL_L24 : _INSTALL_L23;
        $ret =
            "<table border='0' cellpadding='0' cellspacing='0' valign='top' width='90%'><tr><td class='bg2'>
                <table width='100%' border='0' cellpadding='4' cellspacing='1'>
Severity: Major
Found in htdocs/install/class/settingmanager.php - About 2 hrs to fix

    Method editform has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function editform() {
        $ret =
            "<table width='100%' class='outer' cellspacing='5'>
                <tr>
                    <th colspan='2'></th>
    Severity: Minor
    Found in htdocs/install/class/settingmanager.php - About 1 hr to fix

      Function readPost has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function readConstant has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          function readConstant() {
        if (defined('XOOPS_DB_TYPE'))
        $this->database = XOOPS_DB_TYPE;
        if (defined('XOOPS_DB_HOST'))
        $this->dbhost = XOOPS_DB_HOST;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function checkData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          function checkData() {
        $ret = '';
        $error = array();

        if (empty($this->dbhost)) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          function __construct($post=false) {

        $this->sanitizer =& icms_core_Textsanitizer::getInstance();
        if ($post) {
            $this->readPost();
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method readConstant() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
      Open

          function readConstant() {
        if (defined('XOOPS_DB_TYPE'))
        $this->database = XOOPS_DB_TYPE;
        if (defined('XOOPS_DB_HOST'))
        $this->dbhost = XOOPS_DB_HOST;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method readPost() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
      Open

          function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method readPost() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          function readPost() {
        if (isset($_POST['database']))
        $this->database = $this->sanitizer->stripSlashesGPC($_POST['database']);
        if (isset($_POST['dbhost']))
        $this->dbhost = $this->sanitizer->stripSlashesGPC($_POST['dbhost']);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method readConstant() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          function readConstant() {
        if (defined('XOOPS_DB_TYPE'))
        $this->database = XOOPS_DB_TYPE;
        if (defined('XOOPS_DB_HOST'))
        $this->dbhost = XOOPS_DB_HOST;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method __construct has a boolean flag argument $post, which is a certain sign of a Single Responsibility Principle violation.
      Open

          function __construct($post=false) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Avoid using static access to class 'icms_core_Textsanitizer' in method '__construct'.
      Open

              $this->sanitizer =& icms_core_Textsanitizer::getInstance();
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms_core_Filesystem' in method 'getDBList'.
      Open

              $list = icms_core_Filesystem::getDirList($dirname);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms_core_Password' in method 'generatePrefix'.
      Open

              return icms_core_Password::createSalt(5);;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $this->database = 'mysql';
            $this->dbhost = 'localhost';

            $this->db_pconnect = 0;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      TODO found
      Open

              // TODO: Add any verification of compatibility between the database drivers and the system.
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by fixme

      Reference to undeclared constant \_INSTALL_L55
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L55);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L64
      Open

              $ret .= $this->editform_sub(_INSTALL_L29, _INSTALL_L64, 'dbname', $this->sanitizer->htmlSpecialChars($this->dbname));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L29
      Open

                              <td class='bg3'><b>"._INSTALL_L29."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L57
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L55);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L52
      Open

              $ret .= $this->editform_sub(_INSTALL_L52, _INSTALL_L68, 'dbpass', $this->sanitizer->htmlSpecialChars($this->dbpass));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L55
      Open

              $ret .= $this->editform_sub(_INSTALL_L55, _INSTALL_L59, 'root_path', $this->sanitizer->htmlSpecialChars($this->root_path));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L69
      Open

                              <span style='font-size:85%;'>"._INSTALL_L69."</span>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L58
      Open

              $ret .= $this->editform_sub(_INSTALL_L56, _INSTALL_L58, 'xoops_url', $this->sanitizer->htmlSpecialChars($this->xoops_url));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L55
      Open

                              <td class='bg3'><b>"._INSTALL_L55."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L66
      Open

                              <span style='font-size:85%;'>"._INSTALL_L66."</span>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L59
      Open

              $ret .= $this->editform_sub(_INSTALL_L55, _INSTALL_L59, 'root_path', $this->sanitizer->htmlSpecialChars($this->root_path));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L23
      Open

              $yesno = empty($this->db_pconnect) ? _INSTALL_L24 : _INSTALL_L23;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L57
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L56);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Call to method getDirList from undeclared class \icms_core_Filesystem
      Open

              $list = icms_core_Filesystem::getDirList($dirname);
      Severity: Critical
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L67
      Open

              $ret .= $this->editform_sub(_INSTALL_L27, _INSTALL_L67, 'dbhost', $this->sanitizer->htmlSpecialChars($this->dbhost));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L28
      Open

              $ret .= $this->editform_sub(_INSTALL_L28, _INSTALL_L65, 'dbuname', $this->sanitizer->htmlSpecialChars($this->dbuname));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L28
      Open

                              <td class='bg3'><b>"._INSTALL_L28."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L52
      Open

                              <td class='bg3'><b>"._INSTALL_L52."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L29
      Open

              $ret .= $this->editform_sub(_INSTALL_L29, _INSTALL_L64, 'dbname', $this->sanitizer->htmlSpecialChars($this->dbname));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L30
      Open

                              <td class='bg3'><b>"._INSTALL_L30."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L68
      Open

              $ret .= $this->editform_sub(_INSTALL_L52, _INSTALL_L68, 'dbpass', $this->sanitizer->htmlSpecialChars($this->dbpass));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L24
      Open

                              <input type='radio' name='db_pconnect' value='0'".($this->db_pconnect != 1 ? " checked='checked'" : "" )." />"._INSTALL_L24."
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L24
      Open

              $yesno = empty($this->db_pconnect) ? _INSTALL_L24 : _INSTALL_L23;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L29
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L29);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L56
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L56);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L56
      Open

              $ret .= $this->editform_sub(_INSTALL_L56, _INSTALL_L58, 'xoops_url', $this->sanitizer->htmlSpecialChars($this->xoops_url));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L51
      Open

                              <b>"._INSTALL_L51."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L65
      Open

              $ret .= $this->editform_sub(_INSTALL_L28, _INSTALL_L65, 'dbuname', $this->sanitizer->htmlSpecialChars($this->dbuname));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L30
      Open

              $ret .= $this->editform_sub(_INSTALL_L30, _INSTALL_L63, 'prefix', $this->sanitizer->htmlSpecialChars($this->prefix));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L27
      Open

                              <td class='bg3'><b>"._INSTALL_L27."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L57
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L27);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Call to method getInstance from undeclared class \icms_core_Textsanitizer
      Open

              $this->sanitizer =& icms_core_Textsanitizer::getInstance();
      Severity: Critical
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L27
      Open

              $ret .= $this->editform_sub(_INSTALL_L27, _INSTALL_L67, 'dbhost', $this->sanitizer->htmlSpecialChars($this->dbhost));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L63
      Open

              $ret .= $this->editform_sub(_INSTALL_L30, _INSTALL_L63, 'prefix', $this->sanitizer->htmlSpecialChars($this->prefix));
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L51
      Open

                              <td class='bg3'><b>"._INSTALL_L51."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L54
      Open

                              <td class='bg3'><b>"._INSTALL_L54."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Call to method createSalt from undeclared class \icms_core_Password
      Open

              return icms_core_Password::createSalt(5);;
      Severity: Critical
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L27
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L27);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L57
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L30);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L23
      Open

                              <input type='radio' name='db_pconnect' value='1'".($this->db_pconnect == 1 ? " checked='checked'" : "" )." />"._INSTALL_L23."
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L56
      Open

                              <td class='bg3'><b>"._INSTALL_L56."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L57
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L29);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L30
      Open

                  $error[] = sprintf(_INSTALL_L57, _INSTALL_L30);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Reference to undeclared constant \_INSTALL_L54
      Open

                              <b>"._INSTALL_L54."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phan

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class setting_manager {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The property $db_pconnect is not named in camelCase.
      Open

      class setting_manager {

    var $database;
    var $dbhost;
    var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      The property $xoops_url is not named in camelCase.
      Open

      class setting_manager {

    var $database;
    var $dbhost;
    var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      The property $root_path is not named in camelCase.
      Open

      class setting_manager {

    var $database;
    var $dbhost;
    var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      The class setting_manager is not named in CamelCase.
      Open

      class setting_manager {

    var $database;
    var $dbhost;
    var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      Visibility must be declared on method "readConstant"
      Open

          function readConstant() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$dbuname"
      Open

          var $dbuname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $root_path;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $xoops_url;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Each PHP statement must be on a line by itself
      Open

              return icms_core_Password::createSalt(5);;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "checkData"
      Open

          function checkData() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "getDBList"
      Open

          function getDBList()
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$database"
      Open

          var $database;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$prefix"
      Open

          var $prefix;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "__construct"
      Open

          function __construct($post=false) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Incorrect spacing between argument "$post" and equals sign; expected 1 but found 0
      Open

          function __construct($post=false) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "readPost"
      Open

          function readPost() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Tabs must be used to indent lines; spaces are not allowed
      Open

                  "<table width='100%' class='outer' cellspacing='5'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Opening brace should be on the same line as the declaration
      Open

          {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $dbhost;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Space found after opening bracket of FOREACH loop
      Open

                  foreach ( $error as $err) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$xoops_url"
      Open

          var $xoops_url;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$sanitizer"
      Open

          var $sanitizer;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$dbhost"
      Open

          var $dbhost;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $db_pconnect;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Incorrect spacing between default value and equals sign for argument "$post"; expected 1 but found 0
      Open

          function __construct($post=false) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$dbpass"
      Open

          var $dbpass;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Method name "setting_manager::editform_sub" is not in camel caps format
      Open

          function editform_sub($title, $desc, $name, $value) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Tabs must be used to indent lines; spaces are not allowed
      Open

                  "<table border='0' cellpadding='0' cellspacing='0' valign='top' width='90%'><tr><td class='bg2'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $dbname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$db_pconnect"
      Open

          var $db_pconnect;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$root_path"
      Open

          var $root_path;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "editform_sub"
      Open

          function editform_sub($title, $desc, $name, $value) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $dbpass;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $prefix;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "editform"
      Open

          function editform() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "generatePrefix"
      Open

          function generatePrefix() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $database;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on property "$dbname"
      Open

          var $dbname;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The var keyword must not be used to declare a property
      Open

          var $sanitizer;
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Visibility must be declared on method "confirmForm"
      Open

          function confirmForm() {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['dbhost']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['dbuname']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_PREFIX'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_URL'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_PASS'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_PCONNECT'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

                  if ($val == $this->database) $ret .= " selected='selected'";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_ROOT_PATH'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['xoops_url']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_NAME'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['root_path']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_TYPE'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['db_pconnect']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['dbpass']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_USER'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['prefix']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (defined('XOOPS_DB_HOST'))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['database']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Inline control structures are not allowed
      Open

              if (isset($_POST['dbname']))
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      No space found after comma in function call
      Open

                  $this->root_path = str_replace("\\","/",getcwd()); // "
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Class name "setting_manager" is not in camel caps format
      Open

      class setting_manager {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      No space found after comma in function call
      Open

                      $filepath = substr($filepath,1);
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      No space found after comma in function call
      Open

                  $this->root_path = str_replace("\\","/",getcwd()); // "
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      Expected 0 spaces after opening bracket; 1 found
      Open

                  foreach ( $error as $err) {
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpcodesniffer

      The method editform_sub is not named in camelCase.
      Open

          function editform_sub($title, $desc, $name, $value) {
        $inputType = 'text';
        return  "<tr valign='top' align='left'>
                    <td class='head'>
                        <b>".$title."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      Unexpected spaces found.
      Open

                          <td class='even'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->dbuname)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->prefix)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='dbuname' value='".$this->sanitizer->htmlSpecialChars($this->dbuname)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <b>"._INSTALL_L51."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->database)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <select  size='1' name='database' id='database'>";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      ";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <b>".$title."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->dbhost)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->dbpass)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  "<table border='0' cellpadding='0' cellspacing='0' valign='top' width='90%'><tr><td class='bg2'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L55."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L29."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <span style='font-size:85%;'>"._INSTALL_L66."</span>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <input type='radio' name='db_pconnect' value='1'".($this->db_pconnect == 1 ? " checked='checked'" : "" )." />"._INSTALL_L23."
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      ";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <td class='head'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L30."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='dbhost' value='".$this->sanitizer->htmlSpecialChars($this->dbhost)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      ";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->dbname)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='root_path' value='".$this->sanitizer->htmlSpecialChars($this->root_path)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='xoops_url' value='".$this->sanitizer->htmlSpecialChars($this->xoops_url)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <input type='radio' name='db_pconnect' value='0'".($this->db_pconnect != 1 ? " checked='checked'" : "" )." />"._INSTALL_L24."
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L51."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L27."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='dbpass' value='".$this->sanitizer->htmlSpecialChars($this->dbpass)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  "<table width='100%' class='outer' cellspacing='5'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <span style='font-size:85%;'>".$desc."</span>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L28."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L54."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->xoops_url)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='db_pconnect' value='". (int) ($this->db_pconnect)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      <tr valign='top' align='left'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <td class='head'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L52."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      </table></td></tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      <table width='100%' border='0' cellpadding='4' cellspacing='1'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$this->sanitizer->htmlSpecialChars($this->root_path)."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <td class='head'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <b>"._INSTALL_L54."</b><br />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <td class='even'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg1'>".$yesno."</td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <td class='bg3'><b>"._INSTALL_L56."</b></td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <th colspan='2'></th>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <input type='$inputType' name='".$name."' id='".$name."' size='30' maxlength='100' value='".htmlspecialchars($value)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          </td>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                          <td class='even'>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='database' value='".$this->sanitizer->htmlSpecialChars($this->database)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='dbname' value='".$this->sanitizer->htmlSpecialChars($this->dbname)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                              <span style='font-size:85%;'>"._INSTALL_L69."</span>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                      </tr>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  </table>
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  <input type='hidden' name='prefix' value='".$this->sanitizer->htmlSpecialChars($this->prefix)."' />
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      Unexpected spaces found.
      Open

                  ";
      Severity: Minor
      Found in htdocs/install/class/settingmanager.php by editorconfig

      There are no issues that match your filters.

      Category
      Status