ImpressCMS/impresscms

Method buildFormats has 72 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function buildFormats() {
        $this->adFormats['728x90_as'] = array(
            'caption' => '728 X 90 Leaderboard',
            'width' => 728,
            'height' => 90,

The method render uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $ret = '<div>';
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'icms_core_DataFilter' in method 'generateTag'.

Open

        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid unused local variables such as '$title'.

Open

            $obj->setVar('tag', $title  = $obj->generateTag());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('color_link', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_LINK, _CO_ICMS_ADSENSE_COLOR_LINK_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('color_text', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_TEXT, _CO_ICMS_ADSENSE_COLOR_TEXT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('color_border', 'color');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('color_link', 'color');

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but color_text() is declared to return string

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTAREA

Open

        $this->quickInitVar('description', XOBJ_DTYPE_TXTAREA, TRUE, _CO_ICMS_ADSENSE_DESCRIPTION, _CO_ICMS_ADSENSE_DESCRIPTION_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('format', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_FORMAT, _CO_ICMS_ADSENSE_FORMAT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('color_background', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BACKGROUND, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('color_text', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_TEXT, _CO_ICMS_ADSENSE_COLOR_TEXT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Assigning array|array{} to property but \SystemAdsenseHandler->_objects is false

Open

            $this->_objects = $ret;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('tag', XOBJ_DTYPE_TXTBOX, FALSE, _CO_ICMS_ADSENSE_TAG, _CO_ICMS_ADSENSE_TAG_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTAREA

Open

        $this->quickInitVar('style', XOBJ_DTYPE_TXTAREA, FALSE, _CO_ICMS_ADSENSE_STYLE, _CO_ICMS_ADSENSE_STYLE_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('format', array('method' => 'getFormats'));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('color_url', 'color');

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared class \icms_ipf_Handler

Open

        parent::__construct($db, 'adsense', 'adsenseid', 'tag', 'description', 'system');

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \SystemAdsense->handler

Open

            . 'google_ad_width = ' . $this->handler->adFormats[$this->getVar('format', 'n')]['width'] . ';'

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('adsenseid', XOBJ_DTYPE_INT, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('color_border', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BORDER, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but color_url() is declared to return string

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('client_id', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_CLIENT_ID, _CO_ICMS_ADSENSE_CLIENT_ID_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared class \icms_ipf_Object

Open

        parent::__construct($handler);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('client_id', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_CLIENT_ID, _CO_ICMS_ADSENSE_CLIENT_ID_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('color_link', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_LINK, _CO_ICMS_ADSENSE_COLOR_LINK_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but color_background() is declared to return string

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('slot', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_SLOT, _CO_ICMS_ADSENSE_SLOT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('tag', XOBJ_DTYPE_TXTBOX, FALSE, _CO_ICMS_ADSENSE_TAG, _CO_ICMS_ADSENSE_TAG_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but color_border() is declared to return string

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('description', XOBJ_DTYPE_TXTAREA, TRUE, _CO_ICMS_ADSENSE_DESCRIPTION, _CO_ICMS_ADSENSE_DESCRIPTION_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('slot', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_SLOT, _CO_ICMS_ADSENSE_SLOT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('color_background', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BACKGROUND, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('color_text', 'color');

• Exclude checks
  • Disable engine
  • Disable check

Call to method icms_substr from undeclared class \icms_core_DataFilter

Open

        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but getAdsensesByTag() is declared to return array

Open

        return $this->_objects;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('format', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_FORMAT, _CO_ICMS_ADSENSE_FORMAT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('style', XOBJ_DTYPE_TXTAREA, FALSE, _CO_ICMS_ADSENSE_STYLE, _CO_ICMS_ADSENSE_STYLE_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::id

Open

            . $this->id() . '"><img src="' . ICMS_IMAGES_SET_URL . '/actions/editcopy.png" style="vertical-align: middle;" alt="'

• Exclude checks
  • Disable engine
  • Disable check

Class extends undeclared class \icms_ipf_Object

Open

class SystemAdsense extends icms_ipf_Object {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_INT

Open

        $this->quickInitVar('adsenseid', XOBJ_DTYPE_INT, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsenseHandler::getObjects

Open

            $adsensesObj = $this->getObjects(NULL, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('color_border', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BORDER, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \XOBJ_DTYPE_TXTBOX

Open

        $this->quickInitVar('color_url', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_URL, _CO_ICMS_ADSENSE_COLOR_URL_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared class \icms_ipf_Object

Open

        return parent::getVar($key, $format);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \SystemAdsense->handler

Open

            . 'google_ad_height = ' . $this->handler->adFormats[$this->getVar('format', 'n')]['height'] . ';'

• Exclude checks
  • Disable engine
  • Disable check

Class extends undeclared class \icms_ipf_Handler

Open

class SystemAdsenseHandler extends icms_ipf_Handler {

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::quickInitVar

Open

        $this->quickInitVar('color_url', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_URL, _CO_ICMS_ADSENSE_COLOR_URL_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \SystemAdsense::setControl

Open

        $this->setControl('color_background', 'color');

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but color_link() is declared to return string

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        $rep_pat = array ("-", "-", "-", "-", "-", "-100", "-", "-", "-", "-", "-", "-", "-", "-", "-", "-", "-", "-", "-at-", "-", "-", "-", "-", "-", "-", "-", "-", "-" );

• Read up
  Read up

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class SystemAdsense extends icms_ipf_Object {

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class SystemAdsenseHandler extends icms_ipf_Handler {

• Exclude checks
  • Disable engine
  • Disable check

The property $_adFormatsList is not named in camelCase.

Open

class SystemAdsenseHandler extends icms_ipf_Handler {
    public $adFormats = array();
    private $_adFormatsList = array();
    private $_objects = FALSE;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

Avoid variables with short names like $db. Configured minimum length is 3.

Open

    public function __construct(&$db) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The property $_objects is not named in camelCase.

Open

class SystemAdsenseHandler extends icms_ipf_Handler {
    public $adFormats = array();
    private $_adFormatsList = array();
    private $_objects = FALSE;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

Each class must be in a file by itself

Open

class SystemAdsenseHandler extends icms_ipf_Handler {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

    private $_objects = FALSE;

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('color_link', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_LINK, _CO_ICMS_ADSENSE_COLOR_LINK_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('color_text', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_TEXT, _CO_ICMS_ADSENSE_COLOR_TEXT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        return TRUE;

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

    public $content = FALSE;

• Exclude checks
  • Disable engine
  • Disable check

Method name "SystemAdsense::color_url" is not in camel caps format

Open

    public function color_url() {

• Exclude checks
  • Disable engine
  • Disable check

Method name "SystemAdsense::color_text" is not in camel caps format

Open

    public function color_text() {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('slot', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_SLOT, _CO_ICMS_ADSENSE_SLOT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('color_border', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BORDER, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Method name "SystemAdsense::color_background" is not in camel caps format

Open

    public function color_background() {

• Exclude checks
  • Disable engine
  • Disable check

Method name "SystemAdsense::color_link" is not in camel caps format

Open

    public function color_link() {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('adsenseid', XOBJ_DTYPE_INT, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('format', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_FORMAT, _CO_ICMS_ADSENSE_FORMAT_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

        $this->quickInitVar('style', XOBJ_DTYPE_TXTAREA, FALSE, _CO_ICMS_ADSENSE_STYLE, _CO_ICMS_ADSENSE_STYLE_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('color_background', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_BACKGROUND, _CO_ICMS_ADSENSE_COLOR_BORDER_DSC);

• Exclude checks
  • Disable engine
  • Disable check

The closing brace for the class must go on the next line after the body

Open

}

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('description', XOBJ_DTYPE_TXTAREA, TRUE, _CO_ICMS_ADSENSE_DESCRIPTION, _CO_ICMS_ADSENSE_DESCRIPTION_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('color_url', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_COLOR_URL, _CO_ICMS_ADSENSE_COLOR_URL_DSC);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

        $this->quickInitVar('tag', XOBJ_DTYPE_TXTBOX, FALSE, _CO_ICMS_ADSENSE_TAG, _CO_ICMS_ADSENSE_TAG_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Method name "SystemAdsense::color_border" is not in camel caps format

Open

    public function color_border() {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"

Open

            $adsensesObj = $this->getObjects(NULL, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

            $adsensesObj = $this->getObjects(NULL, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

        $this->quickInitVar('client_id', XOBJ_DTYPE_TXTBOX, TRUE, _CO_ICMS_ADSENSE_CLIENT_ID, _CO_ICMS_ADSENSE_CLIENT_ID_DSC);

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

        if ($value == "") return;

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            . 'google_color_bg = ' . json_encode($this->getVar('color_background', 'n') ). ';'

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            . 'google_color_border = ' . json_encode($this->getVar('color_border', 'n') ). ';'

• Exclude checks
  • Disable engine
  • Disable check

The variable $rep_pat is not named in camelCase.

Open

    public function generateTag() {
        $title = rawurlencode(strtolower($this->getVar('description', 'e')));
        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

        $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $rep_pat is not named in camelCase.

Open

    public function generateTag() {
        $title = rawurlencode(strtolower($this->getVar('description', 'e')));
        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

        $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $rep_pat is not named in camelCase.

Open

    public function generateTag() {
        $title = rawurlencode(strtolower($this->getVar('description', 'e')));
        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

        $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $rep_pat is not named in camelCase.

Open

    public function generateTag() {
        $title = rawurlencode(strtolower($this->getVar('description', 'e')));
        $title = icms_core_DataFilter::icms_substr($title, 0, 10, '');

        $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The method color_text is not named in camelCase.

Open

    public function color_text() {
        $value = $this->getVar("color_text", "n");
        if ($value == "") return;
        return "#" . $value;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method color_background is not named in camelCase.

Open

    public function color_background() {
        $value = $this->getVar("color_background", "n");
        if ($value == "") return;
        return "#" . $value;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method color_link is not named in camelCase.

Open

    public function color_link() {
        $value = $this->getVar("color_link", "n");
        if ($value == "") return;
        return "#" . $value;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method color_url is not named in camelCase.

Open

    public function color_url() {
        $value = $this->getVar("color_url", "n");
        if ($value == "") return;
        return "#" . $value;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method color_border is not named in camelCase.

Open

    public function color_border() {
        $value = $this->getVar("color_border", "n");
        if ($value == "") return;
        return "#" . $value;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}