ImpressCMS/impresscms

The method editblockposition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

    } else {
        $sform = $blockObj->getForm(_AM_SYSTEM_BLOCKSPADMIN_CREATE, 'addblockposition');
        $sform->assign($icmsAdminTpl);

    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Reference to undeclared constant \_NOPERM

Open

    exit(_NOPERM);

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('pname'), 'center');

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->assign('icms_blockposition_table', $objectTable->fetch());

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->assign('lang_badmin', _AM_SYSTEM_BLOCKSPADMIN_TITLE);

• Exclude checks
  • Disable engine
  • Disable check

Reference to static property user from undeclared class \icms

Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_Controller

Open

            $controller = new icms_ipf_Controller($icms_blockposition_handler);

• Exclude checks
  • Disable engine
  • Disable check

Call to method storeFromDefaultForm from undeclared class \icms_ipf_Controller

Open

            $controller->storeFromDefaultForm(_AM_SYSTEM_BLOCKSPADMIN_CREATED, _AM_SYSTEM_BLOCKSPADMIN_MODIFIED);

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('description'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addQuickSearch from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addQuickSearch(array('pname', 'title', 'description'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method fetch from undeclared class \icms_ipf_view_Table

Open

            $icmsAdminTpl->assign('icms_blockposition_table', $objectTable->fetch());

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

Call to method handleObjectDeletion from undeclared class \icms_ipf_Controller

Open

            $controller->handleObjectDeletion();

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('pname'), 'center');

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->assign('icms_blockposition_info', _AM_SYSTEM_BLOCKSPADMIN_INFO);

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addIntroButton from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addIntroButton('addblockposition', 'admin.php?fct=blockspadmin&op=mod', _AM_SYSTEM_BLOCKSPADMIN_CREATE);

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_Controller

Open

            $controller = new icms_ipf_Controller($icms_blockposition_handler);

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('description'));

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsModule is undeclared

Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Table

Open

            $objectTable = new icms_ipf_view_Table($icms_blockposition_handler, FALSE);

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->display('db:system_adm_blockspadmin.html');

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $icms_blockposition_handler. Keep variable name length under 20.

Open

    global $icms_blockposition_handler, $icmsAdminTpl;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

function editblockposition($id = 0) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

if (in_array($clean_op, $valid_op, TRUE)) {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable = new icms_ipf_view_Table($icms_blockposition_handler, FALSE);

• Exclude checks
  • Disable engine
  • Disable check

The CASE body must start on the line following the statement

Open

        case "changedField":

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at end of control structure

Open

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at end of control structure

Open

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

if (in_array($clean_op, $valid_op, TRUE)) {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('title', FALSE, FALSE, 'getCustomTitle', FALSE, FALSE, FALSE));

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

if (isset($_POST['op'])) $clean_op = htmlentities($_POST['op']);

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

if (isset($_GET['op'])) $clean_op = htmlentities($_GET['op']);

• Exclude checks
  • Disable engine
  • Disable check

The variable $icms_blockposition_handler is not named in camelCase.

Open

function editblockposition($id = 0) {
    global $icms_blockposition_handler, $icmsAdminTpl;

    $blockObj = $icms_blockposition_handler->get($id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $icms_blockposition_handler is not named in camelCase.

Open

function editblockposition($id = 0) {
    global $icms_blockposition_handler, $icmsAdminTpl;

    $blockObj = $icms_blockposition_handler->get($id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}