ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/admin/groups/groups.php

Summary

Maintainability
C
1 day
Test Coverage

modifyGroup accesses the super-global variable $_GET.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_POST.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_GET.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_POST.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_GET.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_POST.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_POST.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

modifyGroup accesses the super-global variable $_GET.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method modifyGroup has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {
Severity: Major
Found in htdocs/modules/system/admin/groups/groups.php - About 3 hrs to fix

    Function modifyGroup has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function modifyGroup($g_id) {
        $userstart = $memstart = 0;
        if (!empty($_POST['userstart'])) {
            $userstart = (int) $_POST['userstart'];
        } elseif (!empty($_GET['userstart'])) {
    Severity: Minor
    Found in htdocs/modules/system/admin/groups/groups.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method displayGroups has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function displayGroups() {
        icms_cp_header();
        echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
        $member_handler = icms::handler('icms_member');
        $groups = $member_handler->getGroups();
    Severity: Minor
    Found in htdocs/modules/system/admin/groups/groups.php - About 1 hr to fix

      Function displayGroups has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();
      Severity: Minor
      Found in htdocs/modules/system/admin/groups/groups.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The function modifyGroup() has an NPath complexity of 234. The configured NPath complexity threshold is 200.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The function modifyGroup() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '132', column '49').
      Open

          $usercount = $member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>'));

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '140', column '27').
      Open

                  $member_criteria = new icms_db_criteria_Item('uid', "(" . implode(',', $members) . ")", "IN");

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '144', column '19').
      Open

              $criteria = new icms_db_criteria_Item('level', 0, '>');

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '173', column '14').
      Open

              $nav = new icms_view_PageNav($membercount, 200, $memstart, "memstart", "fct=groups&amp;op=modify&amp;g_id=" . (int) $g_id);

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '167', column '27').
      Open

                  $member_criteria = new icms_db_criteria_Item('uid', "(" . implode(',', $members) . ")", "IN");

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class 'icms' in method 'displayGroups'.
      Open

          $gperm_handler = icms::handler('icms_member_groupperm');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method displayGroups uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      echo '&nbsp;<a href="admin.php?fct=groups&amp;op=del&amp;g_id=' . (int) $id . '">' . _AM_DELETE . '</a></td></tr>';
                  }

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class 'icms' in method 'modifyGroup'.
      Open

          $moduleperm_handler = icms::handler('icms_member_groupperm');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms' in method 'modifyGroup'.
      Open

          $gperm_handler = icms::handler('icms_member_groupperm');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms' in method 'modifyGroup'.
      Open

          $member_handler = icms::handler('icms_member');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method modifyGroup uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              $members = &$member_handler->getUsersByGroup($g_id, FALSE, 200, $memstart);
              $mlist = array();
              if (count($members) > 0) {
                  $member_criteria = new icms_db_criteria_Item('uid', "(" . implode(',', $members) . ")", "IN");

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class 'icms' in method 'modifyGroup'.
      Open

          $member_handler = icms::handler('icms_member');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms' in method 'displayGroups'.
      Open

          $member_handler = icms::handler('icms_member');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'icms' in method 'modifyGroup'.
      Open

          $sysperm_handler = icms::handler('icms_member_groupperm');

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused local variables such as '$r_mod_value'.
      Open

          $r_mod_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$s_cat_value'.
      Open

          $s_cat_value = '';

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$debug_mod_value'.
      Open

          $debug_mod_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$g_id_value'.
      Open

          $g_id_value = "";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$form_title'.
      Open

          $form_title = _AM_MODIFYADG;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$submit_value'.
      Open

          $submit_value = _AM_CREATENEWADG;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$type_value'.
      Open

          $type_value = "";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$desc_value'.
      Open

          $desc_value = $thisgroup->getVar("description", "E");

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$op_value'.
      Open

          $op_value = "update";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$form_title'.
      Open

          $form_title = _AM_CREATENEWADG;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$name_value'.
      Open

          $name_value = "";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$desc_value'.
      Open

          $desc_value = "";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$op_value'.
      Open

          $op_value = "add";

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$ed_mod_value'.
      Open

          $ed_mod_value = $moduleperm_handler->getItemIds('use_wysiwygeditor', $thisgroup->getVar('groupid'));

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$submit_value'.
      Open

          $submit_value = _AM_UPDATEADG;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$s_cat_value'.
      Open

          $s_cat_value = $sysperm_handler->getItemIds('system_admin', $g_id);

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$s_cat_disable'.
      Open

              $s_cat_disable = TRUE;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$group_manager_value'.
      Open

          $group_manager_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$r_block_value'.
      Open

          $r_block_value = $gperm_handler->getItemIds('block_read', $g_id);

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$ed_mod_value'.
      Open

          $ed_mod_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$r_block_value'.
      Open

          $r_block_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$a_mod_value'.
      Open

          $a_mod_value = $moduleperm_handler->getItemIds('module_admin', $thisgroup->getVar('groupid'));

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$group_manager_value'.
      Open

          $group_manager_value = $moduleperm_handler->getItemIds('group_manager', $thisgroup->getVar('groupid'));

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$g_id_value'.
      Open

          $g_id_value = $thisgroup->getVar("groupid");

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$type_value'.
      Open

          $type_value = $thisgroup->getVar("group_type", "E");

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$a_mod_value'.
      Open

          $a_mod_value = array();

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$r_mod_value'.
      Open

          $r_mod_value = $moduleperm_handler->getItemIds('module_read', $thisgroup->getVar('groupid'));

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$debug_mod_value'.
      Open

          $debug_mod_value = $moduleperm_handler->getItemIds('enable_debug', $thisgroup->getVar('groupid'));

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$userstart'.
      Open

          $userstart = $memstart = 0;

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$name_value'.
      Open

          $name_value = $thisgroup->getVar("name", "E");

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Reference to static property security from undeclared class \icms
      Open

              echo "</td><td align='center' class='odd'><input type='hidden' name='op' value='addUser' />" . icms::$security->getTokenHTML() . "<input type='hidden' name='fct' value='groups' /><input type='hidden' name='groupid' value='" . $thisgroup->getVar("groupid") . "' /><input type='submit' name='submit' value='" . _AM_ADDBUTTON . "' /></form><br /><form action='admin.php' method='post' />" . "<input type='hidden' name='op' value='delUser' />" . icms::$security->getTokenHTML() . "<input type='hidden' name='fct' value='groups' /><input type='hidden' name='groupid' value='" . $thisgroup->getVar("groupid") . "' /><input type='submit' name='submit' value='" . _AM_DELBUTTON . "' /></td><td class='even'>";

      Call to method handler from undeclared class \icms
      Open

          $moduleperm_handler = icms::handler('icms_member_groupperm');

      Reference to undeclared constant \_DELETE
      Open

              echo "</select><br /><input type='submit' name='submit' value='" . _DELETE . "' /></td></tr></table></form>";

      Call to method handler from undeclared class \icms
      Open

          $gperm_handler = icms::handler('icms_member_groupperm');

      Call to method setSort from undeclared class \icms_db_criteria_Item
      Open

                  $member_criteria->setSort('uname');

      Variable $icmsModule is undeclared
      Open

      if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {

      Call to method handler from undeclared class \icms
      Open

          $gperm_handler = icms::handler('icms_member_groupperm');

      Call to method handler from undeclared class \icms
      Open

          $member_handler = icms::handler('icms_member');

      Call to method __construct from undeclared class \icms_db_criteria_Item
      Open

                  $member_criteria = new icms_db_criteria_Item('uid', "(" . implode(',', $members) . ")", "IN");

      Call to method renderNav from undeclared class \icms_view_PageNav
      Open

              echo $nav->renderNav(4);

      Call to method __construct from undeclared class \icms_view_PageNav
      Open

              $nav = new icms_view_PageNav($membercount, 200, $memstart, "memstart", "fct=groups&amp;op=modify&amp;g_id=" . (int) $g_id);

      Call to method handler from undeclared class \icms
      Open

          $member_handler = icms::handler('icms_member');

      Reference to static property user from undeclared class \icms
      Open

          $ugroups = (is_object(icms::$user)) ? icms::$user->getGroups() : array(XOOPS_GROUP_ANONYMOUS);

      Call to method __construct from undeclared class \icms_db_criteria_Item
      Open

          $usercount = $member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>'));

      Call to method __construct from undeclared class \icms_db_criteria_Item
      Open

                  $member_criteria = new icms_db_criteria_Item('uid', "(" . implode(',', $members) . ")", "IN");

      Call to method handler from undeclared class \icms
      Open

          $member_handler = icms::handler('icms_member');

      Reference to static property user from undeclared class \icms
      Open

      if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {

      Call to method handler from undeclared class \icms
      Open

          $sysperm_handler = icms::handler('icms_member_groupperm');

      Call to method setSort from undeclared class \icms_db_criteria_Item
      Open

                  $member_criteria->setSort('uname');

      Call to method __construct from undeclared class \icms_db_criteria_Item
      Open

              $criteria = new icms_db_criteria_Item('level', 0, '>');

      Call to method setSort from undeclared class \icms_db_criteria_Item
      Open

              $criteria->setSort('uname');

      Reference to static property security from undeclared class \icms
      Open

              echo "</th></tr><tr><td class='even' align='center'>" . "<input type='hidden' name='op' value='delUser' />" . "<input type='hidden' name='fct' value='groups' />" . "<input type='hidden' name='groupid' value='" . $thisgroup->getVar("groupid") . "' /><input type='hidden' name='memstart' value='" . $memstart . "' />" . icms::$security->getTokenHTML() . "<select name='uids[]' size='10' multiple='multiple'>";

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

              $id = $groups[$i]->getVar('groupid');

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      The parameter $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
          public function doSomething($user_name) {
          }
      }

      Source

      Expected 0 spaces before closing bracket; 1 found
      Open

          for ($i = 0; $i < $count; $i++ ) {

      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
      Open

              $members = $member_handler->getUsersByGroup($g_id, FALSE);

      Expected 1 blank line at end of file; 2 found
      Open

      }

      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
      Open

              $s_cat_disable = TRUE;

      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
      Open

              $members = &$member_handler->getUsersByGroup($g_id, FALSE, 200, $memstart);

      Space found before closing bracket of FOR loop
      Open

          for ($i = 0; $i < $count; $i++ ) {

      The variable $member_handler is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $gperm_handler is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $r_mod_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $group_manager_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sysperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $debug_mod_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $gperm_handler is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $name_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $desc_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $sysperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $name_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $desc_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $s_cat_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $op_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $type_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $group_manager_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $r_block_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $type_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $s_cat_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $debug_mod_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $gperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $op_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $submit_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $ed_mod_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $form_title is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $u_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $r_block_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $submit_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $a_mod_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $moduleperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $form_title is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $s_cat_disable is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $u_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $ed_mod_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $r_mod_value is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $gperm_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $u_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $u_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $m_name is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $g_id is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $a_mod_value is not named in camelCase.
      Open

      function displayGroups() {
          icms_cp_header();
          echo '<div class="CPbigTitle" style="background-image: url(' . ICMS_MODULES_URL . '/system/admin/groups/images/groups_big.png)">' . _AM_EDITADG . '</div><br />';
          $member_handler = icms::handler('icms_member');
          $groups = $member_handler->getGroups();

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_handler is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $member_criteria is not named in camelCase.
      Open

      function modifyGroup($g_id) {
          $userstart = $memstart = 0;
          if (!empty($_POST['userstart'])) {
              $userstart = (int) $_POST['userstart'];
          } elseif (!empty($_GET['userstart'])) {

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status