imanager_addfile accesses the super-global variable $_POST. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
imanager_reordercateg accesses the super-global variable $_POST. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
imanager_reordercateg accesses the super-global variable $_POST. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
imanager_addfile accesses the super-global variable $_POST. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
File main.php
has 945 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
// $Id: main.php 12460 2014-06-25 03:35:37Z skenow $
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
// Copyright (c) 2000 XOOPS.org //
Method imanager_listimg
has 176 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
Method imanager_index
has 173 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
Function imanager_updateimage
has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_listimg
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_delcatok
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_index
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_addfile
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method imanager_addcat
has 70 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Function imanager_addcat
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function adminNav
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method imanager_addfile
has 62 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Method imanager_updateimage
has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Method imanager_updatecat
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
Method imanager_delcatok
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Method imanager_clone
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Function imanager_clone
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_updatecat
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function imanager_reordercateg
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method imanager_delfileok
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
Method imanager_editcat
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
Avoid deeply nested control flow statements. Open
if (!@unlink($src)) {
$error[] = sprintf(_MD_FAILUNLINK, $i);
}
Avoid deeply nested control flow statements. Open
if (!copy($src, $dest)) {
$error[] = sprintf(_FAILSAVEIMG, $image_id[$i]);
}
Function imanager_delfileok
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The function imanager_addcat() has an NPath complexity of 5120. The configured NPath complexity threshold is 200. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_addfile() has an NPath complexity of 352. The configured NPath complexity threshold is 200. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_index() has an NPath complexity of 83232. The configured NPath complexity threshold is 200. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_listimg() has an NPath complexity of 423936. The configured NPath complexity threshold is 200. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_updatecat() has an NPath complexity of 1536. The configured NPath complexity threshold is 200. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_index() has 187 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Exclude checks
The function imanager_listimg() has 203 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Exclude checks
The function imanager_delcatok() has an NPath complexity of 2048. The configured NPath complexity threshold is 200. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_updateimage() has an NPath complexity of 780. The configured NPath complexity threshold is 200. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function imanager_delcatok() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_updateimage() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_updatecat() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_index() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_addcat() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_listimg() has a Cyclomatic Complexity of 25. The configured cyclomatic complexity threshold is 10. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function imanager_addfile() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '253', column '45'). Open
$count[$i] = $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $imagecategorys[$i]->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '282', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$k]->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '312', column '15'). Open
$tray = new icms_form_elements_Tray('', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '443', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '444', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 607. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '262', column '27'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '328', column '24'). Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '329', column '24'). Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '330', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, 50000));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '419', column '22'). Open
$criteriaRead = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '447', column '25'). Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '477', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('imgcat_id', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '477', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('imgcat_id', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '206', column '27'). Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '310', column '25'). Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '327', column '24'). Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255), TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '333', column '24'). Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, 0));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '721', column '22'). Open
$criteria2->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 897. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '193', column '27'). Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '309', column '25'). Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '313', column '25'). Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '346', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('op', 'addcat'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '440', column '27'). Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '680', column '24'). Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', $imagecategory->getVar('imgcat_display'), _YES, _NO));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '426', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '427', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '784', column '44'). Open
$images = &$image_handler->getObjects(new icms_db_criteria_Item('imgcat_id', $imgcat_id), TRUE, FALSE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 1022. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '676', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, $imagecategory->getVar('imgcat_maxsize')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '196', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '189', column '22'). Open
$criteriaRead = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '311', column '25'). Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '286', column '40'). Open
$sc += $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $va->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '322', column '13'). Open
$sup = new icms_form_elements_Select(_MD_IMGCATPARENT, 'imgcat_pid', $imgcat_id);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '314', column '14'). Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '429', column '25'). Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '436', column '22'). Open
$criteriaRead = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '479', column '22'). Open
$criteria->add(new icms_db_criteria_Item('image_nicename', '%' . icms::$xoopsDB->quote($query) . '%', 'LIKE'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 608. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '674', column '24'). Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_read', $imgcat_id), 5, TRUE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '682', column '24'). Open
$form->addElement(new icms_form_elements_Label(_MD_IMGCATSTRTYPE, $storetype[$imagecategory->getVar('imgcat_storetype')]));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '672', column '14'). Open
$form = new icms_form_Theme(_MD_EDITIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '208', column '26'). Open
$criteriaWrite->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '258', column '28'). Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '320', column '14'). Open
$form = new icms_form_Theme(_MD_ADDIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '332', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, 120));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '340', column '15'). Open
$fname = new icms_form_elements_Text(_MD_IMGCATFOLDERNAME, 'imgcat_foldername', 50, 255, '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '349', column '25'). Open
$tray1->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '421', column '23'). Open
$criteriaTray = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '720', column '46'). Open
$criteria2 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '348', column '15'). Open
$tray1 = new icms_form_elements_Tray('', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '254', column '23'). Open
$criteriaRead = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '275', column '28'). Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '256', column '24'). Open
$criteriaTray = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '261', column '27'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '331', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, 120));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '278', column '27'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '675', column '24'). Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_write', $imgcat_id), 5, TRUE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '684', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('op', 'updatecat'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '335', column '19'). Open
$storetype = new icms_form_elements_Radio(_MD_IMGCATSTRTYPE, 'imgcat_storetype', 'file');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '438', column '23'). Open
$criteriaTray = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '347', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '718', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_itemid', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 901. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '683', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '877', column '18'). Open
$uploader = new icms_file_MediaUploadHandler($updir, array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/bmp'), $imagecategory->getVar('imgcat_maxsize'), $imagecategory->getVar('imgcat_maxwidth'), $imagecategory->getVar('imgcat_maxheight'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '718', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_itemid', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '719', column '21'). Open
$criteria->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '265', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$i]->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 800. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '273', column '24'). Open
$criteriaTray = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '302', column '17'). Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', $imgcat_id);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '556', column '15'). Open
$nav = new icms_view_PageNav($imgcount, 15, $start, 'start', 'fct=images&op=listimg&imgcat_id=' . $imgcat_id);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '673', column '24'). Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255, $imagecategory->getVar('imgcat_name')), TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '678', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, $imagecategory->getVar('imgcat_maxheight')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '197', column '26'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '298', column '15'). Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '300', column '25'). Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '308', column '25'). Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 510. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '451', column '39'). Open
$sc += $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $va->getVar('imgcat_id')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '685', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '686', column '24'). Open
$form->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 813. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Remove error control operator '@' on line 899. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '191', column '23'). Open
$criteriaTray = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '205', column '27'). Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '279', column '27'). Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '307', column '25'). Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '423', column '27'). Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '679', column '24'). Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, $imagecategory->getVar('imgcat_weight')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '200', column '25'). Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '271', column '23'). Open
$criteriaRead = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '334', column '24'). Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', 1, _YES, _NO));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '202', column '23'). Open
$criteriaWrite = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '350', column '13'). Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '720', column '19'). Open
$criteria2 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method adminNav has a boolean flag argument $list, which is a certain sign of a Single Responsibility Principle violation. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Missing class import via use statement (line '677', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, $imagecategory->getVar('imgcat_maxwidth')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 898. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Remove error control operator '@' on line 973. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '1040', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1044', column '24'). Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1046', column '24'). Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 1095. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '1052', column '13'). Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 1096. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '1047', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1050', column '14'). Open
$tray = new icms_form_elements_Tray('', '');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1048', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 1097. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '1041', column '16'). Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', (int) $imgcat_id);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1045', column '24'). Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Remove error control operator '@' on line 1099. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Remove error control operator '@' on line 1101. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}
Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Missing class import via use statement (line '1038', column '14'). Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1051', column '24'). Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1049', column '24'). Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'icms' in method 'imanager_editcat'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$groups = &icms::$user->getGroups();
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_index'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\WideImage\WideImage' in method 'imanager_listimg'. Open
$img_info = WideImage::load(ICMS_IMANAGER_FOLDER_PATH . '/' . $images[$i]->getVar('image_name'));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$arrimg[$i]['hasextra_link'] = 0;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_Filesystem' in method 'imanager_addcat'. Open
if (!icms_core_Filesystem::mkdir($categ_path)) {
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$url = (substr($categ_url, -1) != '/') ? $categ_url . '/' : $categ_url;
$path = (substr($categ_path, -1) != '/') ? $categ_path . '/' : $categ_path;
$src = $url . $images[$i]->getVar('image_name');
$arrimg[$i]['size'] = icms_convert_size(filesize($path . $images[$i]->getVar('image_name')));
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_listimg'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '607', column '9'). Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class 'icms' in method 'imanager_editcat'. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_reordercateg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msg = _MD_AM_DBUPDATED;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_Message' in method 'imanager_index'. Open
icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, str_ireplace(ICMS_ROOT_PATH, "", ICMS_IMANAGER_FOLDER_PATH)));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$icmsAdminTpl->assign('pag', '');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$icmsAdminTpl->assign('pag', '');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_addcat'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_updatecat'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_addfile'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_delcatok uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (file_exists($categ_path . $images[$i]->getVar('image_name'))) {
if (!@unlink($categ_path . $images[$i]->getVar('image_name'))) {
$errors[] = sprintf(_MD_FAILUNLINK, $i);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_addfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$updir = $categ_path;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_Message' in method 'imanager_updateimage'. Open
icms_core_Message::error($error);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_index uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$groups = &icms::$user->getGroups();
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_DataFilter' in method 'imanager_listimg'. Open
$arrimg[$i]['display_nicename'] = icms_core_DataFilter::icms_substr($images[$i]->getVar('image_nicename'), 0, 20);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_updatecat'. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_listimg uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$arrimg[$i]['editor_link'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_delcatok uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
foreach (array_keys($images) as $i) {
if (!$image_handler->delete($images[$i])) {
$errors[] = sprintf(_MD_FAILDEL, $i);
} else {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_addcat'. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_listimg'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_delcatok'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_reordercateg'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_index'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_addcat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($fh = @fopen($categ_path . '/index.html', 'w')) fwrite($fh, '<script>history.go(-1);</script>');
@fclose($fh);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_addfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$image_handler = icms::handler('icms_image');
$image = &$image_handler->create();
$image->setVar('image_name', $uploader->getSavedFileName());
$image->setVar('image_nicename', $image_nicename);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_addfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$redir = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_updateimage'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\WideImage\WideImage' in method 'imanager_listimg'. Open
$img_info = WideImage::load($path . $images[$i]->getVar('image_name'));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_addfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$err[] = sprintf(_FAILFETCHIMG, $i);
$err = array_merge($err, $uploader->getErrors(FALSE));
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_delcatok'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_delcatok uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($imagecategory->getVar('imgcat_storetype') != 'db') {
if (!@rmdir($categ_path)) {
$errors[] = sprintf(_MD_FAILDELCAT, $i);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_Message' in method 'imanager_addfile'. Open
icms_core_Message::error($err);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_updateimage'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'showAddImgForm'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_clone uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$redir = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method adminNav uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$ret = "<a href='" . $admin_url . "&imgcat_id=" . $imagecategory->getVar('imgcat_id') . "'>" . $imagecategory->getVar('imgcat_name') . "</a>";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_Message' in method 'imanager_delcatok'. Open
icms_core_Message::error($errors);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_addfile'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_clone'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_core_Message' in method 'imanager_delfileok'. Open
icms_core_Message::error(sprintf(_MD_FAILDEL, $image->getVar('image_id')));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'adminNav'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_updateimage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$changedCat = FALSE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_clone'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'imanager_delfileok'. Open
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method adminNav uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return FALSE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_delfileok uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$redir = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid assigning values to variables in if clauses and the like (line '1079', column '7'). Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method adminNav uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($id > 0) {
$id = (int) $id;
$imgcat_handler = icms::handler('icms_image_category');
$imagecategory = &$imgcat_handler->get($id);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'imanager_delfileok'. Open
$image_handler = icms::handler('icms_image');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method imanager_clone uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msg = _MD_AM_DBUPDATED;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_updateimage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$redir = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method imanager_clone uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (!@copy($categ_path . '/' . $image->getVar('image_name'), $categ_path . '/' . $imgname)) {
$msg = sprintf(_FAILSAVEIMG, $image->getVar('image_nicename'));
}
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$admin'. Open
$admin = FALSE;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$limit'. Open
global $icmsAdminTpl, $icmsConfig, $limit;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$img'. Open
$img = WideImage::load($images[$i]->getVar('image_body'))->saveToFile(ICMS_IMANAGER_FOLDER_PATH . '/' . $images[$i]->getVar('image_name'));
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsAdminTpl, $icmsConfig, $limit;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The function imanager_addfile() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
The function imanager_delcatok() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused local variables such as '$v'. Open
foreach ($subs as $k => $v) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The function imanager_updatecat() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused local variables such as '$src'. Open
$src = ICMS_MODULES_URL . "/system/admin/images/preview.php?file=" . $image->getVar('image_name') . '&resize=0';
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The function imanager_updateimage() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
The function imanager_delfileok() contains an exit expression. Open
exit();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
Avoid unused parameters such as '$style'. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$img'. Open
$img = WideImage::load($image->getVar('image_body'))->saveToFile(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'));
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Variable $icmsModule
is undeclared Open
if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
- Exclude checks
Reference to undeclared constant \_WARNINNOTWRITEABLE
Open
icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, str_ireplace(ICMS_ROOT_PATH, "", ICMS_IMANAGER_FOLDER_PATH)));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaWrite->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaWrite->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_Theme
Open
$form->setExtra('enctype="multipart/form-data"');
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, 120));
- Exclude checks
Call to method addOptionArray
from undeclared class \icms_form_elements_Radio
Open
$storetype->addOptionArray(array('file' => sprintf(_MD_ASFILE, str_ireplace(ICMS_ROOT_PATH, '', ICMS_IMANAGER_FOLDER_PATH) . '/foldername'), 'db' => _MD_INDB));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($sup);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray1->addElement($btn);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, 120));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$fname = new icms_form_elements_Text(_MD_IMGCATFOLDERNAME, 'imgcat_foldername', 50, 255, '');
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$groups = &icms::$user->getGroups();
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$icmsAdminTpl->assign('lang_imanager_cat_submit', _SUBMIT);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method checkVarArray
from undeclared class \icms_core_DataFilter
Open
$clean_POST = icms_core_DataFilter::checkVarArray($_POST, $filter_post, FALSE);
- Exclude checks
Call to method addOptionArray
from undeclared class \icms_form_elements_Select
Open
$select->addOptionArray($list);
- Exclude checks
Function imanager_index
defined at /code/htdocs/modules/system/admin/images/main.php:171
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:146
Open
function imanager_index($imgcat_id = NULL) {
- Exclude checks
Reference to undeclared constant \_NO
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Reference to instance property customValidationCode
from undeclared class \icms_form_elements_Text
Open
$fname->customValidationCode[] = $js;
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead = new icms_db_criteria_Compo();
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$i]->getVar('imgcat_id')));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add($criteriaTray);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to undeclared constant \_CLONE
Open
$icmsAdminTpl->assign('lang_imanager_cat_clone', _CLONE);
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!is_object(icms::$user)) {
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaWrite->add($criteriaTray);
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($select, TRUE);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray->addElement($btn);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, 120));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method warning
from undeclared class \icms_core_Message
Open
icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, str_ireplace(ICMS_ROOT_PATH, "", ICMS_IMANAGER_FOLDER_PATH)));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method setDescription
from undeclared class \icms_form_elements_Radio
Open
$storetype->setDescription('<span style="color:#ff0000;">' . _MD_STRTYOPENG . '</span>');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($storetype);
- Exclude checks
Reference to undeclared constant \_FORM_ENTER
Open
$js .= 'if (fname.disabled == false && fname.value == "") {alert("' . sprintf(_FORM_ENTER, _MD_IMGCATFOLDERNAME) . '"); return false;}';
- Exclude checks
Call to method render
from undeclared class \icms_form_Theme
Open
$icmsAdminTpl->assign('addcatform', $form->render());
- Exclude checks
Reference to undeclared constant \_DELETE
Open
$icmsAdminTpl->assign('lang_imanager_cat_del', _DELETE);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add($criteriaTray);
- Exclude checks
Reference to undeclared constant \_LIST
Open
$icmsAdminTpl->assign('lang_imanager_cat_listimg', _LIST);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Reference to undeclared constant \_IMGWEIGHT
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($tray1);
- Exclude checks
Function imanager_listimg
defined at /code/htdocs/modules/system/admin/images/main.php:365
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:338
Open
function imanager_listimg($imgcat_id, $start = 0) {
- Exclude checks
Reference to undeclared constant \_EDIT
Open
$icmsAdminTpl->assign('lang_imanager_cat_edit', _EDIT);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$count[$i] = $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $imagecategorys[$i]->getVar('imgcat_id')));
- Exclude checks
Reference to undeclared constant \_CANCEL
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, 50000));
- Exclude checks
Reference to undeclared constant \_IMGMAXHEIGHT
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, 120));
- Exclude checks
Call to method checkVarArray
from undeclared class \icms_core_DataFilter
Open
$clean_GET = icms_core_DataFilter::checkVarArray($_GET, $filter_get, FALSE);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($fname, TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Tray
Open
$tray1 = new icms_form_elements_Tray('', '');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray = new icms_db_criteria_Compo();
- Exclude checks
Reference to undeclared constant \_IMAGENAME
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Reference to undeclared constant \_IMGDISPLAY
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Exclude checks
Call to method addOptionArray
from undeclared class \icms_form_elements_Select
Open
$sup->addOptionArray($list);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255), TRUE);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255), TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, 120));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead = new icms_db_criteria_Compo();
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method confirm
from undeclared class \icms_core_Message
Open
icms_core_Message::confirm(array('op' => 'delfileok', 'image_id' => $image_id, 'imgcat_id' => $imgcat_id, 'fct' => 'images'), 'admin.php', _MD_RUDELIMG);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$k]->getVar('imgcat_id')));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to undeclared constant \_IMAGEFILE
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to undeclared constant \_IMGMANAGER
Open
$icmsAdminTpl->assign('lang_imanager_title', _IMGMANAGER);
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
$icmsAdminTpl->assign('token', icms::$security->getTokenHTML());
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addcat'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$tray1->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Reference to undeclared constant \_YES
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!is_object(icms::$user)) {
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_select_Group
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
Reference to undeclared constant \_NO
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', 1, _YES, _NO));
- Exclude checks
Reference to undeclared constant \_CANCEL
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Reference to undeclared constant \_IMGMANAGER
Open
$icmsAdminTpl->assign('lang_imanager_title', _IMGMANAGER);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$i]->getVar('imgcat_id')));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_select_Group
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $id));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, 0));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$sc += $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $va->getVar('imgcat_id')));
- Exclude checks
Reference to undeclared constant \_ADDIMAGE
Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_Theme
Open
$form = new icms_form_Theme(_MD_ADDIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Exclude checks
Reference to undeclared constant \_IMGMAXWIDTH
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, 120));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radioyn
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', 1, _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addcat'));
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_File
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radioyn
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($tray);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, 50000));
- Exclude checks
Reference to undeclared constant \_IMGMAXSIZE
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, 50000));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, 0));
- Exclude checks
Reference to undeclared constant \_YES
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', 1, _YES, _NO));
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$tray1->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_elements_Button
Open
$btn->setExtra('onclick="document.getElementById(\'addcatform\').style.display = \'none\'; return false;"');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Reference to undeclared constant \_NOPERM
Open
exit(_NOPERM);
- Exclude checks
Call to method confirm
from undeclared class \icms_core_Message
Open
icms_core_Message::confirm(array('op' => 'delcatok', 'imgcat_id' => $imgcat_id, 'fct' => 'images'), 'admin.php', _MD_RUDELIMGCAT);
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$groups = &icms::$user->getGroups();
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaWrite = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaWrite->add(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Exclude checks
Reference to undeclared constant \_DELETE
Open
$icmsAdminTpl->assign('lang_imanager_cat_del', _DELETE);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add($criteriaTray);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategorys[$k]->getVar('imgcat_id')));
- Exclude checks
Reference to undeclared constant \_IMAGECAT
Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', $imgcat_id);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Tray
Open
$tray = new icms_form_elements_Tray('', '');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Select
Open
$sup = new icms_form_elements_Select(_MD_IMGCATPARENT, 'imgcat_pid', $imgcat_id);
- Exclude checks
Call to method setDescription
from undeclared class \icms_form_elements_Text
Open
$fname->setDescription('<span style="color:#ff0000;">' . _MD_IMGCATFOLDERNAME_DESC . '<br />' . _MD_STRTYOPENG . '</span>');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray1->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_Theme
Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Select
Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', $imgcat_id);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_elements_Button
Open
$btn->setExtra('onclick="document.getElementById(\'addimgform\').style.display = \'none\'; return false;"');
- Exclude checks
Call to method render
from undeclared class \icms_form_Theme
Open
$icmsAdminTpl->assign('addimgform', $form->render());
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', 1, _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radio
Open
$storetype = new icms_form_elements_Radio(_MD_IMGCATSTRTYPE, 'imgcat_storetype', 'file');
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_elements_Radio
Open
$storetype->setExtra('onchange="actField(this.value,\'imgcat_foldername\');"');
- Exclude checks
Reference to undeclared constant \_EDIT
Open
$icmsAdminTpl->assign('lang_imanager_cat_edit', _EDIT);
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$icmsAdminTpl->assign('lang_imanager_cat_submit', _SUBMIT);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add($criteriaTray);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method mkdir
from undeclared class \icms_core_Filesystem
Open
if (!icms_core_Filesystem::mkdir($categ_path)) {
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images', 2, _MD_AM_DBUPDATED);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('op', 'updatecat'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria2->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'), 'OR');
- Exclude checks
Call to method getErrors
from undeclared class \icms_file_MediaUploadHandler
Open
$err = array_merge($err, $uploader->getErrors(FALSE));
- Exclude checks
Reference to undeclared constant \_FAILSAVEIMG
Open
$error[] = sprintf(_FAILSAVEIMG, $image_id[$i]);
- Exclude checks
Call to method error
from undeclared class \icms_core_Message
Open
icms_core_Message::error(sprintf(_MD_FAILDEL, $image->getVar('image_id')));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_File
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Reference to undeclared constant \_IMGDISPLAY
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
$msg = _MD_AM_DBUPDATED;
- Exclude checks
Default value for \bln
$list
can't be false
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Default value for \str
$separador
can't be string
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Reference to undeclared constant \_IMGDISPLAY
Open
$icmsAdminTpl->assign('lang_image_disp', _IMGDISPLAY);
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$icmsAdminTpl->assign('lang_submit', _SUBMIT);
- Exclude checks
Reference to undeclared constant \_CANCEL
Open
$icmsAdminTpl->assign('lang_cancel', _CANCEL);
- Exclude checks
Call to method setLimit
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setLimit($limit);
- Exclude checks
Suspicious type null
of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
if ($fh = @fopen($categ_path . '/index.html', 'w')) fwrite($fh, '<script>history.go(-1);</script>');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, $imagecategory->getVar('imgcat_maxsize')));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, $imagecategory->getVar('imgcat_maxwidth')));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to undeclared constant \_FAILGETIMG
Open
$error[] = sprintf(_FAILGETIMG, $image_id[$i]);
- Exclude checks
Reference to undeclared constant \_BACK
Open
$icmsAdminTpl->assign('lang_imanager_cat_back', _BACK);
- Exclude checks
Function imanager_delfileok
defined at /code/htdocs/modules/system/admin/images/main.php:1000
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:780
Open
function imanager_delfileok($image_id, $redir = NULL) {
- Exclude checks
Reference to undeclared constant \_FAILSAVEIMG
Open
$msg = sprintf(_FAILSAVEIMG, $image->getVar('image_nicename'));
- Exclude checks
Returning type null|string
but adminNav()
is declared to return \str
Open
return $ret;
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead = new icms_db_criteria_Compo();
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Reference to undeclared constant \_IMAGEMIME
Open
$icmsAdminTpl->assign('lang_image_mimetype', _IMAGEMIME);
- Exclude checks
Call to method load
from undeclared class \WideImage\WideImage
Open
$img = WideImage::load($images[$i]->getVar('image_body'))->saveToFile(ICMS_IMANAGER_FOLDER_PATH . '/' . $images[$i]->getVar('image_name'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_select_Group
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_read', $imgcat_id), 5, TRUE));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('op', 'updatecat'));
- Exclude checks
Reference to undeclared constant \_QSEARCH
Open
$icmsAdminTpl->assign('lang_search_title', _QSEARCH);
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check() || $imgcat_id <= 0) {
- Exclude checks
Call to method setOrder
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setOrder('DESC');
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Reference to undeclared constant \_IMGMAXWIDTH
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, $imagecategory->getVar('imgcat_maxwidth')));
- Exclude checks
Call to method setPrefix
from undeclared class \icms_file_MediaUploadHandler
Open
$uploader->setPrefix('img');
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radioyn
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', $imagecategory->getVar('imgcat_display'), _YES, _NO));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Reference to undeclared constant \_MD_SCATDELNG
Open
redirect_header('admin.php?fct=images', 1, _MD_SCATDELNG);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Exclude checks
Call to method error
from undeclared class \icms_core_Message
Open
icms_core_Message::error($errors);
- Exclude checks
Default value for \str
$style
can't be string
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Call to method fetchMedia
from undeclared class \icms_file_MediaUploadHandler
Open
if ($uploader->fetchMedia($_POST['xoops_upload_file'][$i])) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Reference to undeclared constant \_NO
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray->addElement($btn);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Exclude checks
Reference to undeclared constant \_IMGWEIGHT
Open
$icmsAdminTpl->assign('lang_image_weight', _IMGWEIGHT);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('imgcat_id', $imgcat_id));
- Exclude checks
Reference to undeclared constant \_IMGMAXHEIGHT
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, $imagecategory->getVar('imgcat_maxheight')));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Reference to undeclared constant \_FAILSAVEIMG
Open
$err[] = sprintf(_FAILSAVEIMG, $image->getVar('image_nicename'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method addOptionArray
from undeclared class \icms_form_elements_Select
Open
$select->addOptionArray($imgcat_handler->getCategList());
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Reference to undeclared constant \_IMGWEIGHT
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_elements_Tray
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($tray);
- Exclude checks
Call to method load
from undeclared class \WideImage\WideImage
Open
$img = WideImage::load($image->getVar('image_body'))->saveToFile(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'));
- Exclude checks
Returning type false
but adminNav()
is declared to return \str
Open
return FALSE;
- Exclude checks
Returning type false
but adminNav()
is declared to return \str
Open
return FALSE;
- Exclude checks
Function redir
defined at /code/htdocs/modules/system/admin/images/main.php:1163
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:995
Open
function redir($imgcat_id, $msg = NULL) {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray = new icms_db_criteria_Compo();
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('image_nicename', '%' . icms::$xoopsDB->quote($query) . '%', 'LIKE'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_write', $imgcat_id), 5, TRUE));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, $imagecategory->getVar('imgcat_maxheight')));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, $imagecategory->getVar('imgcat_weight')));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Label(_MD_IMGCATSTRTYPE, $storetype[$imagecategory->getVar('imgcat_storetype')]));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria2 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Reference to undeclared constant \_IMAGECAT
Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', (int) $imgcat_id);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Exclude checks
Reference to undeclared constant \_LIST
Open
$icmsAdminTpl->assign('lang_imanager_cat_listimg', _LIST);
- Exclude checks
Reference to undeclared constant \_ADDIMAGE
Open
$icmsAdminTpl->assign('lang_imanager_cat_addimg', _ADDIMAGE);
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Label
Open
$form->addElement(new icms_form_elements_Label(_MD_IMGCATSTRTYPE, $storetype[$imagecategory->getVar('imgcat_storetype')]));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Reference to undeclared constant \_YES
Open
$icmsAdminTpl->assign('lang_yes', _YES);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_itemid', $imgcat_id));
- Exclude checks
Reference to undeclared constant \_SEARCH
Open
$icmsAdminTpl->assign('lang_search', _SEARCH);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$sc += $image_handler->getCount(new icms_db_criteria_Item('imgcat_id', $va->getVar('imgcat_id')));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('imgcat_id', $imgcat_id));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria2 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'imgcat_write'));
- Exclude checks
Call to method setStart
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setStart($start);
- Exclude checks
Call to method load
from undeclared class \WideImage\WideImage
Open
$img_info = WideImage::load(ICMS_IMANAGER_FOLDER_PATH . '/' . $images[$i]->getVar('image_name'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radioyn
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method setSort
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setSort('image_weight');
- Exclude checks
Reference to undeclared constant \_YES
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', $imagecategory->getVar('imgcat_display'), _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('imgcat_pid', $imagecategory->getVar('imgcat_id')));
- Exclude checks
Reference to undeclared constant \_PREVIEW
Open
$preview_url = '<a href="' . $src_lightbox . '" rel="lightbox[categ' . $images[$i]->getVar('imgcat_id') . ']" title="' . $images[$i]->getVar('image_nicename') . '"><img src="' . ICMS_IMAGES_SET_URL . '/actions/viewmag.png" alt="' . _PREVIEW . '" title="' . _PREVIEW . '" /></a>';
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
$arrimg[$i]['clone_token'] = icms::$security->getTokenHTML();
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images', 2, _MD_AM_DBUPDATED);
- Exclude checks
Call to method __construct
from undeclared class \icms_view_PageNav
Open
$nav = new icms_view_PageNav($imgcount, 15, $start, 'start', 'fct=images&op=listimg&imgcat_id=' . $imgcat_id);
- Exclude checks
Call to method error
from undeclared class \icms_core_Message
Open
icms_core_Message::error($error);
- Exclude checks
Function imanager_addcat
defined at /code/htdocs/modules/system/admin/images/main.php:572
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:560
Open
function imanager_addcat() {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_select_Group
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_write', $imgcat_id), 5, TRUE));
- Exclude checks
Function imanager_clone
defined at /code/htdocs/modules/system/admin/images/main.php:1062
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:815
Open
function imanager_clone() {
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255, $imagecategory->getVar('imgcat_name')), TRUE);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_read', $imgcat_id), 5, TRUE));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method display
from undeclared class \icms_form_Theme
Open
$form->display();
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Call to method getSavedFileName
from undeclared class \icms_file_MediaUploadHandler
Open
$image->setVar('image_name', $uploader->getSavedFileName());
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method upload
from undeclared class \icms_file_MediaUploadHandler
Open
if (!$uploader->upload()) {
- Exclude checks
Call to method getMediaType
from undeclared class \icms_file_MediaUploadHandler
Open
$image->setVar('image_mimetype', $uploader->getMediaType());
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images' . $redir, 2, _MD_AM_DBUPDATED);
- Exclude checks
Reference to undeclared constant \_NO
Open
$icmsAdminTpl->assign('lang_no', _NO);
- Exclude checks
Reference to undeclared constant \_FAILFETCHIMG
Open
$err[] = sprintf(_FAILFETCHIMG, $i);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement($select, TRUE);
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$criteria->add(new icms_db_criteria_Item('image_nicename', '%' . icms::$xoopsDB->quote($query) . '%', 'LIKE'));
- Exclude checks
Reference to undeclared constant \_FAILSAVEIMG
Open
$error[] = sprintf(_FAILSAVEIMG, $image_id[$i]);
- Exclude checks
Returning type string
but adminNav()
is declared to return \str
Open
return "<a href='" . $admin_url . "'>" . _MD_IMGMAIN . "</a> $separador " . $ret;
- Exclude checks
Call to method load
from undeclared class \WideImage\WideImage
Open
$img_info = WideImage::load($path . $images[$i]->getVar('image_name'));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', $imagecategory->getVar('imgcat_display'), _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$form->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
$msg = _MD_AM_DBUPDATED;
- Exclude checks
Call to method getSavedDestination
from undeclared class \icms_file_MediaUploadHandler
Open
$fp = @fopen($uploader->getSavedDestination(), 'rb');
- Exclude checks
Reference to undeclared constant \_ADDIMAGE
Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
Reference to undeclared constant \_YES
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_elements_Button
Open
$btn->setExtra('onclick="document.getElementById(\'addimgform\').style.display = \'none\'; return false;"');
- Exclude checks
Argument 3 (message)
is \str
but \redirect_header()
takes string
defined at /code/htdocs/include/functions.php:188
Open
redirect_header('admin.php?fct=images&op=listimg&imgcat_id=' . (int) $imgcat_id, 2, $msg);
- Exclude checks
Reference to undeclared constant \_IMAGECAT
Open
$icmsAdminTpl->assign('lang_image_cat', _IMAGECAT);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255, $imagecategory->getVar('imgcat_name')), TRUE);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXHEIGHT, 'imgcat_maxheight', 3, 4, $imagecategory->getVar('imgcat_maxheight')));
- Exclude checks
Reference to undeclared constant \_NO
Open
$form->addElement(new icms_form_elements_Radioyn(_MD_IMGCATDISPLAY, 'imgcat_display', $imagecategory->getVar('imgcat_display'), _YES, _NO));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$images = &$image_handler->getObjects(new icms_db_criteria_Item('imgcat_id', $imgcat_id), TRUE, FALSE);
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method error
from undeclared class \icms_core_Message
Open
icms_core_Message::error($err);
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images' . $redir, 2, _MD_AM_DBUPDATED);
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add($criteriaTray);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Radioyn(_IMGDISPLAY, 'image_display', 1, _YES, _NO));
- Exclude checks
Reference to undeclared constant \_PREVIEW
Open
$icmsAdminTpl->assign('lang_imanager_img_preview', _PREVIEW);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Tray
Open
$tray = new icms_form_elements_Tray('', '');
- Exclude checks
Reference to undeclared constant \_IMAGENAME
Open
$icmsAdminTpl->assign('lang_image_name', _IMAGENAME);
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
$arrimg[$i]['ed_token'] = icms::$security->getTokenHTML();
- Exclude checks
Parameter $style
has undeclared type \str
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Argument 1 (filename)
is null
but \file_exists()
takes string
Open
if (!file_exists($categ_path)) {
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATWEIGHT, 'imgcat_weight', 3, 4, $imagecategory->getVar('imgcat_weight')));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria2->add(new icms_db_criteria_Item('gperm_name', 'imgcat_read'), 'OR');
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add($criteria2);
- Exclude checks
Call to method __construct
from undeclared class \icms_file_MediaUploadHandler
Open
$uploader = new icms_file_MediaUploadHandler($updir, array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/bmp'), $imagecategory->getVar('imgcat_maxsize'), $imagecategory->getVar('imgcat_maxwidth'), $imagecategory->getVar('imgcat_maxheight'));
- Exclude checks
Function showAddImgForm
defined at /code/htdocs/modules/system/admin/images/main.php:1036
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:929
Open
function showAddImgForm($imgcat_id) {
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Select
Open
$select = new icms_form_elements_Select(_IMAGECAT, 'imgcat_id', (int) $imgcat_id);
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Hidden
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Reference to undeclared constant \_CANCEL
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Reference to undeclared constant \_FAILSAVEIMG
Open
$msg = sprintf(_FAILSAVEIMG, $newimg->getVar('image_nicename'));
- Exclude checks
Parameter $msg
has undeclared type \str
Open
function redir($imgcat_id, $msg = NULL) {
- Exclude checks
Call to method icms_substr
from undeclared class \icms_core_DataFilter
Open
$arrimg[$i]['display_nicename'] = icms_core_DataFilter::icms_substr($images[$i]->getVar('image_nicename'), 0, 20);
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXWIDTH, 'imgcat_maxwidth', 3, 4, $imagecategory->getVar('imgcat_maxwidth')));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_itemid', $imgcat_id));
- Exclude checks
Call to method getSavedDestination
from undeclared class \icms_file_MediaUploadHandler
Open
$fbinary = @fread($fp, filesize($uploader->getSavedDestination()));
- Exclude checks
Call to method getSavedDestination
from undeclared class \icms_file_MediaUploadHandler
Open
@unlink($uploader->getSavedDestination());
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
if (!icms::$security->check()) {
- Exclude checks
Call to method setExtra
from undeclared class \icms_form_Theme
Open
$form->setExtra('enctype="multipart/form-data"');
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('fct', 'images'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$tray->addElement(new icms_form_elements_Button('', 'img_button', _SUBMIT, 'submit'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Parameter $separador
has undeclared type \str
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteriaTray = new icms_db_criteria_Compo();
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('image_nicename', '%' . icms::$xoopsDB->quote($query) . '%', 'LIKE'));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_Theme
Open
$form = new icms_form_Theme(_MD_EDITIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Exclude checks
Reference to undeclared constant \_IMGMAXSIZE
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, $imagecategory->getVar('imgcat_maxsize')));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Reference to undeclared constant \_SUBMIT
Open
$form->addElement(new icms_form_elements_Button('', 'imgcat_button', _SUBMIT, 'submit'));
- Exclude checks
Function imanager_addfile
defined at /code/htdocs/modules/system/admin/images/main.php:857
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:642
Open
function imanager_addfile() {
- Exclude checks
Call to method getErrors
from undeclared class \icms_file_MediaUploadHandler
Open
$err[] = $uploader->getErrors();
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images' . $redir, 2, _MD_AM_DBUPDATED);
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Text(_IMGWEIGHT, 'image_weight', 3, 4, 0));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('imgcat_id', $imgcat_id));
- Exclude checks
Call to method addElement
from undeclared class \icms_form_Theme
Open
$form->addElement(new icms_form_elements_Hidden('op', 'addfile'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteriaRead->add(new icms_db_criteria_Item('gperm_modid', 1));
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Button
Open
$btn = new icms_form_elements_Button('', 'reset', _CANCEL, 'button');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$image_handler = icms::handler('icms_image');
- Exclude checks
Call to method renderNav
from undeclared class \icms_view_PageNav
Open
$icmsAdminTpl->assign('pag', '<div class="img_list_info_panel" align="center">' . $nav->renderNav() . '</div>');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Text
Open
$form->addElement(new icms_form_elements_Text(_IMGMAXSIZE, 'imgcat_maxsize', 10, 10, $imagecategory->getVar('imgcat_maxsize')));
- Exclude checks
Function adminNav
defined at /code/htdocs/modules/system/admin/images/main.php:1129
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:959
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Exclude checks
Reference to undeclared constant \_MD_AM_DBUPDATED
Open
redirect_header('admin.php?fct=images', 2, _MD_AM_DBUPDATED);
- Exclude checks
Return type of adminNav()
is undeclared type \str
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Function imanager_updateimage
defined at /code/htdocs/modules/system/admin/images/main.php:929
was previously defined at /code/htdocs/modules/system/admin/images/browser.php:715
Open
function imanager_updateimage() {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$imgcat_handler = icms::handler('icms_image_category');
- Exclude checks
Call to method __construct
from undeclared class \icms_form_Theme
Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
Reference to undeclared constant \_IMAGENAME
Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
Reference to undeclared constant \_IMAGEFILE
Open
$form->addElement(new icms_form_elements_File(_IMAGEFILE, 'image_file', 5000000));
- Exclude checks
Call to method render
from undeclared class \icms_form_Theme
Open
return $form->render();
- Exclude checks
Parameter $list
has undeclared type \bln
Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
for ($i = 0; $i < $ucount; $i++ ) {
if ($uploader->fetchMedia($_POST['xoops_upload_file'][$i])) {
if (!$uploader->upload()) {
$err[] = $uploader->getErrors();
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 398.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($imagecategory->getVar('imgcat_storetype') == 'db') {
$src = ICMS_MODULES_URL . "/system/admin/images/preview.php?file=" . $image->getVar('image_name') . '&resize=0';
$img = WideImage::load($image->getVar('image_body'))->saveToFile(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'));
$fp = @fopen(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'), 'rb');
$fbinary = @fread($fp, filesize(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name')));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 294.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($id === FALSE) {
return FALSE;
} else {
if ($id > 0) {
$id = (int) $id;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 248.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 10 locations. Consider refactoring. Open
if (is_array($groups) && !empty($groups)) {
$criteriaTray = new icms_db_criteria_Compo();
foreach ($groups as $gid) {
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 10 locations. Consider refactoring. Open
if (is_array($groups) && !empty($groups)) {
$criteriaTray = new icms_db_criteria_Compo();
foreach ($groups as $gid) {
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 10 locations. Consider refactoring. Open
if (is_array($groups) && !empty($groups)) {
$criteriaTray = new icms_db_criteria_Compo();
foreach ($groups as $gid) {
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 10 locations. Consider refactoring. Open
if (is_array($groups) && !empty($groups)) {
$criteriaTray = new icms_db_criteria_Compo();
foreach ($groups as $gid) {
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 10 locations. Consider refactoring. Open
if (is_array($groups) && !empty($groups)) {
$criteriaTray = new icms_db_criteria_Compo();
foreach ($groups as $gid) {
$criteriaTray->add(new icms_db_criteria_Item('gperm_groupid', $gid), 'OR');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 106.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $imagecategoryperm_handler. Keep variable name length under 20. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $imagecategoryperm_handler. Keep variable name length under 20. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $imagecategoryperm_handler. Keep variable name length under 20. Open
$imagecategoryperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
The parameter $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $sc. Configured minimum length is 3. Open
$sc = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $fh. Configured minimum length is 3. Open
if ($fh = @fopen($categ_path . '/index.html', 'w')) fwrite($fh, '<script>history.go(-1);</script>');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $sc. Configured minimum length is 3. Open
$sc = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $js. Configured minimum length is 3. Open
$js = 'var fname = document.getElementById("imgcat_foldername");';
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $fp. Configured minimum length is 3. Open
$fp = @fopen($uploader->getSavedDestination(), 'rb');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $imgcat_id is not named in camelCase. Open
function redir($imgcat_id, $msg = NULL) {
redirect_header('admin.php?fct=images&op=listimg&imgcat_id=' . (int) $imgcat_id, 2, $msg);
}
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Avoid variables with short names like $id. Configured minimum length is 3. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $fp. Configured minimum length is 3. Open
$fp = @fopen(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'), 'rb');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $imgcat_id is not named in camelCase. Open
function showAddImgForm($imgcat_id) {
$imgcat_handler = icms::handler('icms_image_category');
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
$form->setExtra('enctype="multipart/form-data"');
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $image_id is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$admin = FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$clean_GET = icms_core_DataFilter::checkVarArray($_GET, $filter_get, FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_Text(_MD_IMGCATNAME, 'imgcat_name', 50, 255, $imagecategory->getVar('imgcat_name')), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_read', $imgcat_id), 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$images = &$image_handler->getObjects(new icms_db_criteria_Item('imgcat_id', $imgcat_id), TRUE, FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form = new icms_form_Theme(_MD_ADDIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$images = &$image_handler->getObjects($criteria, TRUE, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$images = &$image_handler->getObjects($criteria, TRUE, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$admin = FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$query = !empty($query) ? $query : NULL;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATRGRP, 'readgroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_read', $imgcat_id), 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$clean_POST = icms_core_DataFilter::checkVarArray($_POST, $filter_post, FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement($fname, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($id === FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement($select, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (($ext = strrpos($image->getVar('image_name'), '.')) !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
function imanager_index($imgcat_id = NULL) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement($select, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$newimg->setVar('image_body', $fbinary, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $ucount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
if (NULL !== $query) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_write', $imgcat_id), 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$list = $imgcat_handler->getList(array(), NULL, NULL, $imagecategory->getVar('imgcat_storetype'));
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $ucount; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$list = $imgcat_handler->getList(array(), NULL, NULL, $imagecategory->getVar('imgcat_storetype'));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$changedCat = TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
function redir($imgcat_id, $msg = NULL) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$msg = isset($_GET['msg']) ? urldecode($_GET['msg']) : NULL;
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $catcount; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $catcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form = new icms_form_Theme(_MD_EDITIMGCAT, 'imagecat_form', 'admin.php', 'post', TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$image->setVar('image_body', $fbinary, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$id = (NULL !== $imgcat_id ? $imgcat_id : 0);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$images = &$image_handler->getObjects(new icms_db_criteria_Item('imgcat_id', $imgcat_id), TRUE, FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$err = array_merge($err, $uploader->getErrors(FALSE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$changedCat = FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
function imanager_delfileok($image_id, $redir = NULL) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$admin = (!icms::$user->isAdmin(1)) ? FALSE : TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, ICMS_GROUP_ADMIN, 5, TRUE));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$form->addElement(new icms_form_elements_select_Group(_MD_IMGCATWGRP, 'writegroup', TRUE, $imagecategoryperm_handler->getGroupIds('imgcat_write', $imgcat_id), 5, TRUE));
- Exclude checks
Inline control structures are not allowed Open
if (isset($_GET['filter_post'])) unset($_GET['filter_post']);
- Exclude checks
Inline control structures are not allowed Open
if ($fh = @fopen($categ_path . '/index.html', 'w')) fwrite($fh, '<script>history.go(-1);</script>');
- Exclude checks
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_storetype is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_foldername is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxsize is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $extra_perm is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxwidth is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_storetype is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $dest_categ_path is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_pid is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_storetype is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxheight is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxwidth is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $src_lightbox is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_pid is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxwidth is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxheight is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_storetype is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_foldername is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $extra_perm is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxsize is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_name is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_weight is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_name is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_reordercateg() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
}
$count = count($_POST['imgcat_weight']);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $preview_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxsize is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_foldername is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxwidth is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $src_categ_path is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $preview_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxheight is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxheight is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $dest_categ_path is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_foldername is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $src_lightbox is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_index($imgcat_id = NULL) {
global $icmsAdminTpl, $icmsConfig, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_editcat($imgcat_id) {
if ($imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1);
}
$imgcat_handler = icms::handler('icms_image_category');
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_name is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_url is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $img_info is not named in camelCase. Open
function imanager_listimg($imgcat_id, $start = 0) {
global $icmsAdminTpl, $query, $limit;
if (!is_object(icms::$user)) {
$groups = array(ICMS_GROUP_ANONYMOUS);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_maxsize is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_weight is not named in camelCase. Open
function imanager_addcat() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_display is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_weight is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imagecategoryperm_handler is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_weight is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_name is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updatecat() {
/* because we are using a function, the GET/POST variables are not in scope */
global $imgcat_id, $imgcat_name, $imgcat_display, $imgcat_maxsize, $imgcat_maxwidth, $imgcat_maxheight, $imgcat_weight, $readgroup, $writegroup;
if (!icms::$security->check() || $imgcat_id <= 0) {
redirect_header('admin.php?fct=images', 1, implode('<br />', icms::$security->getErrors()));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delcatok($imgcat_id) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_addfile() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function showAddImgForm($imgcat_id) {
$imgcat_handler = icms::handler('icms_image_category');
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
$form->setExtra('enctype="multipart/form-data"');
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function redir($imgcat_id, $msg = NULL) {
redirect_header('admin.php?fct=images&op=listimg&imgcat_id=' . (int) $imgcat_id, 2, $msg);
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function showAddImgForm($imgcat_id) {
$imgcat_handler = icms::handler('icms_image_category');
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
$form->setExtra('enctype="multipart/form-data"');
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function showAddImgForm($imgcat_id) {
$imgcat_handler = icms::handler('icms_image_category');
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
$form->setExtra('enctype="multipart/form-data"');
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $src_categ_path is not named in camelCase. Open
function imanager_updateimage() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_display is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_weight is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $admin_url is not named in camelCase. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $admin_url is not named in camelCase. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $admin_url is not named in camelCase. Open
function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
$admin_url = ICMS_MODULES_URL . "/system/admin.php?fct=images";
if ($id === FALSE) {
return FALSE;
} else {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_id is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function showAddImgForm($imgcat_id) {
$imgcat_handler = icms::handler('icms_image_category');
$form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'admin.php', 'post', TRUE);
$form->setExtra('enctype="multipart/form-data"');
$form->addElement(new icms_form_elements_Text(_IMAGENAME, 'image_nicename', 50, 255), TRUE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $image_nicename is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_id is not named in camelCase. Open
function imanager_clone() {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $imgcat_handler is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $categ_path is not named in camelCase. Open
function imanager_delfileok($image_id, $redir = NULL) {
if (!icms::$security->check()) {
redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}