Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star
htdocs/modules/system/admin/mailusers/main.php

Summary

Maintainability
B
6 hrs
Test Coverage

Reference to instance property prefix from undeclared class \icms_db_criteria_Item
Open

                $crit->prefix = "u";
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setToUsers from undeclared class \icms_messaging_Handler
Open

                $xoopsMailer->setToUsers($added[$i]);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setBody from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer->setBody(icms_core_DataFilter::stripSlashesGPC($mail_body));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method send from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer->send(TRUE);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                        $form->addElement($group_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $idle_more_hidden = new icms_form_elements_Hidden("mail_idle_more", $mail_idle_more, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $idle_less_hidden = new icms_form_elements_Hidden("mail_idle_less", $mail_idle_less, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                        $form->addElement(new icms_form_elements_Hidden("mail_send_to[]", $v));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setStart from undeclared class \icms_db_criteria_Compo
Open

            $criteria_object->setStart(@$mail_start);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($idle_more_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($start_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Reference to static property user from undeclared class \icms
Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 6 (year) is string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_min, 5, 2), substr($f_mail_lastlog_min, 8, 2), substr($f_mail_lastlog_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 4 (mon) is false|string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_max, 5, 2), substr($f_mail_lastlog_max, 8, 2), substr($f_mail_lastlog_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 5 (day) is false|string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_max, 5, 2), substr($f_mail_lastlog_max, 8, 2), substr($f_mail_lastlog_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Button
Open

                $submit_button = new icms_form_elements_Button("", "mail_submit", _AM_SENDNEXT, "submit");
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                    $form->addElement($to_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 6 (year) is string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_max, 5, 2), substr($f_mail_regd_max, 8, 2), substr($f_mail_regd_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setLimit from undeclared class \icms_db_criteria_Compo
Open

            $criteria_object->setLimit($limit);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $lastlog_min_hidden = new icms_form_elements_Hidden("mail_lastlog_min", $mail_lastlog_min, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($subject_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($body_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method checkVarArray from undeclared class \icms_core_DataFilter
Open

    $clean_GET = icms_core_DataFilter::checkVarArray($_GET, $filter_get, false);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 6 (year) is string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_max, 5, 2), substr($f_mail_lastlog_max, 8, 2), substr($f_mail_lastlog_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 5 (day) is false|string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_max, 5, 2), substr($f_mail_regd_max, 8, 2), substr($f_mail_regd_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method usePM from undeclared class \icms_messaging_Handler
Open

                $xoopsMailer->usePM();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method getErrors from undeclared class \icms_messaging_Handler
Open

            echo $xoopsMailer->getErrors();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_Theme
Open

                $form = new icms_form_Theme(_AM_SENDMTOUSERS, "mailusers", "admin.php?fct=mailusers", 'post', TRUE);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $inactive_hidden = new icms_form_elements_Hidden("mail_inactive", @$mail_inactive);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $start_hidden = new icms_form_elements_Hidden("mail_start", $mail_start + $limit);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 4 (mon) is false|string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_min, 5, 2), substr($f_mail_regd_min, 8, 2), substr($f_mail_regd_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method stripSlashesGPC from undeclared class \icms_core_DataFilter
Open

            $xoopsMailer->setFromEmail(icms_core_DataFilter::stripSlashesGPC($mail_fromemail));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method useMail from undeclared class \icms_messaging_Handler
Open

                $xoopsMailer->useMail();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $subject_hidden = new icms_form_elements_Hidden("mail_subject", $mail_subject, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method display from undeclared class \icms_form_Theme
Open

                $form->display();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 4 (mon) is false|string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_max, 5, 2), substr($f_mail_regd_max, 8, 2), substr($f_mail_regd_max, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($fname_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($mail_mailok_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 5 (day) is false|string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_min, 5, 2), substr($f_mail_regd_min, 8, 2), substr($f_mail_regd_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 6 (year) is string but \mktime() takes int
Open

            $time = mktime(0, 0, 0, substr($f_mail_regd_min, 5, 2), substr($f_mail_regd_min, 8, 2), substr($f_mail_regd_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $op_hidden = new icms_form_elements_Hidden("op", "send");
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($lastlog_max_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Reference to static property security from undeclared class \icms
Open

    if (!icms::$security->check() || $op === "form") {
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method add from undeclared class \icms_db_criteria_Compo
Open

                $criteria_object->add($crit, 'AND');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer = new icms_messaging_Handler();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Variable $icmsModule is undeclared
Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setFromName from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer->setFromName(icms_core_DataFilter::stripSlashesGPC($mail_fromname));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setFromEmail from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer->setFromEmail(icms_core_DataFilter::stripSlashesGPC($mail_fromemail));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method setSubject from undeclared class \icms_messaging_Handler
Open

            $xoopsMailer->setSubject(icms_core_DataFilter::stripSlashesGPC($mail_subject));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method getSuccess from undeclared class \icms_messaging_Handler
Open

            echo $xoopsMailer->getSuccess();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $regd_max_hidden = new icms_form_elements_Hidden("mail_regd_max", $mail_regd_max, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $fname_hidden = new icms_form_elements_Hidden("mail_fromname", $mail_fromname, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $femail_hidden = new icms_form_elements_Hidden("mail_fromemail", $mail_fromemail, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method checkVarArray from undeclared class \icms_core_DataFilter
Open

    $clean_POST = icms_core_DataFilter::checkVarArray($_POST, $filter_post, false);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Reference to static property security from undeclared class \icms
Open

        if ($op != "form" && $error_msg = icms::$security->getErrors(TRUE)) {
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_db_criteria_Compo
Open

            $criteria_object = new icms_db_criteria_Compo();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method handler from undeclared class \icms
Open

            $member_handler = icms::handler('icms_member');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method stripSlashesGPC from undeclared class \icms_core_DataFilter
Open

            $xoopsMailer->setBody(icms_core_DataFilter::stripSlashesGPC($mail_body));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $lastlog_max_hidden = new icms_form_elements_Hidden("mail_lastlog_max", $mail_lastlog_max, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($inactive_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method display from undeclared class \icms_form_Theme
Open

        $form->display();
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $regd_min_hidden = new icms_form_elements_Hidden("mail_regd_min", $mail_regd_min, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $body_hidden = new icms_form_elements_Hidden("mail_body", $mail_body, 'text');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                $mail_mailok_hidden = new icms_form_elements_Hidden("mail_mailok", $mail_mailok);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($lastlog_min_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($regd_min_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($regd_max_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                        $form->addElement(new icms_form_elements_Hidden("mail_send_to[]", $v));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 4 (mon) is false|string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_min, 5, 2), substr($f_mail_lastlog_min, 8, 2), substr($f_mail_lastlog_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($submit_button);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Argument 5 (day) is false|string but \mktime() takes int
Open

                $time = mktime(0, 0, 0, substr($f_mail_lastlog_min, 5, 2), substr($f_mail_lastlog_min, 8, 2), substr($f_mail_lastlog_min, 0, 4));
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_db_criteria_Item
Open

                $crit = new icms_db_criteria_Item($field, $value, $op);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method stripSlashesGPC from undeclared class \icms_core_DataFilter
Open

            $xoopsMailer->setSubject(icms_core_DataFilter::stripSlashesGPC($mail_subject));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($femail_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                    $to_hidden = new icms_form_elements_Hidden("mail_send_to", 'mail');
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_member_user_Object
Open

                    $added[] = new icms_member_user_Object($to_user);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method stripSlashesGPC from undeclared class \icms_core_DataFilter
Open

            $xoopsMailer->setFromName(icms_core_DataFilter::stripSlashesGPC($mail_fromname));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Hidden
Open

                        $group_hidden = new icms_form_elements_Hidden("mail_to_group[]", $mailgroup);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method __construct from undeclared class \icms_form_elements_Label
Open

                $sent_label = new icms_form_elements_Label(_AM_SENT, sprintf(_AM_SENTNUM, $mail_start + 1, $mail_start + $limit, $count_criteria + $added_count - $limit));
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($sent_label);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($idle_less_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Call to method addElement from undeclared class \icms_form_Theme
Open

                $form->addElement($op_hidden);
Severity: Critical
Found in htdocs/modules/system/admin/mailusers/main.php by phan

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (!empty($mail_lastlog_min)) {
                $f_mail_lastlog_min = trim($mail_lastlog_min);
                $time = mktime(0, 0, 0, substr($f_mail_lastlog_min, 5, 2), substr($f_mail_lastlog_min, 8, 2), substr($f_mail_lastlog_min, 0, 4));
                if ($time > 0) {
                    $criteria[] = "last_login > $time";
Severity: Major
Found in htdocs/modules/system/admin/mailusers/main.php and 3 other locations - About 1 hr to fix
htdocs/modules/system/admin/mailusers/main.php on lines 143..149
htdocs/modules/system/admin/mailusers/main.php on lines 168..174
htdocs/modules/system/admin/mailusers/main.php on lines 176..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (!empty($mail_lastlog_max)) {
                $f_mail_lastlog_max = trim($mail_lastlog_max);
                $time = mktime(0, 0, 0, substr($f_mail_lastlog_max, 5, 2), substr($f_mail_lastlog_max, 8, 2), substr($f_mail_lastlog_max, 0, 4));
                if ($time > 0) {
                    $criteria[] = "last_login < $time";
Severity: Major
Found in htdocs/modules/system/admin/mailusers/main.php and 3 other locations - About 1 hr to fix
htdocs/modules/system/admin/mailusers/main.php on lines 136..142
htdocs/modules/system/admin/mailusers/main.php on lines 168..174
htdocs/modules/system/admin/mailusers/main.php on lines 176..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (!empty($mail_regd_max)) {
            $f_mail_regd_max = trim($mail_regd_max);
            $time = mktime(0, 0, 0, substr($f_mail_regd_max, 5, 2), substr($f_mail_regd_max, 8, 2), substr($f_mail_regd_max, 0, 4));
            if ($time > 0) {
                $criteria[] = "user_regdate < $time";
Severity: Major
Found in htdocs/modules/system/admin/mailusers/main.php and 3 other locations - About 1 hr to fix
htdocs/modules/system/admin/mailusers/main.php on lines 136..142
htdocs/modules/system/admin/mailusers/main.php on lines 143..149
htdocs/modules/system/admin/mailusers/main.php on lines 168..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (!empty($mail_regd_min)) {
            $f_mail_regd_min = trim($mail_regd_min);
            $time = mktime(0, 0, 0, substr($f_mail_regd_min, 5, 2), substr($f_mail_regd_min, 8, 2), substr($f_mail_regd_min, 0, 4));
            if ($time > 0) {
                $criteria[] = "user_regdate > $time";
Severity: Major
Found in htdocs/modules/system/admin/mailusers/main.php and 3 other locations - About 1 hr to fix
htdocs/modules/system/admin/mailusers/main.php on lines 136..142
htdocs/modules/system/admin/mailusers/main.php on lines 143..149
htdocs/modules/system/admin/mailusers/main.php on lines 176..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
Open

            $xoopsMailer->send(TRUE);
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
Open

        if ($op != "form" && $error_msg = icms::$security->getErrors(TRUE)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Expected 1 blank line at end of file; 2 found
Open

    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
Open

            $getusers = $member_handler->getUsersByGroupLink($groups, $criteria_object, TRUE);
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
Open

                $form = new icms_form_Theme(_AM_SENDMTOUSERS, "mailusers", "admin.php?fct=mailusers", 'post', TRUE);
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Inline control structures are not allowed
Open

    if (isset($_GET['filter_post'])) unset($_GET['filter_post']);
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 0 tabs, found 1
Open

    elseif ($op === "send" && !empty($mail_send_to))
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if (!in_array($getuser->getVar("uid"), $added_id)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if ($op != "form" && $error_msg = icms::$security->getErrors(TRUE)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 0 tabs, found 1
Open

    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if (!empty($criteria) || !empty($mail_to_group)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            for ($i = 0; $i < $added_count; $i++) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Expected 1 space after closing brace; newline found
Open

    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if (!empty($mail_regd_min)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Expected 1 space after closing parenthesis; found 5
Open

    elseif ($op === "send" && !empty($mail_send_to))
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (!empty($mail_idle_more)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (!empty($mail_lastlog_min)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (!empty($mail_mailok)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (!empty($mail_lastlog_max)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            foreach ($criteria as $c) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        } else {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 4 tabs, found 5
Open

                    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 0 tabs, found 1
Open

    if (!icms::$security->check() || $op === "form") {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            foreach ($getusers as $getuser) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (in_array("mail", $mail_send_to)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if (!empty($mail_inactive)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        } else {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            foreach ($mail_to_user as $to_user) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (!empty($mail_idle_less)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if (in_array("pm", $mail_send_to) && empty($mail_inactive)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            } else {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if ($time > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if (!empty($mail_regd_max)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 0 tabs, found 1
Open

    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if (!in_array($to_user, $added_id)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            if ($count_criteria > $limit) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if (!empty($mail_to_user)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        if ($added_count > 0) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if (!empty($mail_to_group)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                } else {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 1 tabs, found 2
Open

        }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 3 tabs, found 4
Open

                if (isset($mail_send_to) && is_array($mail_send_to)) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 4 tabs, found 5
Open

                    }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 4 tabs, found 5
Open

                    foreach ($mail_to_group as $mailgroup) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 4 tabs, found 5
Open

                    foreach ($mail_send_to as $v) {
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

Line indented incorrectly; expected 2 tabs, found 3
Open

            }
Severity: Minor
Found in htdocs/modules/system/admin/mailusers/main.php by phpcodesniffer

There are no issues that match your filters.

Category
Status