Function icms_module_update
has a Cognitive Complexity of 391 (exceeds 5 allowed). Consider refactoring. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function xoops_module_install
has a Cognitive Complexity of 344 (exceeds 5 allowed). Consider refactoring. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function xoops_module_uninstall
has a Cognitive Complexity of 165 (exceeds 5 allowed). Consider refactoring. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File modulesadmin.php
has 1190 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
// $Id: modulesadmin.php 12403 2014-01-26 21:35:08Z skenow $
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
// Copyright (c) 2000 XOOPS.org //
Method xoops_module_install
has 413 lines of code (exceeds 25 allowed). Consider refactoring. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
Method icms_module_update
has 406 lines of code (exceeds 25 allowed). Consider refactoring. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
Method xoops_module_uninstall
has 208 lines of code (exceeds 25 allowed). Consider refactoring. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
Function xoops_module_deactivate
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method xoops_module_list
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
Method xoops_module_deactivate
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
Avoid deeply nested control flow statements. Open
if ($template != '') {
$tplfile = &$tplfile_handler->find('default', 'block', $fblock['bid']);
if (count($tplfile) == 0) {
$tplfile_new = &$tplfile_handler->create();
$tplfile_new->setVar('tpl_module', $dirname);
Avoid deeply nested control flow statements. Open
for ($k = 0; $k < $btcount; $k++ ) {
if (!$tplfile_handler->delete($tplfiles[$k])) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_BLOCK_TMPLT_DELETE_FAILED . '</span>', '<strong>' . $tplfiles[$k]->getVar('tpl_file') . '</strong>', '<strong>' . $tplfiles[$k]->getVar('tpl_id') . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_TMPLT_DELETED, '<strong>' . $tplfiles[$k]->getVar('tpl_file') . '</strong>', '<strong>' . $tplfiles[$k]->getVar('tpl_id') . '</strong>');
Avoid deeply nested control flow statements. Open
for ($j = 0; $j < $btcount; $j++ ) {
if (!$tplfile_handler->delete($templates[$j])) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_BLOCK_TMPLT_DELETE_FAILED . '</span>', $templates[$j]->getVar('tpl_file'), '<strong>' . icms_conv_nr2local($templates[$j]->getVar('tpl_id')) . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_TMPLT_DELETED, '<strong>' . $templates[$j]->getVar('tpl_file') . '</strong>', '<strong>' . icms_conv_nr2local($templates[$j]->getVar('tpl_id')) . '</strong>');
Avoid deeply nested control flow statements. Open
if ($template != '') {
$tplfile = &$tplfile_handler->create();
$tplfile->setVar('tpl_module', $dirname);
$tplfile->setVar('tpl_refid', (int) $newbid);
$tplfile->setVar('tpl_source', $content, TRUE);
Avoid deeply nested control flow statements. Open
if (empty($newbid)) {
$newbid = icms::$xoopsDB->getInsertId();
}
Avoid too many return
statements within this method. Open
return $ret;
Avoid too many return
statements within this method. Open
return "<p>" . sprintf(_MD_AM_OKDEACT, "<strong>" . $module->getVar('name') . "</strong>") . "</p>";
Avoid too many return
statements within this method. Open
return $ret . "</p>";
Function xoops_module_gettemplate
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function &xoops_module_gettemplate($dirname, $template, $block = FALSE) {
global $icmsConfig;
$ret = '';
if ($block) {
$path = ICMS_MODULES_PATH . '/' . $dirname . '/templates/blocks/' . $template;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The function xoops_module_uninstall() has an NPath complexity of 55738402. The configured NPath complexity threshold is 200. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function xoops_module_install() has 446 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Exclude checks
The function xoops_module_install() has an NPath complexity of 44504793529867. The configured NPath complexity threshold is 200. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function xoops_module_uninstall() has 239 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Exclude checks
The function icms_module_update() has an NPath complexity of 296980739269635. The configured NPath complexity threshold is 200. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The function icms_module_update() has 454 lines of code. Current threshold is set to 100. Avoid really long methods. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Exclude checks
The function xoops_module_deactivate() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function icms_module_update() has a Cyclomatic Complexity of 92. The configured cyclomatic complexity threshold is 10. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function xoops_module_uninstall() has a Cyclomatic Complexity of 46. The configured cyclomatic complexity threshold is 10. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function xoops_module_install() has a Cyclomatic Complexity of 79. The configured cyclomatic complexity threshold is 10. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$criteria' which will lead to PHP notices. Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$taskData' which will lead to PHP notices. Open
unset($atasks_handler, $criteria, $taskData);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
if (isset($config_old[$config['name']]['value']) && $config_old[$config['name']]['formtype'] == $config['formtype'] && $config_old[$config['name']]['valuetype'] == $config['valuetype']) {
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
if (is_array($config_old[$config['name']]['value'])) {
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
$confobj->setVar('conf_value', serialize($config_old[$config['name']]['value']), TRUE);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$items' which will lead to PHP notices. Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
$config_old[$configs[$i]->getvar('conf_name')]['value'] = $configs[$i]->getvar('conf_value', 'N');
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
$config_old[$configs[$i]->getvar('conf_name')]['formtype'] = $configs[$i]->getvar('conf_formtype');
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
if (isset($config_old[$config['name']]['value']) && $config_old[$config['name']]['formtype'] == $config['formtype'] && $config_old[$config['name']]['valuetype'] == $config['valuetype']) {
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$items' which will lead to PHP notices. Open
unset($atasks, $atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
if (isset($config_old[$config['name']]['value']) && $config_old[$config['name']]['formtype'] == $config['formtype'] && $config_old[$config['name']]['valuetype'] == $config['valuetype']) {
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
$confobj->setVar('conf_value', $config_old[$config['name']]['value'], TRUE);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$config_old' which will lead to PHP notices. Open
$config_old[$configs[$i]->getvar('conf_name')]['valuetype'] = $configs[$i]->getvar('conf_valuetype');
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '154', column '36'). Open
if ($module_handler->getCount(new icms_db_criteria_Item('dirname', $dirname)) == 0) {
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '797', column '24'). Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '662', column '19'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('page_moduleid', $module->getVar('mid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '662', column '46'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('page_moduleid', $module->getVar('mid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '777', column '49'). Open
$configs = &$config_handler->getConfigs(new icms_db_criteria_Item('conf_modid', $module->getVar('mid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '796', column '21'). Open
$criteria = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method xoops_module_gettemplate has a boolean flag argument $block, which is a certain sign of a Single Responsibility Principle violation. Open
function &xoops_module_gettemplate($dirname, $template, $block = FALSE) {
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Missing class import via use statement (line '971', column '15'). Open
$table = new icms_db_legacy_updater_Table("modules");
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1329', column '23'). Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '987', column '23'). Open
$xoopsDelTpl = new icms_view_Tpl();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1196', column '47'). Open
$configs = &$config_handler->getConfigs(new icms_db_criteria_Item('conf_modid', $module->getVar('mid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '1328', column '20'). Open
$criteria = new icms_db_criteria_Compo();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$config_handler = icms::handler('icms_config');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$groups = array(XOOPS_GROUP_ADMIN);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$notification_handler = icms::handler('icms_data_notification');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_CONFIG_ADD_FAIL . '</span>', '<strong>' . $config['name'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid assigning values to variables in if clauses and the like (line '528', column '12'). Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newmid = $module->getVar('mid');
unset($created_tables);
$msgs[] = sprintf(_MD_AM_MOD_DATA_INSERT_SUCCESS, '<strong>' . icms_conv_nr2local($newmid) . '</strong>');
$tplfile_handler = &icms::handler('icms_view_template_file');
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newtplid = $tplfile->getVar('tpl_id');
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_INSERTED, '<strong>' . $tpl['file'] . '</strong>', '<strong>' . $newtplid . '</strong>');
// generate compiled file
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$template = trim($block['template']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($module->getVar('hascomments') != 0) {
include_once ICMS_INCLUDE_PATH . '/comment_constants.php';
$configs[] = array('name' => 'com_rule',
'title' => '_CM_COMRULES',
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_db_legacy_Factory' in method 'xoops_module_install'. Open
$icmsDatabaseUpdater = icms_db_legacy_Factory::getDatabaseUpdater();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs = array();
$member_handler = icms::handler('icms_member');
$grps = $member_handler->getGroupList();
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_SYMLINK_DELETED, '<strong>' . $page->getVar('page_title') . '</strong>', '<strong>' . $page->getVar('page_id') . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = ' ' . _MD_AM_COMMENT_DELETED;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return "<p>" . sprintf(_MD_AM_FAILINS, "<strong>" . $dirname . "</strong>") . " " . _MD_AM_ERRORSC . "<br /> " . sprintf(_MD_AM_ALEXISTS, $dirname) . "</p>";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_CONFIGOPTION_DELETED, '<strong>' . icms_conv_nr2local($configs[$i]->getVar('conf_id')) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_db_legacy_mysql_Utility' in method 'xoops_module_install'. Open
icms_db_legacy_mysql_Utility::splitSqlFile($pieces, $sql_query);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (!in_array($prefixed_query[4], $created_tables)) {
$msgs[] = sprintf(' ' . _MD_AM_TABLE_CREATED, '<strong>' . $db->prefix($prefixed_query[4]) . '</strong>');
$created_tables[] = $prefixed_query[4];
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// the table name is reserved, so halt the installation
$errs[] = sprintf(_MD_AM_RESERVED_TABLE, '<strong>' . $prefixed_query[4] . '</strong>');
$error = TRUE;
break;
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (empty($newbid)) {
$newbid = $db->getInsertId();
}
$msgs[] = sprintf(_MD_AM_BLOCK_ADDED, '<strong>' . $block['name'] . '</strong>', '<strong>' . icms_conv_nr2local($newbid) . '</strong>');
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
if (is_string($lastmsg)) {
$msgs[] = $lastmsg;
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_DELETED, '<strong>' . icms_conv_nr2local($templates[$i]->getVar('tpl_file')) . '</strong>', '<strong>' . icms_conv_nr2local($templates[$i]->getVar('tpl_id')) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_list'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_deactivate'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$member_handler = icms::handler('icms_member');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_change'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_ADMIN_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_USER_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$icms_block_handler = icms::handler('icms_view_block');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$comment_handler = icms::handler('icms_data_comment');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$urllink_handler = icms::handler('icms_data_urllink');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_db_Factory' in method 'xoops_module_install'. Open
$db = icms_db_Factory::instance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$driver = XOOPS_DB_TYPE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_db_legacy_mysql_Utility' in method 'xoops_module_install'. Open
$prefixed_query = icms_db_legacy_mysql_Utility::prefixQuery($piece, $db->prefix());
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newtplid = $tplfile->getVar('tpl_id');
$msgs[] = sprintf(_MD_AM_TEMPLATE_INSERTED, '<strong>' . $block['template'] . '</strong>', '<strong>' . icms_conv_nr2local($newtplid) . '</strong>');
// generate compiled file
if (!$icmsAdminTpl->template_touch($newtplid)) {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_COMPILED, '<strong>' . $block['template'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid assigning values to variables in if clauses and the like (line '539', column '12'). Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_TMPLT_DELETED, '<strong>' . $templates[$j]->getVar('tpl_file') . '</strong>', '<strong>' . icms_conv_nr2local($templates[$j]->getVar('tpl_id')) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_DATA_INSERT_SUCCESS, '<strong>' . $db->prefix($prefixed_query[4]) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$icms_block_handler = icms::handler('icms_view_block');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_gettemplate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$lines = file($path);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$tplfile_handler = icms::handler('icms_view_template_file');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_DELETED, '<strong>' . $block_arr[$i]->getVar('name') . '</strong>', '<strong>' . icms_conv_nr2local($block_arr[$i]->getVar('bid')) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = ' ' . _MD_AM_GROUPPERM_DELETED;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_deactivate'. Open
$member_handler = icms::handler('icms_member');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_AUTOTASK_ADDED, '<strong>' . $taskData['name'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$ret = '<p> ' . implode('<br /> ', $errs);
unset($msgs, $errs);
$ret .= '<br />' . sprintf(_MD_AM_FAILINS, '<strong>' . $dirname . '</strong>') . ' ' . _MD_AM_ERRORSC . '</p>';
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_gettemplate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$path = ICMS_MODULES_PATH . '/' . $dirname . '/templates/' . $template;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// delete template files
$tplfile_handler = icms::handler('icms_view_template_file');
$templates = &$tplfile_handler->find(NULL, 'module', $module->getVar('mid'));
$tcount = count($templates);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_MOD_TABLE_DELETE_NOTALLOWED . '</span>', '<strong>' . $db->prefix($table) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = ' ' . _MD_AM_NOTIFICATION_DELETED;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_ACCESS_ADDED, '<strong>' . icms_conv_nr2local($blc) . '</strong>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_DataFilter' in method 'xoops_module_change'. Open
return "<p>" . sprintf(_MD_AM_OKORDER, "<strong>" . icms_core_DataFilter::stripSlashesGPC($name) . "</strong>") . "</p>";
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_module_Handler' in method 'xoops_module_list'. Open
$dirlist = icms_module_Handler::getAvailable();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(_MD_AM_SQL_FOUND, '<strong>' . $sql_file_path . '</strong>');
$sql_query = fread(fopen($sql_file_path, 'r'), filesize($sql_file_path));
$sql_query = trim($sql_query);
icms_db_legacy_mysql_Utility::splitSqlFile($pieces, $sql_query);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
if (is_string($lastmsg)) {
$msgs[] = $lastmsg;
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_db_Factory' in method 'xoops_module_uninstall'. Open
$db = &icms_db_Factory::instance();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$config_handler = icms::handler('icms_config');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$file_handler = icms::handler('icms_data_file');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_activate'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'xoops_module_install'. Open
$tplfile_handler = &icms::handler('icms_view_template_file');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_install uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_COMPILED, '<strong>' . $tpl['file'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' <span>' . _MD_AM_TEMPLATE_RECOMPILED . '</span>', '<strong>' . $tpl['file'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_DataFilter' in method 'xoops_module_change'. Open
$ret = "<p>" . sprintf(_MD_AM_FAILORDER, "<strong>" . icms_core_DataFilter::stripSlashesGPC($name) . "</strong>") . " " . _MD_AM_ERRORSC . "<br />";
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_RECOMPILED, '<strong>' . $blocks[$i]['template'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_AUTOTASK_ADDED, '<strong>' . $taskData['name'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'xoops_module_uninstall'. Open
$page_handler = icms::handler('icms_data_page');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method xoops_module_deactivate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$member_handler = icms::handler('icms_member');
$grps = $member_handler->getGroupList();
foreach ($grps as $k => $v) {
$stararr = explode('-', $icmsConfig['startpage'][$k]);
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method xoops_module_uninstall uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_MOD_TABLE_DELETED, '<strong>' . $db->prefix($table) . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_TEMPLATE_DELETE_FAIL . '</span>', $tpl['file']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$notification_handler = icms::handler('icms_data_notification');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newid = $tplfile->getVar('tpl_id');
$msgs[] = sprintf(' <span>' . _MD_AM_TEMPLATE_INSERTED . '</span>', '<strong>' . $tpl['file'] . '</strong>', '<strong>' . $newid . '</strong>');
if ($icmsConfig['template_set'] == 'default') {
if (!$icmsAdminTpl->template_touch($newid)) {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$config_handler = icms::handler('icms_config');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_db_legacy_Factory' in method 'icms_module_update'. Open
$icmsDatabaseUpdater = icms_db_legacy_Factory::getDatabaseUpdater();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$tplfile_handler = &icms::handler('icms_view_template_file');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_UPDATED, '<strong>' . $fblock['name'] . '</strong>', '<strong>' . icms_conv_nr2local($fblock['bid']) . '</strong>');
if ($template != '') {
$tplfile = &$tplfile_handler->find('default', 'block', $fblock['bid']);
if (count($tplfile) == 0) {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_TMPLT_DELETED, '<strong>' . $tplfiles[$k]->getVar('tpl_file') . '</strong>', '<strong>' . $tplfiles[$k]->getVar('tpl_id') . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$config_handler = icms::handler('icms_config');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = $module->messages;
$msgs[] = sprintf(_MD_AM_FUNCT_EXEC, '<strong>' . $func . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$tplfile_new = $tplfile[0];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (empty($newbid)) {
$newbid = icms::$xoopsDB->getInsertId();
}
$groups = &icms::$user->getGroups();
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newid = $tplfile->getVar('tpl_id');
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_INSERTED, '<strong>' . $blocks[$i]['template'] . '</strong>', '<strong>' . $newid . '</strong>');
if ($icmsConfig['template_set'] == 'default') {
if (!$icmsAdminTpl->template_touch($newid)) {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_DELETED, '<strong>' . $block->getVar('name') . '</strong>', '<strong>' . $block->getVar('bid') . '</strong>');
if ($block->getVar('template') != '') {
$tplfiles = &$tplfile_handler->find(NULL, 'block', $block->getVar('bid'));
if (is_array($tplfiles)) {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$newmid = $module->getVar('mid');
$msgs[] = _MD_AM_MOD_DATA_UPDATED;
$tplfile_handler = &icms::handler('icms_view_template_file');
$deltpl = &$tplfile_handler->find('default', 'module', $module->getVar('mid'));
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$config_old[$configs[$i]->getvar('conf_name')]['value'] = $configs[$i]->getvar('conf_value', 'N');
$config_old[$configs[$i]->getvar('conf_name')]['formtype'] = $configs[$i]->getvar('conf_formtype');
$config_old[$configs[$i]->getvar('conf_name')]['valuetype'] = $configs[$i]->getvar('conf_valuetype');
$msgs[] = sprintf(' ' . _MD_AM_CONFIGOPTION_DELETED, '<strong>' . $configs[$i]->getVar('conf_id') . '</strong>');
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_ACCESS_ADDED, '<strong>' . $newbid . '</strong>', '<strong>' . $mygroup . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_UPDATED, '<strong>' . $blocks[$i]['template'] . '</strong>');
if ($icmsConfig['template_set'] == 'default') {
if (!$icmsAdminTpl->template_touch($tplfile_new->getVar('tpl_id'))) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_TEMPLATE_RECOMPILE_FAIL . '</span>', '<strong>' . $blocks[$i]['template'] . '</strong>');
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$icms_block_handler = icms::handler('icms_view_block');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_CONFIG_ADD_FAIL . '</span>', '<strong>' . $config['name'] . '</strong>. ');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'icms_module_update'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$template = $blocks[$i]['template'];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($module->getVar('hascomments') != 0) {
include_once ICMS_INCLUDE_PATH . '/comment_constants.php';
$configs[] = array('name' => 'com_rule',
'title' => '_CM_COMRULES',
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$tplfile->setVar('tpl_type', 'module');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$confobj->setVar('conf_value', $config_old[$config['name']]['value'], TRUE);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$msgs[] = sprintf(' ' . _MD_AM_TEMPLATE_RECOMPILED, '<strong>' . $blocks[$i]['template'] . '</strong>');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method icms_module_update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$confobj->setConfValueForInput($config['default'], TRUE);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsConfig, $icmsAdminTpl;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$criteria'. Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$items'. Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$v'. Open
foreach ($grps as $k => $v) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$taskData'. Open
unset($atasks_handler, $criteria, $taskData);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$v'. Open
foreach ($grps as $k => $v) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsAdminTpl, $icmsConfig;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsConfig;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$items'. Open
unset($atasks, $atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
FIXME found Open
// FIXME: doesn't work when update module... can't read back the array of options properly... " changing to "
- Exclude checks
FIXME found Open
// FIXME: for some reason the default doesn't come up properly
- Exclude checks
Variable $pieces
is undeclared (Did you mean $piece) Open
foreach ($pieces as $piece) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$tplfile_handler = &icms::handler('icms_view_template_file');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' ' . _MD_AM_ADMIN_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
if ($module_handler->getCount(new icms_db_criteria_Item('dirname', $dirname)) == 0) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$notification_handler = icms::handler('icms_data_notification');
- Exclude checks
Reference to undeclared constant \_AUTHOR
Open
$msgs[] = '<strong>' . _AUTHOR . ':</strong> ' . trim($module->getInfo('author'));
- Exclude checks
Call to method splitSqlFile
from undeclared class \icms_db_legacy_mysql_Utility
Open
icms_db_legacy_mysql_Utility::splitSqlFile($pieces, $sql_query);
- Exclude checks
Suspicious array access to ?mixed
Open
$task->setVar('sat_name', $taskData['name']);
- Exclude checks
Suspicious array access to ?mixed
Open
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_AUTOTASK_FAIL . '</span>', '<strong>' . $taskData['name'] . '</strong>');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$comment_handler = icms::handler('icms_data_comment');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$configs = &$config_handler->getConfigs(new icms_db_criteria_Item('conf_modid', $module->getVar('mid')));
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$result = icms::$xoopsDB->query($sql);
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_ADMIN_PERM_ADD_FAIL . '</span>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Function xoops_module_install
defined at /code/htdocs/modules/system/admin/modulesadmin/modulesadmin.php:120
was previously defined at /code/htdocs/install/modulesadmin.php:22
Open
function xoops_module_install($dirname) {
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$newbid = icms::$xoopsDB->genId(icms::$xoopsDB->prefix('newblocks') . '_bid_seq');
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_BLOCK_ACCESS_FAIL . '</span>', '<strong>' . icms_conv_nr2local($blc) . '</strong>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$groups = &icms::$user->getGroups();
- Exclude checks
Call to method getDatabaseUpdater
from undeclared class \icms_db_legacy_Factory
Open
$icmsDatabaseUpdater = icms_db_legacy_Factory::getDatabaseUpdater();
- Exclude checks
Call to method instance
from undeclared class \icms_db_Factory
Open
$db = &icms_db_Factory::instance();
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$config_handler = icms::handler('icms_config');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$config_handler = icms::handler('icms_config');
- Exclude checks
Variable $criteria
is undeclared Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$sql = "INSERT INTO " . icms::$xoopsDB->prefix("newblocks") . " (bid, mid, func_num, options, name, title, content, side, weight, visible, block_type, c_type, isactive, dirname, func_file, show_func, edit_func, template, bcachetime, last_modified) VALUES ('" . (int) $newbid . "', '" . (int) $module->getVar('mid') . "', '" . (int) $i . "', '" . addslashes($options) . "', '" . $block_name . "', '" . $block_name . "', '', '1', '0', '0', 'M', 'H', '1', '" . addslashes($dirname) . "', '" . addslashes($blocks[$i]['file']) . "', '" . addslashes($blocks[$i]['show_func']) . "', '" . addslashes($editfunc) . "', '" . $template . "', '0', '" . time() . "')";
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$newbid = icms::$xoopsDB->getInsertId();
- Exclude checks
Parameter $dirname
has undeclared type \unknown_type
Open
function xoops_module_uninstall($dirname) {
- Exclude checks
Variable $taskData
is undeclared Open
unset($atasks_handler, $criteria, $taskData);
- Exclude checks
Call to method clear_cache
from undeclared class \icms_view_Tpl
Open
$xoopsDelTpl->clear_cache(NULL, 'mod_' . $dirname);
- Exclude checks
Suspicious array access to ?mixed
Open
$msgs[] = sprintf(' ' . _MD_AM_AUTOTASK_ADDED, '<strong>' . $taskData['name'] . '</strong>');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$page_handler = icms::handler('icms_data_page');
- Exclude checks
Function icms_module_update
defined at /code/htdocs/modules/system/admin/modulesadmin/modulesadmin.php:944
was previously defined at /code/htdocs/install/modulesadmin.php:475
Open
function icms_module_update($dirname) {
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$result = icms::$xoopsDB->query($sql);
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$sql = sprintf("DELETE FROM %s WHERE bid = '%u'", icms::$xoopsDB->prefix('newblocks'), (int) $block->getVar('bid'));
- Exclude checks
Suspicious array access to false
Open
$configs[] = array('name' => 'com_rule',
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Suspicious array access to false
Open
$configs[] = array('name' => 'com_rule',
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$icms_block_handler = icms::handler('icms_view_block');
- Exclude checks
Variable $items
is undeclared Open
unset($atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$icms_block_handler = icms::handler('icms_view_block');
- Exclude checks
Suspicious type \unknown_type
of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
include_once ICMS_MODULES_PATH . '/' . $dirname . '/' . trim($uninstall_script);
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$notification_handler = icms::handler('icms_data_notification');
- Exclude checks
Function xoops_module_gettemplate
defined at /code/htdocs/modules/system/admin/modulesadmin/modulesadmin.php:573
was previously defined at /code/htdocs/install/modulesadmin.php:453
Open
function &xoops_module_gettemplate($dirname, $template, $block = FALSE) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Parameter $name
has undeclared type \str
Open
function xoops_module_change($mid, $weight, $name) {
- Exclude checks
Argument 1 (str)
is \str
but \trim()
takes string
Open
$dirname = trim($dirname);
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
- Exclude checks
Reference to undeclared constant \_INFO
Open
$icmsAdminTpl->assign('lang_info', _INFO);
- Exclude checks
Return type of icms_module_update()
is undeclared type \str
Open
function icms_module_update($dirname) {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_legacy_updater_Table
Open
$table = new icms_db_legacy_updater_Table("modules");
- Exclude checks
Call to method __construct
from undeclared class \icms_view_Tpl
Open
$xoopsDelTpl = new icms_view_Tpl();
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$fresult = icms::$xoopsDB->query($sql);
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$sql = "UPDATE " . icms::$xoopsDB->prefix("newblocks") . " SET name='" . addslashes($blocks[$i]['name']) . "', edit_func='" . addslashes($editfunc) . "', content='', template='" . $template . "', last_modified=" . time() . " WHERE bid='" . (int) $fblock['bid'] . "'";
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$sql = "INSERT INTO " . icms::$xoopsDB->prefix('block_module_link') . " (block_id, module_id, page_id) VALUES ('" . (int) $newbid . "', '0', '1')";
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$config_handler = icms::handler('icms_config');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Exclude checks
Variable $items
is undeclared Open
unset($atasks, $atasks_handler, $task, $taskData, $criteria, $items, $taskID);
- Exclude checks
Call to method getAvailable
from undeclared class \icms_module_Handler
Open
$dirlist = icms_module_Handler::getAvailable();
- Exclude checks
Reference to undeclared constant \_VERSION
(Did you mean $_SESSION) Open
$msgs[] = '<strong>' . _VERSION . ':</strong> ' . $module->getVar('version');
- Exclude checks
Call to method prefixQuery
from undeclared class \icms_db_legacy_mysql_Utility
Open
$prefixed_query = icms_db_legacy_mysql_Utility::prefixQuery($piece, $db->prefix());
- Exclude checks
Parameter $dirname
has undeclared type \str
Open
function icms_module_update($dirname) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method fieldExists
from undeclared class \icms_db_legacy_updater_Table
Open
if (!$table->fieldExists($k)) {
- Exclude checks
Suspicious array access to ?mixed
Open
$task->setVar('sat_code', $taskData['code']);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Exclude checks
Call to method getDatabaseUpdater
from undeclared class \icms_db_legacy_Factory
Open
$icmsDatabaseUpdater = icms_db_legacy_Factory::getDatabaseUpdater();
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method stripSlashesGPC
from undeclared class \icms_core_DataFilter
Open
return "<p>" . sprintf(_MD_AM_OKORDER, "<strong>" . icms_core_DataFilter::stripSlashesGPC($name) . "</strong>") . "</p>";
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$icms_block_handler = icms::handler('icms_view_block');
- Exclude checks
Returning type string
but icms_module_update()
is declared to return \str
Open
return $ret;
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$urllink_handler = icms::handler('icms_data_urllink');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$member_handler = icms::handler('icms_member');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method stripSlashesGPC
from undeclared class \icms_core_DataFilter
Open
$ret = "<p>" . sprintf(_MD_AM_FAILORDER, "<strong>" . icms_core_DataFilter::stripSlashesGPC($name) . "</strong>") . " " . _MD_AM_ERRORSC . "<br />";
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('page_moduleid', $module->getVar('mid')));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$config_handler = icms::handler('icms_config');
- Exclude checks
Variable $config_old
was undeclared, but array fields are being added to it. Open
$config_old[$configs[$i]->getvar('conf_name')]['value'] = $configs[$i]->getvar('conf_value', 'N');
- Exclude checks
Call to method instance
from undeclared class \icms_db_Factory
Open
$db = icms_db_Factory::instance();
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$member_handler = icms::handler('icms_member');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$configs = &$config_handler->getConfigs(new icms_db_criteria_Item('conf_modid', $module->getVar('mid')));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$tplfile_handler = &icms::handler('icms_view_template_file');
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
icms::$xoopsDB->query($sql);
- Exclude checks
Variable $icmsModule
is undeclared Open
if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar('mid'))) {
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' ' . _MD_AM_BLOCK_ACCESS_ADDED, '<strong>' . icms_conv_nr2local($blc) . '</strong>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('page_moduleid', $module->getVar('mid')));
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
while ($fblock = icms::$xoopsDB->fetchArray($fresult)) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$gperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
if (!icms::$xoopsDB->query($sql)) {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo();
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' ' . _MD_AM_USER_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo();
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Exclude checks
Argument 1 (string)
is '1'|'2'|'3'
but \icms_conv_nr2local()
takes int
defined at /code/htdocs/include/functions.php:1231
Open
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_USER_PERM_ADD_FAIL . '</span>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$tplfile_handler = icms::handler('icms_view_template_file');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('sat_type', 'addon/' . $module->getInfo('dirname')));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$file_handler = icms::handler('icms_data_file');
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$sql = "SELECT bid, name FROM " . icms::$xoopsDB->prefix('newblocks') . " WHERE mid='" . (int) $module->getVar('mid') . "' AND func_num='" . (int) $i . "' AND show_func='" . addslashes($blocks[$i]['show_func']) . "' AND func_file='" . addslashes($blocks[$i]['file']) . "'";
- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($module->getVar('hasnotification') != 0) {
if (empty($configs)) {
$configs = array();
}
// Main notification options
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 341.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($module->getVar('hasnotification') != 0) {
if (empty($configs)) {
$configs = array();
}
// Main notification options
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 341.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
$sql = "INSERT INTO " . $db->prefix("newblocks") . " (bid, mid, func_num, options, name, title, content, side, weight, visible, block_type, c_type, isactive, dirname, func_file, show_func, edit_func, template, bcachetime, last_modified) VALUES ('" . (int) $newbid . "', '" . (int) $newmid . "', '" . (int) $blockkey . "', '$options', '" . $block_name . "', '" . $block_name . "', '', '1', '0', '0', 'M', 'H', '1', '" . addslashes($dirname) . "', '" . addslashes(trim($block['file'])) . "', '" . addslashes(trim($block['show_func'])) . "', '" . addslashes($edit_func) . "', '" . $template . "', '0', '" . time() . "')";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 173.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($configs !== FALSE) {
if ($module->getVar('hascomments') != 0) {
include_once ICMS_INCLUDE_PATH . '/comment_constants.php';
array_push($configs, array('name' => 'com_rule',
'title' => '_CM_COMRULES',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 148.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($configs !== FALSE) {
if ($module->getVar('hascomments') != 0) {
include_once ICMS_INCLUDE_PATH . '/comment_constants.php';
$configs[] = array('name' => 'com_rule',
'title' => '_CM_COMRULES',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 148.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (isset($config['options']) && is_array($config['options'])) {
foreach ($config['options'] as $key => $value) {
$confop = &$config_handler->createConfigOption();
$confop->setVar('confop_name', $key, TRUE);
$confop->setVar('confop_value', $value, TRUE);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 139.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (isset($config['options']) && is_array($config['options'])) {
foreach ($config['options'] as $key => $value) {
$confop = &$config_handler->createConfigOption();
$confop->setVar('confop_name', $key, TRUE);
$confop->setVar('confop_value', $value, TRUE);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 139.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
foreach ($grps as $k => $v) {
$stararr = explode('-', $icmsConfig['startpage'][$k]);
if (count($stararr) > 0) {
if ($module->getVar('mid') == $stararr[0]) {
return "<p>" . sprintf(_MD_AM_FAILDEACT, "<strong>" . $module->getVar('name') . "</strong>") . " " . _MD_AM_ERRORSC . "<br /> - " . _MD_AM_STRTNO . "</p>";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 128.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
foreach ($grps as $k => $v) {
$stararr = explode('-', $icmsConfig['startpage'][$k]);
if (count($stararr) > 0) {
if ($module->getVar('mid') == $stararr[0]) {
return "<p>" . sprintf(_MD_AM_FAILDEACT, "<strong>" . $module->getVar('name') . "</strong>") . " " . _MD_AM_ERRORSC . "<br /> - " . _MD_AM_STRTNO . "</p>";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 128.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (function_exists('xoops_module_install_' . $ModName)) {
$func = 'xoops_module_install_' . $ModName;
if (!($lastmsg = $func($module))) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 124.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} elseif (function_exists('icms_module_install_' . $ModName)) {
$func = 'icms_module_install_' . $ModName;
if (!($lastmsg = $func($module))) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 124.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (count($tplfile) == 0) {
$tplfile_new = &$tplfile_handler->create();
$tplfile_new->setVar('tpl_module', $dirname);
$tplfile_new->setVar('tpl_refid', (int) $fblock['bid']);
$tplfile_new->setVar('tpl_tplset', 'default');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 120.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (is_array($deltpl)) {
$xoopsDelTpl = new icms_view_Tpl();
// clear cache files
$xoopsDelTpl->clear_cache(NULL, 'mod_' . $dirname);
// delete template file entry in db
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 110.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (function_exists('xoops_module_update_' . $ModName)) {
$func = 'xoops_module_update_' . $ModName;
if (!$func($module, $prev_version, $prev_dbversion)) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} elseif (function_exists('icms_module_update_' . $ModName)) {
$func = 'icms_module_update_' . $ModName;
if (!$func($module, $prev_version, $prev_dbversion)) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
foreach ($items_atasks as $task) {
$taskID = (int) $task->getVar('sat_addon_id');
$atasks[$taskID]['enabled'] = $task->getVar('sat_enabled');
$atasks[$taskID]['repeat'] = $task->getVar('sat_repeat');
$atasks[$taskID]['interval'] = $task->getVar('sat_interval');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!$gperm_handler->insert($mperm)) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_ADMIN_PERM_ADD_FAIL . '</span>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_ADMIN_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!$gperm_handler->insert($mperm)) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_USER_PERM_ADD_FAIL . '</span>', '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_USER_PERM_ADDED, '<strong>' . icms_conv_nr2local($mygroup) . '</strong>');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} elseif (function_exists('icms_module_uninstall_' . $ModName)) {
$func = 'icms_module_uninstall_' . $ModName;
if (!$func($module)) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 99.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (function_exists('xoops_module_uninstall_' . $ModName)) {
$func = 'xoops_module_uninstall_' . $ModName;
if (!$func($module)) {
$msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 99.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!($atasks_handler->insert($task))) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_AUTOTASK_FAIL . '</span>', '<strong>' . $taskData['name'] . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_AUTOTASK_ADDED, '<strong>' . $taskData['name'] . '</strong>');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 96.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!($atasks_handler->insert($task))) {
$msgs[] = sprintf(' <span style="color:#ff0000;">' . _MD_AM_AUTOTASK_FAIL . '</span>', '<strong>' . $taskData['name'] . '</strong>');
} else {
$msgs[] = sprintf(' ' . _MD_AM_AUTOTASK_ADDED, '<strong>' . $taskData['name'] . '</strong>');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 96.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 5 locations. Consider refactoring. Open
$reservedTables = array('avatar',
'avatar_users_link',
'block_module_link',
'xoopscomments',
'config',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 5 locations. Consider refactoring. Open
$reservedTables = array('avatar',
'avatar_users_link',
'block_module_link',
'xoopscomments',
'config',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid variables with short names like $db. Configured minimum length is 3. Open
$db = icms_db_Factory::instance();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $db. Configured minimum length is 3. Open
$db = &icms_db_Factory::instance();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($k = 0; $k < $btcount; $k++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_title', $config['title'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$error = TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_desc', isset($block['description']) ? $block['description'] : '', TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$templates = &$tplfile_handler->find(NULL, 'module', $module->getVar('mid'));
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_desc', $config['description'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confop->setVar('confop_name', $key, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$error = FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_source', $content, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($configs !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
function &xoops_module_gettemplate($dirname, $template, $block = FALSE) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile_new->setVar('tpl_source', $content, TRUE);
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $confcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($configs !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_value', $config_old[$config['name']]['value'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$icmsDatabaseUpdater->moduleUpgrade($module, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$xoopsDelTpl->clear_cache(NULL, 'mod_' . $dirname);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (!$module->loadInfo($file, FALSE)) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$error = TRUE;
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($k = 0; $k < $btcount; $k++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE !== $update_script && trim($update_script) != '') {
- Exclude checks
Blank line found at start of control structure Open
} else {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_desc', $tpl['description'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_source', $tpldata, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_file', $tpl['file'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($templates !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_source', $tpldata, TRUE);
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$blocks[$i]->setVar('isactive', FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile_new->setVar('tpl_desc', $blocks[$i]['description'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
if ($error === TRUE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$blocks = &$icms_block_handler->getByModule($newmid, FALSE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$icmsDatabaseUpdater->moduleUpgrade($module, TRUE);
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($j = 0; $j < $btcount; $j++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE !== $uninstall_script && trim($uninstall_script) != '') {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($blocks !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$content = &xoops_module_gettemplate($dirname, $blocks[$i]['template'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$error = TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$templates = &$tplfile_handler->find(NULL, 'block', $block_arr[$i]->getVar('bid'));
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $dcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($blocks !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confop->setVar('confop_value', $value, TRUE);
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile_new->setVar('tpl_file', $blocks[$i]['template'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_desc', $blocks[$i]['description'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setConfValueForInput($config['default'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($module->getInfo('image') !== FALSE && trim($module->getInfo('image')) != '') {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_desc', $config['description'], TRUE);
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $tcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($modtables !== FALSE && is_array($modtables)) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $confcount; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 1; $i <= $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_source', $content, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$tplfiles = &$tplfile_handler->find(NULL, 'block', $block->getVar('bid'));
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $confcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($configs !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$events = &$notification_handler->categoryEvents($category['name'], FALSE, $module->getVar('mid'));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$module->registerClassPath(FALSE);
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 1; $i <= $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($module->getInfo('author') !== FALSE && trim($module->getInfo('author')) != '') {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($sqlfile !== FALSE && is_array($sqlfile)) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$content = &xoops_module_gettemplate($dirname, $block['template'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setConfValueForInput($config['default'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($config_handler->insertConfig($confobj) !== FALSE) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $confcount; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $dcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($templates !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_desc', $tpl['description'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$tplfile->setVar('tpl_file', $blocks[$i]['template'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($error === FALSE) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $bcount; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confop->setVar('confop_name', $key, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE !== $install_script && trim($install_script) != '') {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $tcount; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($j = 0; $j < $btcount; $j++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_value', serialize($config_old[$config['name']]['value']), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$error = TRUE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if ($configs !== FALSE) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$events = &$notification_handler->categoryEvents($category['name'], FALSE, $module->getVar('mid'));
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confobj->setVar('conf_title', $config['title'], TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$confop->setVar('confop_value', $value, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE !== $config_handler->insertConfig($confobj)) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$items_atasks = $atasks_handler->getObjects($criteria, FALSE);
- Exclude checks
Expected 1 blank line at end of file; 2 found Open
}
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['repeat'])) $task->setVar('sat_repeat', $taskData['repeat']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['interval'])) $task->setVar('sat_interval', $taskData['interval']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['onfinish'])) $task->setVar('sat_onfinish', $taskData['onfinish']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['interval'])) $task->setVar('sat_interval', $taskData['interval']);
- Exclude checks
Inline control structures are not allowed Open
if (!isset($taskData['code']) || trim($taskData['code']) == '') continue;
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['enabled'])) $task->setVar('sat_enabled', $taskData['enabled']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['onfinish'])) $task->setVar('sat_onfinish', $taskData['onfinish']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['repeat'])) $task->setVar('sat_repeat', $taskData['repeat']);
- Exclude checks
Inline control structures are not allowed Open
if (isset($taskData['enabled'])) $task->setVar('sat_enabled', $taskData['enabled']);
- Exclude checks
Line indented incorrectly; expected at least 1 tabs, found 0 Open
);
- Exclude checks
Line indented incorrectly; expected at least 1 tabs, found 0 Open
);
- Exclude checks
The variable $module_handler is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $page_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $listed_mods is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $uninstall_script is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $install_script is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $install_script is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_change($mid, $weight, $name) {
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$module->setVar('weight', $weight);
$module->setVar('name', $name);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $installed_mods is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $listed_mods is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $edit_func is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $urllink_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_delng is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $uninstall_script is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $listed_mods is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $install_script is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_name is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_name is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_IPF is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_dbversion is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_value is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $update_script is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_value is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_dbversion is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $page_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $edit_func is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_value is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $urllink_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $uninstall_script is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $uninstall_script is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_change($mid, $weight, $name) {
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$module->setVar('weight', $weight);
$module->setVar('name', $name);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $file_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_page_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_delng is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_dbversion is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_file_path is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $page_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $temp_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $sql_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prefixed_query is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_IPF is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $installed_mods is not named in camelCase. Open
function xoops_module_list() {
global $icmsAdminTpl, $icmsConfig;
$icmsAdminTpl->assign('lang_madmin', _MD_AM_MODADMIN);
$icmsAdminTpl->assign('lang_module', _MD_AM_MODULE);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $created_tables is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $install_script is not named in camelCase. Open
function xoops_module_install($dirname) {
global $icmsConfig, $icmsAdminTpl;
$dirname = trim($dirname);
$db = icms_db_Factory::instance();
$reservedTables = array('avatar',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_change($mid, $weight, $name) {
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$module->setVar('weight', $weight);
$module->setVar('name', $name);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $page_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $file_handler is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $temp_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $block_arr is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_version is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_activate($mid) {
global $icms_block_handler, $icmsAdminTpl;
$module_handler = icms::handler('icms_module');
$module = &$module_handler->get($mid);
$icmsAdminTpl->template_clear_module_cache($module->getVar('mid'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_page_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_name is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $update_script is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function xoops_module_uninstall($dirname) {
global $icmsConfig, $icmsAdminTpl;
$reservedTables = array('avatar',
'avatar_users_link',
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_page_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $icms_block_handler is not named in camelCase. Open
function xoops_module_deactivate($mid) {
global $icms_page_handler, $icms_block_handler, $icmsConfig, $icmsAdminTpl;
if (!isset($icms_page_handler)) {
$icms_page_handler = icms_getModuleHandler('pages', 'system');
}
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_version is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $tplfile_new is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_delng is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $option_value is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $items_atasks is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $update_script is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $config_old is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $items_atasks is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $atasks_handler is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $update_script is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_version is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $confop_msgs is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_IPF is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_IPF is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $ModName is not named in camelCase. Open
function icms_module_update($dirname) {
global $icmsConfig, $icmsAdminTpl;
$msgs = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}