ImpressCMS/impresscms

The method editpage has a boolean flag argument $clone, which is a certain sign of a Single Responsibility Principle violation.

Open

function editpage($page_id = 0, $clone = FALSE) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method editpage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

    } else {
        $pageObj->setVar('page_type', 'C');
        $sform = $pageObj->getForm (_AM_SYSTEM_PAGES_CREATE, 'addpage');
        $sform->assign ($icmsAdminTpl);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Variable $icmsModule is undeclared

Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar("mid"))) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_moduleid', 'center', FALSE, 'getCustomPageModuleid'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_Controller

Open

            $controller = new icms_ipf_Controller ($icms_page_handler);

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Table

Open

            $objectTable = new icms_ipf_view_Table($icms_page_handler);

• Exclude checks
  • Disable engine
  • Disable check

Saw an @param annotation for post_id, but it was not found in the param list of function editpage(int|mixed $page_id = 0, mixed $clone = null);

Open

 * @param int $post_id Postid to be edited

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_status', 'center', FALSE, 'getCustomPageStatus'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_title', _GLOBAL_LEFT, FALSE, 'getAdminViewItemLink'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_view_Column

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_url'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addIntroButton from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addIntroButton('addpost', 'admin.php?fct=pages&op=mod', _AM_SYSTEM_PAGES_CREATE);

• Exclude checks
  • Disable engine
  • Disable check

Call to method fetch from undeclared class \icms_ipf_view_Table

Open

            $icmsAdminTpl->assign('icms_page_table', $objectTable->fetch());

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->display('db:system_adm_pagemanager_index.html');

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_url'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addCustomAction from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addCustomAction('getViewItemLink');

• Exclude checks
  • Disable engine
  • Disable check

Reference to static property user from undeclared class \icms

Open

if (!is_object(icms::$user) || !is_object($icmsModule) || !icms::$user->isAdmin($icmsModule->getVar("mid"))) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method addQuickSearch from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addQuickSearch(array ('page_title', 'page_url'));

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->assign('icms_page_table', $objectTable->fetch());

• Exclude checks
  • Disable engine
  • Disable check

Variable $icmsAdminTpl is undeclared

Open

            $icmsAdminTpl->assign('icms_page_title', _AM_SYSTEM_PAGES_TITLE);

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_status', 'center', FALSE, 'getCustomPageStatus'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_moduleid', 'center', FALSE, 'getCustomPageModuleid'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method __construct from undeclared class \icms_ipf_Controller

Open

            $controller = new icms_ipf_Controller($icms_page_handler);

• Exclude checks
  • Disable engine
  • Disable check

Call to method storeFromDefaultForm from undeclared class \icms_ipf_Controller

Open

            $controller->storeFromDefaultForm(_AM_SYSTEM_PAGES_CREATED, _AM_SYSTEM_PAGES_MODIFIED);

• Exclude checks
  • Disable engine
  • Disable check

Call to method handleObjectDeletion from undeclared class \icms_ipf_Controller

Open

            $controller->handleObjectDeletion();

• Exclude checks
  • Disable engine
  • Disable check

Call to method addColumn from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_title', _GLOBAL_LEFT, FALSE, 'getAdminViewItemLink'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method addFilter from undeclared class \icms_ipf_view_Table

Open

            $objectTable->addFilter('page_moduleid', 'getModulesArray');

• Exclude checks
  • Disable engine
  • Disable check

The parameter $page_id is not named in camelCase.

Open

function editpage($page_id = 0, $clone = FALSE) {
    global $icms_page_handler, $icmsAdminTpl;

    $pageObj = $icms_page_handler->get($page_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

if (in_array($clean_op, $valid_op, TRUE)) {

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case "mod" :

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case "changedField" :

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case "clone" :

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case "del" :

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a DEFAULT statement

Open

        default :

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

function editpage($page_id = 0, $clone = FALSE) {

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"

Open

            editpage($clean_page_id, TRUE);

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case "addpage" :

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at end of control structure

Open

• Exclude checks
  • Disable engine
  • Disable check

There must be no space before the colon in a CASE statement

Open

        case 'status' :

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_moduleid', 'center', FALSE, 'getCustomPageModuleid'));

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at end of control structure

Open

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_title', _GLOBAL_LEFT, FALSE, 'getAdminViewItemLink'));

• Exclude checks
  • Disable engine
  • Disable check

TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"

Open

            $objectTable->addColumn(new icms_ipf_view_Column('page_status', 'center', FALSE, 'getCustomPageStatus'));

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

if (isset($_POST ['op']))

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

if (isset($_GET['op']))

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

        $sform->assign ($icmsAdminTpl);

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

            icms_cp_header ();

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

            icms_cp_header ();

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

            $controller = new icms_ipf_Controller ($icms_page_handler);

• Exclude checks
  • Disable engine
  • Disable check

Space after opening parenthesis of function call prohibited

Open

            $icms_page_handler->changeStatus( $clean_page_id );

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

        $sform->assign ($icmsAdminTpl);

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

    exit ("Access Denied");

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

        $sform = $pageObj->getForm (_AM_SYSTEM_PAGES_CREATE, 'addpage');

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 newline at end of file; 0 found

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Expected 0 spaces before closing bracket; 1 found

Open

            $icms_page_handler->changeStatus( $clean_page_id );

• Exclude checks
  • Disable engine
  • Disable check

Space before opening parenthesis of function call prohibited

Open

        $sform = $pageObj->getForm (_AM_SYSTEM_PAGES_EDIT, 'addpage');

• Exclude checks
  • Disable engine
  • Disable check

The variable $icms_page_handler is not named in camelCase.

Open

function editpage($page_id = 0, $clone = FALSE) {
    global $icms_page_handler, $icmsAdminTpl;

    $pageObj = $icms_page_handler->get($page_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $page_id is not named in camelCase.

Open

function editpage($page_id = 0, $clone = FALSE) {
    global $icms_page_handler, $icmsAdminTpl;

    $pageObj = $icms_page_handler->get($page_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $icms_page_handler is not named in camelCase.

Open

function editpage($page_id = 0, $clone = FALSE) {
    global $icms_page_handler, $icmsAdminTpl;

    $pageObj = $icms_page_handler->get($page_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $page_id is not named in camelCase.

Open

function editpage($page_id = 0, $clone = FALSE) {
    global $icms_page_handler, $icmsAdminTpl;

    $pageObj = $icms_page_handler->get($page_id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}