ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/blocks/system_admin_blocks.php

Summary

Maintainability
D
2 days
Test Coverage

Function b_system_admin_modules_show has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

function b_system_admin_modules_show() {
    $block['mods'] = array();
    $module_handler = icms::handler('icms_module');
    $moduleperm_handler = icms::handler('icms_member_groupperm');
    $criteria = new icms_db_criteria_Compo();
Severity: Minor
Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function b_system_admin_warnings_show has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

function b_system_admin_warnings_show() {
    $block = array();
    $block['msg'] = array();

    // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP
Severity: Minor
Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method b_system_admin_warnings_show has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function b_system_admin_warnings_show() {
    $block = array();
    $block['msg'] = array();

    // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP
Severity: Major
Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 2 hrs to fix

    Method b_system_admin_modules_show has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function b_system_admin_modules_show() {
        $block['mods'] = array();
        $module_handler = icms::handler('icms_module');
        $moduleperm_handler = icms::handler('icms_member_groupperm');
        $criteria = new icms_db_criteria_Compo();
    Severity: Major
    Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 2 hrs to fix

      Function b_system_admin_cp_new_show has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function b_system_admin_cp_new_show() {
          global $icmsTpl, $icmsConfig;
      
          $block['lang_cp'] = _CPHOME;
      
      
      Severity: Minor
      Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function b_system_admin_cp_show has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function b_system_admin_cp_show() {
          global $icmsTpl, $icmsConfig;
      
          $block['lang_cp'] = _CPHOME;
          $block['lang_insmodules'] = _AD_INSTALLEDMODULES;
      Severity: Minor
      Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method b_system_admin_cp_new_show has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function b_system_admin_cp_new_show() {
          global $icmsTpl, $icmsConfig;
      
          $block['lang_cp'] = _CPHOME;
      
      
      Severity: Minor
      Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 1 hr to fix

        Method b_system_admin_cp_show has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function b_system_admin_cp_show() {
            global $icmsTpl, $icmsConfig;
        
            $block['lang_cp'] = _CPHOME;
            $block['lang_insmodules'] = _AD_INSTALLEDMODULES;
        Severity: Minor
        Found in htdocs/modules/system/blocks/system_admin_blocks.php - About 1 hr to fix

          The function b_system_admin_warnings_show() has an NPath complexity of 331776. The configured NPath complexity threshold is 200.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The function b_system_admin_modules_show() has an NPath complexity of 10370. The configured NPath complexity threshold is 200.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The function b_system_admin_cp_show() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The function b_system_admin_modules_show() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The function b_system_admin_warnings_show() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The function b_system_admin_cp_new_show() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                  unset($modversion);

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              if (count($block['mods']) > 0) return $block;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                          $sysmod = array('title' => $modversion['name'], 'link' => ICMS_MODULES_URL . '/system/admin.php?fct=' . $file, 'image' => ICMS_MODULES_URL . '/system/admin/' . $file . '/images/' . $file . '_big.png');

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                  if ($modversion['hasAdmin']) {

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              $block['mods'] = array();

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                          $block[$modversion['group']][] = array('title' => $modversion['name'], 'link' => ICMS_MODULES_URL . '/system/admin.php?fct=' . $file, 'image' => ICMS_MODULES_URL . '/system/admin/' . $file . '/images/' . $file . '_big.png');

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                          $block[$modversion['group']][] = array('title' => $modversion['name'], 'link' => ICMS_MODULES_URL . '/system/admin.php?fct=' . $file, 'image' => ICMS_MODULES_URL . '/system/admin/' . $file . '/images/' . $file . '_big.png');

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                  if ($modversion['hasAdmin']) {

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              $block['lang_cp'] = _CPHOME;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              if (count($block['sysmod']) > 0) return $block;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                  unset($modversion);

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              $block['sysmod'] = array();

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

                          array_push($block['sysmod'], $sysmod);

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              if (count($block['sysmod']) > 0) return $block;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

                          $block['mods'][] = $rtn;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$block' which will lead to PHP notices.
          Open

              if (count($block['mods']) > 0) return $block;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Avoid using undefined variables such as '$modversion' which will lead to PHP notices.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UndefinedVariable

          Since: 2.8.0

          Detects when a variable is used that has not been defined before.

          Example

          class Foo
          {
              private function bar()
              {
                  // $message is undefined
                  echo $message;
              }
          }

          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

          Missing class import via use statement (line '177', column '21').
          Open

              $criteria->add(new icms_db_criteria_Item('isactive', 1));

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '81', column '18').
          Open

              $criteria = new icms_db_criteria_Compo();

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '96', column '21').
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'tinymce'));

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '95', column '18').
          Open

              $criteria = new icms_db_criteria_Compo();

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '176', column '21').
          Open

              $criteria->add(new icms_db_criteria_Item('hasadmin', 1));

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '82', column '21').
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'FCKeditor'));

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '78', column '23').
          Open

              $editorhandler = new icms_plugins_EditorHandler();

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '175', column '18').
          Open

              $criteria = new icms_db_criteria_Compo();

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                      array_push($block['msg'], icms_core_Message::error(_FCK_PRESENT_WARNING), '', false);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms' in method 'b_system_admin_cp_show'.
          Open

                  $sysperm_handler = icms::handler('icms_member_groupperm');

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid assigning values to variables in if clauses and the like (line '53', column '6').
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error('<a href="' . ICMS_MODULES_URL . '/system/admin.php?fct=modulesadmin&amp;op=update&amp;module=system">' . _WARNINGUPDATESYSTEM . '</a>'));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_cp_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  $groups = array();
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(_FCK_DEFAULT_WARNING), '', false);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Filesystem' in method 'b_system_admin_cp_show'.
          Open

              $dirlist = icms_core_Filesystem::getDirList($admin_dir);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms' in method 'b_system_admin_modules_show'.
          Open

              $module_handler = icms::handler('icms_module');

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(_CORE_MYSQL_DEPRECATED, '', FALSE));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

              if (!is_writable(ICMS_COMPILE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_COMPILE_PATH)), '', FALSE);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms' in method 'b_system_admin_warnings_show'.
          Open

              $config_handler = icms::handler('icms_config');

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                      array_push($block['msg'], icms_core_Message::error(_TinyMCE_PRESENT_WARNING), '', false);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/upgrade/'), '', FALSE));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_warnings_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  if (in_array('FCKeditor', array_flip($editorhandler->getList()))) {
                      array_push($block['msg'], icms_core_Message::error(_FCK_PRESENT_WARNING), '', false);
                  }
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method b_system_admin_warnings_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  if (in_array('tinymce', array_flip($editorhandler->getList()))) {
                      array_push($block['msg'], icms_core_Message::error(_TinyMCE_PRESENT_WARNING), '', false);
                  }
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'icms' in method 'b_system_admin_cp_new_show'.
          Open

                  $sysperm_handler = icms::handler('icms_member_groupperm');

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_modules_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $rtn['hassubs'] = 0;
                      unset($rtn['subs']);
                  }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method b_system_admin_cp_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  $all_ok = TRUE;
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(_TRUST_PATH_HELP));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(_PROTECTOR_NOT_FOUND, '', FALSE));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms' in method 'b_system_admin_modules_show'.
          Open

              $moduleperm_handler = icms::handler('icms_member_groupperm');

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Filesystem' in method 'b_system_admin_cp_new_show'.
          Open

              $dirlist = icms_core_Filesystem::getDirList($admin_dir);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/install/'), '', FALSE));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINWRITEABLE, ICMS_ROOT_PATH . '/mainfile.php'), '', FALSE));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

              if (!is_writable(ICMS_CACHE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_CACHE_PATH)), '', FALSE);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_cp_new_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  $all_ok = TRUE;
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_CSSTIDY_VULN, 'plugins/csstidy/css_optimiser.php'), '', false));

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

                  array_push($block['msg'], icms_core_Message::error(_TinyMCE_DEFAULT_WARNING), '', false);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_modules_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $rtn['hassubs'] = 0;
                      unset($rtn['subs']);
                  }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

              if (!is_writable(ICMS_UPLOAD_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_UPLOAD_PATH)), '', FALSE);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'icms_core_Message' in method 'b_system_admin_warnings_show'.
          Open

              if (version_compare(phpversion(), '7.2', '<')) array_push($block['msg'], icms_core_Message::warning(sprintf(_OUTDATED_PHP, phpversion())), '', FALSE);

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
          {
              public function bar()
              {
                  Bar::baz();
              }
          }

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method b_system_admin_cp_new_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

              } else {
                  $groups = array();
              }

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid unused local variables such as '$icmsTpl'.
          Open

              global $icmsTpl, $icmsConfig;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$systemadm'.
          Open

                      $systemadm = TRUE;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$icmsTpl'.
          Open

              global $icmsTpl, $icmsConfig;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$icmsConfig'.
          Open

              global $icmsTpl, $icmsConfig;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$category'.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$icmsConfig'.
          Open

              global $icmsTpl, $icmsConfig;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$category'.
          Open

                      $category = isset($modversion['category']) ? (int) ($modversion['category']) : 0;

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Reference to static property xoopsDB from undeclared class \icms
          Open

              $sql1 = "SELECT conf_modid FROM `" . icms::$xoopsDB->prefix('config') . "` WHERE conf_name = 'dos_skipmodules'";

          Reference to undeclared constant \_CSSTIDY_VULN
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_CSSTIDY_VULN, 'plugins/csstidy/css_optimiser.php'), '', false));

          Reference to undeclared constant \_WARNINNOTWRITEABLE
          Open

              if (!is_writable(ICMS_COMPILE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_COMPILE_PATH)), '', FALSE);

          Reference to static property xoopsDB from undeclared class \icms
          Open

              if (getDbValue(icms::$xoopsDB, 'modules', 'version', 'version="120" AND mid="1"') !== FALSE) {

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINWRITEABLE, ICMS_ROOT_PATH . '/mainfile.php'), '', FALSE));

          Reference to static property xoopsDB from undeclared class \icms
          Open

              if ($result1 = icms::$xoopsDB->query($sql1)) {

          Reference to undeclared constant \_PROTECTOR_NOT_FOUND
          Open

                  array_push($block['msg'], icms_core_Message::error(_PROTECTOR_NOT_FOUND, '', FALSE));

          Call to method __construct from undeclared class \icms_db_criteria_Compo
          Open

              $criteria = new icms_db_criteria_Compo();

          Call to method getList from undeclared class \icms_plugins_EditorHandler
          Open

                  if (in_array('FCKeditor', array_flip($editorhandler->getList()))) {

          Call to method setSort from undeclared class \icms_db_criteria_Compo
          Open

              $criteria->setSort('mid');

          Reference to static property xoopsDB from undeclared class \icms
          Open

                  list($modid) = icms::$xoopsDB->FetchRow($result1);

          Call to method __construct from undeclared class \icms_plugins_EditorHandler
          Open

              $editorhandler = new icms_plugins_EditorHandler();

          Call to method __construct from undeclared class \icms_db_criteria_Compo
          Open

              $criteria = new icms_db_criteria_Compo();

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(_CORE_MYSQL_DEPRECATED, '', FALSE));

          Call to method error from undeclared class \icms_core_Message
          Open

                      array_push($block['msg'], icms_core_Message::error(_TinyMCE_PRESENT_WARNING), '', false);

          Call to method handler from undeclared class \icms
          Open

                  $sysperm_handler = icms::handler('icms_member_groupperm');

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(_TRUST_PATH_HELP));

          Reference to static property xoopsDB from undeclared class \icms
          Open

                      $sql2 = "SELECT isactive FROM `" . icms::$xoopsDB->prefix('modules') . "` WHERE mid =" . $modid;

          Reference to static property xoopsDB from undeclared class \icms
          Open

                      list($protector_is_active) = icms::$xoopsDB->FetchRow($result2);

          Reference to undeclared constant \_TinyMCE_DEFAULT_WARNING
          Open

                  array_push($block['msg'], icms_core_Message::error(_TinyMCE_DEFAULT_WARNING), '', false);

          Reference to undeclared constant \_PREFERENCES
          Open

                      $subs = array('title' => _PREFERENCES, 'link' => ICMS_MODULES_URL . '/system/admin.php?fct=preferences&amp;op=showmod&amp;mod=' . $module->getVar('mid'));

          Reference to undeclared constant \_TRUST_PATH_HELP
          Open

                  array_push($block['msg'], icms_core_Message::error(_TRUST_PATH_HELP));

          Call to method warning from undeclared class \icms_core_Message
          Open

              if (!is_writable(ICMS_COMPILE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_COMPILE_PATH)), '', FALSE);

          Variable $block was undeclared, but array fields are being added to it.
          Open

              $block['lang_cp'] = _CPHOME;

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error('<a href="' . ICMS_MODULES_URL . '/system/admin.php?fct=modulesadmin&amp;op=update&amp;module=system">' . _WARNINGUPDATESYSTEM . '</a>'));

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_CSSTIDY_VULN, 'plugins/csstidy/css_optimiser.php'), '', false));

          Call to method error from undeclared class \icms_core_Message
          Open

                      array_push($block['msg'], icms_core_Message::error(_FCK_PRESENT_WARNING), '', false);

          Reference to undeclared constant \_FCK_PRESENT_WARNING
          Open

                      array_push($block['msg'], icms_core_Message::error(_FCK_PRESENT_WARNING), '', false);

          Reference to static property user from undeclared class \icms
          Open

                  $groups = icms::$user->getGroups();

          Call to method handler from undeclared class \icms
          Open

                  $sysperm_handler = icms::handler('icms_member_groupperm');

          Reference to undeclared constant \_WARNINSTALL2
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/install/'), '', FALSE));

          Call to method handler from undeclared class \icms
          Open

              $config_handler = icms::handler('icms_config');

          Call to method __construct from undeclared class \icms_db_criteria_Item
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'tinymce'));

          Call to method add from undeclared class \icms_db_criteria_Compo
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'tinymce'));

          Variable $block was undeclared, but array fields are being added to it.
          Open

              $block['mods'] = array();

          Reference to undeclared constant \_CPHOME
          Open

              $block['lang_cp'] = _CPHOME;

          Reference to undeclared constant \_WARNINNOTWRITEABLE
          Open

              if (!is_writable(ICMS_UPLOAD_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_UPLOAD_PATH)), '', FALSE);

          Call to method handler from undeclared class \icms
          Open

              $module_handler = icms::handler('icms_module');

          Call to method handler from undeclared class \icms
          Open

              $moduleperm_handler = icms::handler('icms_member_groupperm');

          Call to method add from undeclared class \icms_db_criteria_Compo
          Open

              $criteria->add(new icms_db_criteria_Item('hasadmin', 1));

          Reference to static property user from undeclared class \icms
          Open

                  $groups = icms::$user->getGroups();

          Call to method getDirList from undeclared class \icms_core_Filesystem
          Open

              $dirlist = icms_core_Filesystem::getDirList($admin_dir);

          Call to method warning from undeclared class \icms_core_Message
          Open

              if (version_compare(phpversion(), '7.2', '<')) array_push($block['msg'], icms_core_Message::warning(sprintf(_OUTDATED_PHP, phpversion())), '', FALSE);

          Reference to undeclared constant \_TinyMCE_PRESENT_WARNING
          Open

                      array_push($block['msg'], icms_core_Message::error(_TinyMCE_PRESENT_WARNING), '', false);

          Reference to undeclared constant \_WARNINGUPDATESYSTEM
          Open

                  array_push($block['msg'], icms_core_Message::error('<a href="' . ICMS_MODULES_URL . '/system/admin.php?fct=modulesadmin&amp;op=update&amp;module=system">' . _WARNINGUPDATESYSTEM . '</a>'));

          Reference to static property xoopsDB from undeclared class \icms
          Open

                      $result2 = icms::$xoopsDB->query($sql2);

          Reference to undeclared constant \_WARNINNOTWRITEABLE
          Open

              if (!is_writable(ICMS_CACHE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_CACHE_PATH)), '', FALSE);

          Reference to undeclared constant \_OUTDATED_PHP
          Open

              if (version_compare(phpversion(), '7.2', '<')) array_push($block['msg'], icms_core_Message::warning(sprintf(_OUTDATED_PHP, phpversion())), '', FALSE);

          Call to method __construct from undeclared class \icms_db_criteria_Item
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'FCKeditor'));

          Reference to undeclared constant \_FCK_DEFAULT_WARNING
          Open

                  array_push($block['msg'], icms_core_Message::error(_FCK_DEFAULT_WARNING), '', false);

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(_TinyMCE_DEFAULT_WARNING), '', false);

          Call to method getList from undeclared class \icms_plugins_EditorHandler
          Open

                  if (in_array('tinymce', array_flip($editorhandler->getList()))) {

          Call to method __construct from undeclared class \icms_db_criteria_Item
          Open

              $criteria->add(new icms_db_criteria_Item('isactive', 1));

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/install/'), '', FALSE));

          Reference to undeclared constant \_CPHOME
          Open

              $block['lang_cp'] = _CPHOME;

          Variable $modversion is undeclared
          Open

                  if ($modversion['hasAdmin']) {

          Reference to undeclared constant \_WARNINWRITEABLE
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINWRITEABLE, ICMS_ROOT_PATH . '/mainfile.php'), '', FALSE));

          Reference to undeclared constant \_WARNINSTALL2
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/upgrade/'), '', FALSE));

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(_PROTECTOR_NOT_FOUND, '', FALSE));

          Reference to static property db from undeclared class \icms
          Open

              if (icms::$db === NULL) {

          Call to method warning from undeclared class \icms_core_Message
          Open

              if (!is_writable(ICMS_CACHE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_CACHE_PATH)), '', FALSE);

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/upgrade/'), '', FALSE));

          Call to method add from undeclared class \icms_db_criteria_Compo
          Open

              $criteria->add(new icms_db_criteria_Item('conf_value', 'FCKeditor'));

          Call to method warning from undeclared class \icms_core_Message
          Open

              if (!is_writable(ICMS_UPLOAD_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_UPLOAD_PATH)), '', FALSE);

          Call to method __construct from undeclared class \icms_db_criteria_Compo
          Open

              $criteria = new icms_db_criteria_Compo();

          Reference to static property user from undeclared class \icms
          Open

              if (is_object(icms::$user)) {

          Call to method error from undeclared class \icms_core_Message
          Open

                  array_push($block['msg'], icms_core_Message::error(_FCK_DEFAULT_WARNING), '', false);

          Reference to undeclared constant \_AD_INSTALLEDMODULES
          Open

              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          Reference to static property user from undeclared class \icms
          Open

                  if (is_object(icms::$user)) $admin_perm = $moduleperm_handler->checkRight('module_admin', $module->getVar('mid'), icms::$user->getGroups());

          Argument 2 (haystack) is null but \in_array() takes array
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          Variable $modversion is undeclared
          Open

                  if ($modversion['hasAdmin']) {

          Argument 2 (haystack) is null but \in_array() takes array
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          Call to method __construct from undeclared class \icms_db_criteria_Item
          Open

              $criteria->add(new icms_db_criteria_Item('hasadmin', 1));

          Variable $block was undeclared, but array fields are being added to it.
          Open

              $block['lang_cp'] = _CPHOME;

          Call to method getDirList from undeclared class \icms_core_Filesystem
          Open

              $dirlist = icms_core_Filesystem::getDirList($admin_dir);

          Call to method add from undeclared class \icms_db_criteria_Compo
          Open

              $criteria->add(new icms_db_criteria_Item('isactive', 1));

          Reference to static property user from undeclared class \icms
          Open

              if (is_object(icms::$user)) {

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if ($confcount > 0) {
                  array_push($block['msg'], icms_core_Message::error(_TinyMCE_DEFAULT_WARNING), '', false);
              } else {
                  if (in_array('tinymce', array_flip($editorhandler->getList()))) {
                      array_push($block['msg'], icms_core_Message::error(_TinyMCE_PRESENT_WARNING), '', false);
          Severity: Major
          Found in htdocs/modules/system/blocks/system_admin_blocks.php and 1 other location - About 1 hr to fix
          htdocs/modules/system/blocks/system_admin_blocks.php on lines 86..92

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if ($confcount > 0) {
                  array_push($block['msg'], icms_core_Message::error(_FCK_DEFAULT_WARNING), '', false);
              } else {
                  if (in_array('FCKeditor', array_flip($editorhandler->getList()))) {
                      array_push($block['msg'], icms_core_Message::error(_FCK_PRESENT_WARNING), '', false);
          Severity: Major
          Found in htdocs/modules/system/blocks/system_admin_blocks.php and 1 other location - About 1 hr to fix
          htdocs/modules/system/blocks/system_admin_blocks.php on lines 100..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              if (getDbValue(icms::$xoopsDB, 'modules', 'version', 'version="120" AND mid="1"') !== FALSE) {

          TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
          Open

                  $all_ok = TRUE;

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                  array_push($block['msg'], icms_core_Message::error(_CORE_MYSQL_DEPRECATED, '', FALSE));

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/upgrade/'), '', FALSE));

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              if (!is_writable(ICMS_CACHE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_CACHE_PATH)), '', FALSE);

          TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
          Open

                  $all_ok = TRUE;

          TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
          Open

                      $systemadm = TRUE;

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                      if (FALSE != $all_ok || in_array($modversion['category'], $ok_syscats)) {

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              $all_ok = FALSE;

          TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
          Open

                  if (NULL !== $modid) {

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              if (!is_writable(ICMS_COMPILE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_COMPILE_PATH)), '', FALSE);

          TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
          Open

              if (icms::$db === NULL) {

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINSTALL2, ICMS_ROOT_PATH . '/install/'), '', FALSE));

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              if (version_compare(phpversion(), '7.2', '<')) array_push($block['msg'], icms_core_Message::warning(sprintf(_OUTDATED_PHP, phpversion())), '', FALSE);

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                  array_push($block['msg'], icms_core_Message::error(sprintf(_WARNINWRITEABLE, ICMS_ROOT_PATH . '/mainfile.php'), '', FALSE));

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              if (!is_writable(ICMS_UPLOAD_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_UPLOAD_PATH)), '', FALSE);

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

                  array_push($block['msg'], icms_core_Message::error(_PROTECTOR_NOT_FOUND, '', FALSE));

          TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
          Open

              $all_ok = FALSE;

          Inline control structures are not allowed
          Open

              if (count($block['sysmod']) > 0) return $block;

          Inline control structures are not allowed
          Open

                  if (is_object(icms::$user)) $admin_perm = $moduleperm_handler->checkRight('module_admin', $module->getVar('mid'), icms::$user->getGroups());

          Inline control structures are not allowed
          Open

              if (count($block['mods']) > 0) return $block;

          Inline control structures are not allowed
          Open

              if (!is_writable(ICMS_CACHE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_CACHE_PATH)), '', FALSE);

          Inline control structures are not allowed
          Open

              if (!is_writable(ICMS_UPLOAD_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_UPLOAD_PATH)), '', FALSE);

          Inline control structures are not allowed
          Open

              if (!is_writable(ICMS_COMPILE_PATH)) array_push($block['msg'], icms_core_Message::warning(sprintf(_WARNINNOTWRITEABLE, ICMS_COMPILE_PATH)), '', FALSE);

          Inline control structures are not allowed
          Open

              if (version_compare(phpversion(), '7.2', '<')) array_push($block['msg'], icms_core_Message::warning(sprintf(_OUTDATED_PHP, phpversion())), '', FALSE);

          The variable $config_handler is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $config_handler is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $ok_syscats is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $moduleperm_handler is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $moduleperm_handler is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $ok_syscats is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $protector_is_active is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $ok_syscats is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $module_handler is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $ok_syscats is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_perm is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $sysperm_handler is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $sysperm_handler is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $protector_is_active is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $module_handler is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_perm is not named in camelCase.
          Open

          function b_system_admin_modules_show() {
              $block['mods'] = array();
              $module_handler = icms::handler('icms_module');
              $moduleperm_handler = icms::handler('icms_member_groupperm');
              $criteria = new icms_db_criteria_Compo();

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $sysperm_handler is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $protector_is_active is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $config_handler is not named in camelCase.
          Open

          function b_system_admin_warnings_show() {
              $block = array();
              $block['msg'] = array();
          
              // Check if PDO is being used - if not, issue a warning, because it is being removed from PHP

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $mod_version_file is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $sysperm_handler is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $all_ok is not named in camelCase.
          Open

          function b_system_admin_cp_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
              $block['lang_insmodules'] = _AD_INSTALLEDMODULES;

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          The variable $admin_dir is not named in camelCase.
          Open

          function b_system_admin_cp_new_show() {
              global $icmsTpl, $icmsConfig;
          
              $block['lang_cp'] = _CPHOME;
          
          

          CamelCaseVariableName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name variables.

          Example

          class ClassName {
              public function doSomething() {
                  $data_module = new DataModule();
              }
          }

          Source

          There are no issues that match your filters.

          Category
          Status