ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/blocks/system_blocks.php

Summary

Maintainability
F
6 days
Test Coverage

b_system_login_show accesses the super-global variable $_COOKIE.
Open

function b_system_login_show() {
    global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
    if (!icms::$user) {
        $block = array();
        $block['lang_username'] = _USERNAME;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_online_show accesses the super-global variable $_SERVER.
Open

function b_system_online_show() {
    $online_handler = icms::handler('icms_core_Online');
    mt_srand((double) microtime() * 1000000);
    // set gc probabillity to 10% for now..
    if (mt_rand(1, 100) < 11) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_online_show accesses the super-global variable $_SERVER.
Open

function b_system_online_show() {
    $online_handler = icms::handler('icms_core_Online');
    mt_srand((double) microtime() * 1000000);
    // set gc probabillity to 10% for now..
    if (mt_rand(1, 100) < 11) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_comments_show accesses the super-global variable $GLOBALS.
Open

function b_system_comments_show($options) {
    $block = array();
    include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
    $comment_handler = icms::handler('icms_data_comment');
    $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_comments_show accesses the super-global variable $GLOBALS.
Open

function b_system_comments_show($options) {
    $block = array();
    include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
    $comment_handler = icms::handler('icms_data_comment');
    $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_notification_show accesses the super-global variable $_SERVER.
Open

function b_system_notification_show() {
    icms_loadLanguageFile('core', 'notification');
    // Notification must be enabled, and user must be logged in
    if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
        return false; // do not display block

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_login_show accesses the super-global variable $_COOKIE.
Open

function b_system_login_show() {
    global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
    if (!icms::$user) {
        $block = array();
        $block['lang_username'] = _USERNAME;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_info_show accesses the super-global variable $GLOBALS.
Open

function b_system_info_show($options) {
    global $icmsConfig;
    $block = array();
    if (!empty($options[3])) {
        $block['showgroups'] = TRUE;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

b_system_info_show accesses the super-global variable $GLOBALS.
Open

function b_system_info_show($options) {
    global $icmsConfig;
    $block = array();
    if (!empty($options[3])) {
        $block['showgroups'] = TRUE;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File system_blocks.php has 553 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

// $Id: system_blocks.php 12313 2013-09-15 21:14:35Z skenow $
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
Severity: Major
Found in htdocs/modules/system/blocks/system_blocks.php - About 1 day to fix

    Function b_system_bookmarks_show has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    function b_system_bookmarks_show() {
        global $icmsConfig;
        $block = array();
        icms_loadLanguageFile('core', 'notification');
        // User must be logged in
    Severity: Minor
    Found in htdocs/modules/system/blocks/system_blocks.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function b_system_info_show has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    function b_system_info_show($options) {
        global $icmsConfig;
        $block = array();
        if (!empty($options[3])) {
            $block['showgroups'] = TRUE;
    Severity: Minor
    Found in htdocs/modules/system/blocks/system_blocks.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method b_system_comments_show has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function b_system_comments_show($options) {
        $block = array();
        include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
        $comment_handler = icms::handler('icms_data_comment');
        $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
    Severity: Minor
    Found in htdocs/modules/system/blocks/system_blocks.php - About 2 hrs to fix

      Function b_system_online_show has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function b_system_online_show() {
          $online_handler = icms::handler('icms_core_Online');
          mt_srand((double) microtime() * 1000000);
          // set gc probabillity to 10% for now..
          if (mt_rand(1, 100) < 11) {
      Severity: Minor
      Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method b_system_bookmarks_show has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function b_system_bookmarks_show() {
          global $icmsConfig;
          $block = array();
          icms_loadLanguageFile('core', 'notification');
          // User must be logged in
      Severity: Minor
      Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

        Method b_system_online_show has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function b_system_online_show() {
            $online_handler = icms::handler('icms_core_Online');
            mt_srand((double) microtime() * 1000000);
            // set gc probabillity to 10% for now..
            if (mt_rand(1, 100) < 11) {
        Severity: Minor
        Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

          Method b_system_social_show has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function b_system_social_show($options) {
              $block = array();
              $block['provider'] = array();
          
              $i = 0;
          Severity: Minor
          Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

            Function b_system_main_show has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            function b_system_main_show() {
                global $icmsConfigUser;
            
                $block = array();
                $block['lang_home'] = _MB_SYSTEM_HOME;
            Severity: Minor
            Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method b_system_info_show has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function b_system_info_show($options) {
                global $icmsConfig;
                $block = array();
                if (!empty($options[3])) {
                    $block['showgroups'] = TRUE;
            Severity: Minor
            Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

              Method b_system_newmembers_show has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function b_system_newmembers_show($options) {
                  global $icmsConfigUser;
              
                  $block = array();
                  $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
              Severity: Minor
              Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                Function b_system_comments_show has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                function b_system_comments_show($options) {
                    $block = array();
                    include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                    $comment_handler = icms::handler('icms_data_comment');
                    $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
                Severity: Minor
                Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method b_system_notification_show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function b_system_notification_show() {
                    icms_loadLanguageFile('core', 'notification');
                    // Notification must be enabled, and user must be logged in
                    if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                        return false; // do not display block
                Severity: Minor
                Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                  Function b_system_topposters_show has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function b_system_topposters_show($options) {
                      global $icmsConfigUser;
                  
                      $block = array();
                      $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
                  Severity: Minor
                  Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function b_system_newmembers_show has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function b_system_newmembers_show($options) {
                      global $icmsConfigUser;
                  
                      $block = array();
                      $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
                  Severity: Minor
                  Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function b_system_notification_show has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function b_system_notification_show() {
                      icms_loadLanguageFile('core', 'notification');
                      // Notification must be enabled, and user must be logged in
                      if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                          return false; // do not display block
                  Severity: Minor
                  Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method b_system_main_show has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function b_system_main_show() {
                      global $icmsConfigUser;
                  
                      $block = array();
                      $block['lang_home'] = _MB_SYSTEM_HOME;
                  Severity: Minor
                  Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                    Method b_system_topposters_show has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function b_system_topposters_show($options) {
                        global $icmsConfigUser;
                    
                        $block = array();
                        $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
                    Severity: Minor
                    Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                      Function b_system_login_show has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function b_system_login_show() {
                          global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
                          if (!icms::$user) {
                              $block = array();
                              $block['lang_username'] = _USERNAME;
                      Severity: Minor
                      Found in htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function b_system_topposters_edit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function b_system_topposters_edit($options) {
                          $inputtag = "<input type='text' name='options[]' value='" . (int) $options[0] . "' />";
                          $form = sprintf(_MB_SYSTEM_DISPLAY, $inputtag);
                          $form .= "<br />" . _MB_SYSTEM_DISPLAYA . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
                          if ($options[1] == 1) {
                      Severity: Minor
                      Found in htdocs/modules/system/blocks/system_blocks.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function b_system_social_show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function b_system_social_show($options) {
                          $block = array();
                          $block['provider'] = array();
                      
                          $i = 0;
                      Severity: Minor
                      Found in htdocs/modules/system/blocks/system_blocks.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      The function b_system_newmembers_show() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
                      class Foo {
                      1   public function example() {
                      2       if ($a == $b) {
                      3           if ($a1 == $b1) {
                                      fiddle();
                      4           } elseif ($a2 == $b2) {
                                      fiddle();
                                  } else {
                                      fiddle();
                                  }
                      5       } elseif ($c == $d) {
                      6           while ($c == $d) {
                                      fiddle();
                                  }
                      7        } elseif ($e == $f) {
                      8           for ($n = 0; $n < $h; $n++) {
                                      fiddle();
                                  }
                              } else {
                                  switch ($z) {
                      9               case 1:
                                          fiddle();
                                          break;
                      10              case 2:
                                          fiddle();
                                          break;
                      11              case 3:
                                          fiddle();
                                          break;
                                      default:
                                          fiddle();
                                          break;
                                  }
                              }
                          }
                      }

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      The function b_system_bookmarks_show() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
                      class Foo {
                      1   public function example() {
                      2       if ($a == $b) {
                      3           if ($a1 == $b1) {
                                      fiddle();
                      4           } elseif ($a2 == $b2) {
                                      fiddle();
                                  } else {
                                      fiddle();
                                  }
                      5       } elseif ($c == $d) {
                      6           while ($c == $d) {
                                      fiddle();
                                  }
                      7        } elseif ($e == $f) {
                      8           for ($n = 0; $n < $h; $n++) {
                                      fiddle();
                                  }
                              } else {
                                  switch ($z) {
                      9               case 1:
                                          fiddle();
                                          break;
                      10              case 2:
                                          fiddle();
                                          break;
                      11              case 3:
                                          fiddle();
                                          break;
                                      default:
                                          fiddle();
                                          break;
                                  }
                              }
                          }
                      }

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['id'] = $i;

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['module'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/">' . $modules[$mid]->getVar('name') . '</a>';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $section['name'] = $category['name'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $section['description'] = $category['description'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              unset($com);

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                                      $com['poster'] = '<a href="' . ICMS_URL . '/userinfo.php?uid=' . $comments[$i]->getVar('com_uid') . '">' . $poster->getVar('uname') . '</a>';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                                      $com['poster'] = $GLOBALS['icmsConfig']['anonymous'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $block['comments'][] = &$com;

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['icon'] = htmlspecialchars($comments[$i]->getVar('com_icon'), ENT_QUOTES);

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                                  $com['poster'] = $GLOBALS['icmsConfig']['anonymous'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $section['itemid'] = $category['item_id'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $section['title'] = $category['title'];

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $block['categories'][$category['name']] = $section;

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                                  $section['events'][$event['name']] = array('name' => $event['name'], 'title' => $event['title'], 'caption' => $event['caption'], 'description' => $event['description'], 'subscribed' => $subscribed);

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['title'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/' . $comment_config[$mid]['pageName'] . '?' . $comment_config[$mid]['itemName'] . '=' . $comments[$i]->getVar('com_itemid') . '&amp;com_id=' . $i . '&amp;com_rootid=' . $comments[$i]->getVar('com_rootid') . '&amp;' . htmlspecialchars($comments[$i]->getVar('com_exparams')) . '#comment' . $i . '">' . $comments[$i]->getVar('com_title') . '</a>';

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$com' which will lead to PHP notices.
                      Open

                              $com['time'] = formatTimestamp($comments[$i]->getVar('com_created'), 'm');

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Avoid using undefined variables such as '$section' which will lead to PHP notices.
                      Open

                              $section['events'] = array();

                      UndefinedVariable

                      Since: 2.8.0

                      Detects when a variable is used that has not been defined before.

                      Example

                      class Foo
                      {
                          private function bar()
                          {
                              // $message is undefined
                              echo $message;
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                      Missing class import via use statement (line '80', column '45').
                      Open

                                  $mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '197', column '22').
                      Open

                              $criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '293', column '75').
                      Open

                              $block['active'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>')));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '352', column '45').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '147', column '21').
                      Open

                          $criteria->add(new icms_db_criteria_Item('isactive', 1));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '369', column '22').
                      Open

                              $criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '292', column '77').
                      Open

                              $block['inactive'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0)));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '376', column '45').
                      Open

                          $modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '757', column '16').
                      Open

                              $yesno = new icms_form_elements_Radioyn('', 'options[' . $i . ']', $option);

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '264', column '18').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '196', column '19').
                      Open

                              $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '146', column '18').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '146', column '45').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '196', column '46').
                      Open

                              $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '361', column '22').
                      Open

                          $criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '315', column '22').
                      Open

                              $criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '360', column '46').
                      Open

                          $criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '291', column '79').
                      Open

                              $block['registered'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level')));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '360', column '19').
                      Open

                          $criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '311', column '18').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '311', column '45').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '352', column '18').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '148', column '21').
                      Open

                          $criteria->add(new icms_db_criteria_Item('weight', 0, '>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      Missing class import via use statement (line '264', column '45').
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      MissingImport

                      Since: 2.7.0

                      Importing all external classes in a file through use statements makes them clearly visible.

                      Example

                      function make() {
                          return new \stdClass();
                      }

                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                      The method b_system_newmembers_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                              } else {
                                  $block['users'][$i]['avatar'] = '';
                              }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                          } else {
                              return FALSE;
                          }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                          } else {
                              $uid = 0;
                              $uname = '';
                          }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms' in method 'b_system_comments_show'.
                      Open

                          $comment_handler = icms::handler('icms_data_comment');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_comments_show'.
                      Open

                          $moduleperm_handler = icms::handler('icms_member_groupperm');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_topposters_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                              } else {
                                  $block['users'][$i]['avatar'] = '';
                              }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'.
                      Open

                                              $block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => '&nbsp;', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_comments_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                              } else {
                                  $com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
                              }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms' in method 'b_system_topposters_show'.
                      Open

                          $member_handler = icms::handler('icms_member');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                          } else {
                              $online_handler->write($uid, $uname, time(), 0, $_SERVER['REMOTE_ADDR']);
                          }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms' in method 'b_system_user_show'.
                      Open

                              $pm_handler = icms::handler('icms_data_privmessage');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_notification_show'.
                      Open

                          $notification_handler = icms::handler('icms_data_notification');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_bookmarks_show'.
                      Open

                          $notification_handler = icms::handler('icms_data_notification');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                      } else {
                                          if ($userinfo['user_viewemail']) {
                                              $block['groups'][$i]['users'][] = array(
                                                  'id' => $userinfo['uid'],
                                                  'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms_data_notification_Handler' in method 'b_system_notification_show'.
                      Open

                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_newmembers_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $block['users'][$i]['avatar'] = '';
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_comments_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $guests++ ;
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_main_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $block['modules'][$i]['sublinks'] = array();
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms' in method 'b_system_newmembers_show'.
                      Open

                          $member_handler = icms::handler('icms_member');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_comments_show'.
                      Open

                          $member_handler = icms::handler('icms_member');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_bookmarks_show'.
                      Open

                          $module_handler = icms::handler('icms_module');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'.
                      Open

                                              'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'.
                      Open

                                                  'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_comments_show'.
                      Open

                          $module_handler = icms::handler('icms_module');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_online_show'.
                      Open

                          $online_handler = icms::handler('icms_core_Online');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms' in method 'b_system_main_show'.
                      Open

                          $moduleperm_handler = icms::handler('icms_member_groupperm');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                          } else {
                              $block['showgroups'] = FALSE;
                          }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_bookmarks_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $item_info = array('name' => '[' . _NOT_NAMENOTAVAILABLE . ']', 'url' => '');
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid using static access to class 'icms' in method 'b_system_main_show'.
                      Open

                          $module_handler = icms::handler('icms_module');

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'.
                      Open

                                          $block['groups'][$i]['name'] = icms_core_DataFilter::htmlSpecialChars($userinfo['groupname']);

                      StaticAccess

                      Since: 1.4.0

                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                      Example

                      class Foo
                      {
                          public function bar()
                          {
                              Bar::baz();
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                      The method b_system_topposters_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                  } else {
                                      $block['users'][$i]['avatar'] = '';
                                  }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                      Open

                                          } else {
                                              $block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => '&nbsp;', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);
                                          }

                      ElseExpression

                      Since: 1.4.0

                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                      Example

                      class Foo
                      {
                          public function bar($flag)
                          {
                              if ($flag) {
                                  // one branch
                              } else {
                                  // another branch
                              }
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                      Avoid unused local variables such as '$icmsConfig'.
                      Open

                          global $icmsConfig;

                      UnusedLocalVariable

                      Since: 0.2

                      Detects when a local variable is declared and/or assigned, but not used.

                      Example

                      class Foo {
                          public function doSomething()
                          {
                              $i = 5; // Unused
                          }
                      }

                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                      Avoid unused local variables such as '$icmsConfig'.
                      Open

                          global $icmsConfig;

                      UnusedLocalVariable

                      Since: 0.2

                      Detects when a local variable is declared and/or assigned, but not used.

                      Example

                      class Foo {
                          public function doSomething()
                          {
                              $i = 5; // Unused
                          }
                      }

                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                      Avoid unused local variables such as '$icmsConfigAuth'.
                      Open

                          global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;

                      UnusedLocalVariable

                      Since: 0.2

                      Detects when a local variable is declared and/or assigned, but not used.

                      Example

                      class Foo {
                          public function doSomething()
                          {
                              $i = 5; // Unused
                          }
                      }

                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                      FIXME found
                      Open

                          // FIXME: better or more standardized way to do this?

                      Reference to static property user from undeclared class \icms
                      Open

                              $uname = icms::$user->getVar('uname');

                      Reference to undeclared constant \_MEMBERS (Did you mean $members)
                      Open

                              $block['lang_members'] = _MEMBERS;

                      When fetching an array index from a value of type array, found an array index of type null, but expected the index to be of the non-nullable type int|string
                      Open

                                  $block['unamevalue'] = $_COOKIE[$icmsConfig['usercookie']];

                      Reference to undeclared constant \_ONLINEPHRASEX
                      Open

                                  $block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, icms::$module->getVar('name')) . ')';

                      Reference to undeclared constant \_USERNAME
                      Open

                              $block['lang_username'] = _USERNAME;

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));

                      Reference to undeclared constant \_LOGIN
                      Open

                              $block['lang_login'] = _LOGIN;

                      Reference to static property module from undeclared class \icms
                      Open

                                  $block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, icms::$module->getVar('name')) . ')';

                      Call to method handler from undeclared class \icms
                      Open

                          $member_handler = icms::handler('icms_member');

                      Reference to static property user from undeclared class \icms
                      Open

                          if (is_object(icms::$user)) {

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));

                      Reference to static property module from undeclared class \icms
                      Open

                              if (is_object(icms::$module)) {

                      Reference to undeclared constant \_GUESTS (Did you mean $guests)
                      Open

                              $block['lang_guests'] = _GUESTS;

                      Call to method htmlSpecialChars from undeclared class \icms_core_DataFilter
                      Open

                                          $block['groups'][$i]['name'] = icms_core_DataFilter::htmlSpecialChars($userinfo['groupname']);

                      Reference to static property user from undeclared class \icms
                      Open

                          if (!icms::$user) {

                      Reference to undeclared constant \_NO
                      Open

                          $form .= '&nbsp;<input type="radio" name="options[0]" value="0"' . $chk . ' />' . _NO;

                      Reference to static property user from undeclared class \icms
                      Open

                              $uid = icms::$user->getVar('uid');

                      Reference to static property module from undeclared class \icms
                      Open

                          if (is_object(icms::$module)) {

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                              $criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));

                      Call to method handler from undeclared class \icms
                      Open

                          $online_handler = icms::handler('icms_core_Online');

                      Argument 1 (seed) is float but \mt_srand() takes int
                      Open

                          mt_srand((double) microtime() * 1000000);

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                                  $mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));

                      Reference to undeclared constant \_PASSWORD
                      Open

                              $block['lang_password'] = _PASSWORD;

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                              $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));

                      Reference to undeclared constant \_MORE
                      Open

                              $block['lang_more'] = _MORE;

                      Call to method handler from undeclared class \icms
                      Open

                          $module_handler = icms::handler('icms_module');

                      Reference to static property module from undeclared class \icms
                      Open

                              $online_handler->write($uid, $uname, time(), icms::$module->getVar('mid'), $_SERVER['REMOTE_ADDR']);

                      Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string)
                      Open

                                  $block['sslloginlink'] = "<a href=\"javascript:openWithSelfMain('" . $icmsConfig['sslloginlink'] . "', 'ssllogin', 300, 200);\">" . _MB_SYSTEM_SECURE . "</a>";

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria->add(new icms_db_criteria_Item('isactive', 1));

                      Reference to static property user from undeclared class \icms
                      Open

                                      if (isset(icms::$user) && is_object(icms::$user)) {

                      Call to method setLimit from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setLimit((int) $options[0]);

                      Saw an @param annotation for options, but the param list of function b_system_notification_show() : array; is empty
                      Open

                       * @param array $options The block options

                      Reference to undeclared constant \_YES
                      Open

                          $form .= " />&nbsp;" . _YES . "<input type='radio' id='options[1]' name='options[1]' value='0'";

                      Reference to undeclared constant \_NO
                      Open

                          $form .= " />&nbsp;" . _NO . "";

                      Reference to undeclared constant \_YES
                      Open

                          $form .= "<input type='radio' name='options[3]' value='1'" . $chk . " />&nbsp;" . _YES . "";

                      Reference to undeclared constant \_PROFILE
                      Open

                                      $members .= ' <a href="' . ICMS_URL . '/userinfo.php?uid=' . $onlines[$i]['online_uid'] . '" title="' . $onlines[$i]['online_uname'] . '\'s ' . _PROFILE . '">' . $onlines[$i]['online_uname'] . '</a>, ';

                      Reference to static property module from undeclared class \icms
                      Open

                                  $mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));

                      Invalid offset "usercookie" of array type array{template_set:mixed}
                      Open

                              if (isset($_COOKIE[$icmsConfig['usercookie']])) {

                      Reference to undeclared constant \_CLOSE
                      Open

                          $block['lang_close'] = _CLOSE;

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      Reference to static property module from undeclared class \icms
                      Open

                                  if ((count($sublinks) > 0) && (!empty(icms::$module)) && ($i == icms::$module->getVar('mid'))) {

                      Reference to undeclared constant \_ONLINEPHRASE
                      Open

                              $block['online_total'] = sprintf(_ONLINEPHRASE, $total);

                      Reference to static property user from undeclared class \icms
                      Open

                              $block['uid'] = icms::$user->getVar('uid');

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $block['inactive'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0)));

                      Call to method handler from undeclared class \icms
                      Open

                          $moduleperm_handler = icms::handler('icms_member_groupperm');

                      Call to method setSort from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setSort('user_regdate');

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      Call to method handler from undeclared class \icms
                      Open

                          $notification_handler = icms::handler('icms_data_notification');

                      Call to method setOrder from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setOrder('DESC');

                      Variable $section was undeclared, but array fields are being added to it.
                      Open

                              $section['name'] = $category['name'];

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                              $criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));

                      Reference to undeclared constant \_NOT_UPDATENOW
                      Open

                          $block['submit_button'] = _NOT_UPDATENOW;

                      Reference to undeclared constant \_YES
                      Open

                          $form .= " />&nbsp;" . _YES . "<input type='radio' id='options[2]' name='options[2]' value='0'";

                      Reference to static property user from undeclared class \icms
                      Open

                          if (empty(icms::$user)) {

                      Reference to static property user from undeclared class \icms
                      Open

                          $notifications = &$notification_handler->getByUser(icms::$user->getVar('uid'));

                      When appending to a value of type array{}, found an array access index of type null, but expected the index to be of type int|string
                      Open

                                  $block[$module_name][] = array('name' => $item_info['name'], 'url' => $item_info['url']);

                      Invalid offset "usercookie" of array type array{template_set:mixed}
                      Open

                                  $block['unamevalue'] = $_COOKIE[$icmsConfig['usercookie']];

                      Reference to static property user from undeclared class \icms
                      Open

                          $groups = is_object(icms::$user) ? icms::$user->getGroups() : XOOPS_GROUP_ANONYMOUS;

                      Reference to static property user from undeclared class \icms
                      Open

                          if (is_object(icms::$user)) {

                      Call to method handler from undeclared class \icms
                      Open

                              $pm_handler = icms::handler('icms_data_privmessage');

                      Reference to static property user from undeclared class \icms
                      Open

                              $criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));

                      Reference to static property xoopsDB from undeclared class \icms
                      Open

                              if (icms::$xoopsDB->getRowsNum($result) > 0) {

                      Call to method setSort from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setSort('posts');

                      Call to method handler from undeclared class \icms
                      Open

                          $comment_handler = icms::handler('icms_data_comment');

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));

                      Reference to undeclared constant \_NOT_NAMENOTAVAILABLE
                      Open

                                      $item_info = array('name' => '[' . _NOT_NAMENOTAVAILABLE . ']', 'url' => '');

                      Call to method handler from undeclared class \icms
                      Open

                          $member_handler = icms::handler('icms_member');

                      Call to method handler from undeclared class \icms
                      Open

                          $member_handler = icms::handler('icms_member');

                      Reference to static property user from undeclared class \icms
                      Open

                                  if (!empty($event['admin_only']) && !icms::$user->isAdmin(icms::$module->getVar('mid'))) {

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));

                      Invalid offset "language" of array type array{template_set:mixed}
                      Open

                          $block['current_language'] = $icmsConfig['language'];

                      Reference to undeclared constant \_YES
                      Open

                          $form .= " />&nbsp;" . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria->add(new icms_db_criteria_Item('weight', 0, '>'));

                      null passed to foreach instead of array
                      Open

                          foreach ($icmsConfig['theme_set_allowed'] as $theme) {

                      Invalid offset "theme_set" of array type array{template_set:mixed}
                      Open

                              $block['theme_select'][$theme]['current'] = $theme == $icmsConfig['theme_set'];

                      Call to method __construct from undeclared class \icms_form_elements_Radioyn
                      Open

                              $yesno = new icms_form_elements_Radioyn('', 'options[' . $i . ']', $option);

                      Invalid offset "use_ssl" of array type array{template_set:mixed}
                      Open

                              if ($icmsConfig['use_ssl'] == 1 && $icmsConfig['sslloginlink'] != '') {

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      Invalid offset "sslloginlink" of array type array{template_set:mixed}
                      Open

                                  $block['sslloginlink'] = "<a href=\"javascript:openWithSelfMain('" . $icmsConfig['sslloginlink'] . "', 'ssllogin', 300, 200);\">" . _MB_SYSTEM_SECURE . "</a>";

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->add(new icms_db_criteria_Item('weight', 0, '>'));

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $block['registered'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level')));

                      Returning type false but b_system_notification_show() is declared to return array
                      Open

                              return false;

                      Reference to static property module from undeclared class \icms
                      Open

                              $subscribed_events = $notification_handler->getSubscribedEvents($category['name'], $category['item_id'], icms::$module->getVar('mid'), icms::$user->getVar('uid'));

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                              $criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));

                      Call to method handler from undeclared class \icms
                      Open

                          $moduleperm_handler = icms::handler('icms_member_groupperm');

                      Invalid offset "theme_set_allowed" of array type array{template_set:mixed}
                      Open

                          foreach ($icmsConfig['theme_set_allowed'] as $theme) {

                      Reference to static property xoopsDB from undeclared class \icms
                      Open

                              $result = icms::$xoopsDB->query("SELECT u.uid, u.uname, u.email, u.user_viewemail, u.user_avatar, g.name AS groupname FROM " . icms::$xoopsDB->prefix("groups_users_link") . " l LEFT JOIN " . icms::$xoopsDB->prefix("users") . " u ON l.uid=u.uid LEFT JOIN " . icms::$xoopsDB->prefix("groups") . " g ON l.groupid=g.groupid WHERE g.group_type='Admin' ORDER BY l.groupid, u.uid");

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $block['active'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>')));

                      Reference to static property user from undeclared class \icms
                      Open

                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {

                      Call to method setLimit from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setLimit($limit);

                      Reference to static property module from undeclared class \icms
                      Open

                                  if (!empty($event['admin_only']) && !icms::$user->isAdmin(icms::$module->getVar('mid'))) {

                      Returning type false but b_system_notification_show() is declared to return array
                      Open

                              return false; // do not display block

                      Returning type false but b_system_bookmarks_show() is declared to return array
                      Open

                              return FALSE; // do not display block

                      Call to method handler from undeclared class \icms
                      Open

                          $notification_handler = icms::handler('icms_data_notification');

                      Call to method setOrder from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setOrder('DESC');

                      Call to method handler from undeclared class \icms
                      Open

                          $module_handler = icms::handler('icms_module');

                      Call to method setLimit from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setLimit($limit);

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));

                      Variable $com was undeclared, but array fields are being added to it.
                      Open

                              $com['module'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/">' . $modules[$mid]->getVar('name') . '</a>';

                      Call to method handler from undeclared class \icms
                      Open

                          $module_handler = icms::handler('icms_module');

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));

                      Reference to static property xoopsDB from undeclared class \icms
                      Open

                                  while ($userinfo = icms::$xoopsDB->fetchArray($result)) {

                      Call to method htmlSpecialChars from undeclared class \icms_core_DataFilter
                      Open

                                              'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      Reference to static property user from undeclared class \icms
                      Open

                          $gperm_groupid = is_object(icms::$user) ? icms::$user->getGroups() : array(XOOPS_GROUP_ANONYMOUS);

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                          $modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);

                      Reference to undeclared constant \_NO
                      Open

                          $form .= " />&nbsp;" . _NO . "";

                      Reference to undeclared constant \_NO
                      Open

                          $form .= " />&nbsp;" . _NO . "";

                      Invalid offset "sslloginlink" of array type array{template_set:mixed}
                      Open

                              if ($icmsConfig['use_ssl'] == 1 && $icmsConfig['sslloginlink'] != '') {

                      Call to method htmlSpecialChars from undeclared class \icms_core_DataFilter
                      Open

                                              $block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => '&nbsp;', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);

                      Call to method __construct from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      Call to method __construct from undeclared class \icms_db_criteria_Item
                      Open

                              $criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));

                      Reference to static property security from undeclared class \icms
                      Open

                          $block['notification_token'] = icms::$security->createToken();

                      Reference to undeclared constant \_NO
                      Open

                          $form .= "&nbsp;<input type='radio' name='options[3]' value='0'" . $chk . " />" . _NO . "";

                      Call to method add from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->add(new icms_db_criteria_Item('isactive', 1));

                      Call to method htmlSpecialChars from undeclared class \icms_core_DataFilter
                      Open

                                                  'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),

                      Call to method setOrder from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setOrder('DESC');

                      Call to method setSort from undeclared class \icms_db_criteria_Compo
                      Open

                          $criteria->setSort('com_created');

                      Call to method isEnabled from undeclared class \icms_data_notification_Handler
                      Open

                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {

                      Reference to static property user from undeclared class \icms
                      Open

                              $subscribed_events = $notification_handler->getSubscribedEvents($category['name'], $category['item_id'], icms::$module->getVar('mid'), icms::$user->getVar('uid'));

                      Invalid offset "theme_set" of array type array{template_set:mixed}
                      Open

                          $block['current_theme'] = $icmsConfig['theme_set'];

                      Reference to undeclared constant \_YES
                      Open

                          $form .= "<input type='radio' name='options[0]' value='1'" . $chk . " />&nbsp;" . _YES;

                      Call to method render from undeclared class \icms_form_elements_Radioyn
                      Open

                              $form .= '<tr><td width="25%">' . constant('_MB_SYSTEM_SOCIAL_PROVIDER_' . $i) . '</td><td>' . $yesno->render() . '</td></tr>';

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ($options[1] == 1) {
                                  if ($topposters[$i]->getVar('user_avatar') && $topposters[$i]->getVar('user_avatar') != 'blank.gif' && $topposters[$i]->getVar('user_avatar') != '') {
                                      $block['users'][$i]['avatar'] = ICMS_UPLOAD_URL . '/' . $topposters[$i]->getVar('user_avatar');
                                  } elseif ($icmsConfigUser['avatar_allow_gravatar'] == 1) {
                                      $block['users'][$i]['avatar'] = $topposters[$i]->gravatar('G', $icmsConfigUser['avatar_width']);
                      Severity: Major
                      Found in htdocs/modules/system/blocks/system_blocks.php and 1 other location - About 5 hrs to fix
                      htdocs/modules/system/blocks/system_blocks.php on lines 273..283

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 196.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ($options[1] == 1) {
                                  if ($newmembers[$i]->getVar('user_avatar') && $newmembers[$i]->getVar('user_avatar') != 'blank.gif' && $newmembers[$i]->getVar('user_avatar') != '') {
                                      $block['users'][$i]['avatar'] = ICMS_UPLOAD_URL . '/' . $newmembers[$i]->getVar('user_avatar');
                                  } elseif ($icmsConfigUser['avatar_allow_gravatar'] == 1) {
                                      $block['users'][$i]['avatar'] = $newmembers[$i]->gravatar('G', $icmsConfigUser['avatar_width']);
                      Severity: Major
                      Found in htdocs/modules/system/blocks/system_blocks.php and 1 other location - About 5 hrs to fix
                      htdocs/modules/system/blocks/system_blocks.php on lines 324..334

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 196.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (!empty($not_config['lookup_file'])) {
                                      $lookup_file = ICMS_MODULES_PATH . '/' . $module->getVar('dirname') . '/' . $not_config['lookup_file'];
                                      if (file_exists($lookup_file)) {
                                          include_once $lookup_file;
                                          if (!empty($not_config['lookup_func']) && function_exists($not_config['lookup_func'])) {
                      Severity: Major
                      Found in htdocs/modules/system/blocks/system_blocks.php and 1 other location - About 1 hr to fix
                      htdocs/notifications.php on lines 119..127

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Avoid variables with short names like $i. Configured minimum length is 3.
                      Open

                                  $i = 0;

                      ShortVariable

                      Since: 0.2

                      Detects when a field, local, or parameter has a very short name.

                      Example

                      class Something {
                          private $q = 15; // VIOLATION - Field
                          public static function main( array $as ) { // VIOLATION - Formal
                              $r = 20 + $this->q; // VIOLATION - Local
                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                  $r += $this->q;
                              }
                          }
                      }

                      Source https://phpmd.org/rules/naming.html#shortvariable

                      Avoid variables with short names like $i. Configured minimum length is 3.
                      Open

                          $i = 0;

                      ShortVariable

                      Since: 0.2

                      Detects when a field, local, or parameter has a very short name.

                      Example

                      class Something {
                          private $q = 15; // VIOLATION - Field
                          public static function main( array $as ) { // VIOLATION - Formal
                              $r = 20 + $this->q; // VIOLATION - Local
                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                  $r += $this->q;
                              }
                          }
                      }

                      Source https://phpmd.org/rules/naming.html#shortvariable

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                          if (FALSE !== $onlines) {

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                          $perms = $moduleperm_handler->getObjects($criteria1, TRUE);

                      Opening brace should be on the same line as the declaration
                      Open

                      {

                      Expected 1 space after "=>"; 0 found
                      Open

                          foreach ($language_names as $namekey=>$language_name){

                      Space found before closing bracket of FOR loop
                      Open

                              for ($i = 0; $i < $total; $i++ ) {

                      Expected 1 space before "=>"; 0 found
                      Open

                          foreach ($language_tags as $tagkey=>$language_tag) {

                      Space found before closing bracket of FOR loop
                      Open

                          for ($i = 0; $i < $count; $i++ ) {

                      Space found before closing bracket of FOR loop
                      Open

                          for ($i = 0; $i < $count; $i++ ) {

                      Expected 0 spaces before closing bracket; 1 found
                      Open

                          for ($i = 0; $i < $count; $i++ ) {

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                          $modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                          $modules = $module_handler->getObjects($criteria, TRUE);

                      Blank line found at end of control structure
                      Open

                      
                      

                      Expected 1 space before "=>"; 0 found
                      Open

                          foreach ($language_names as $namekey=>$language_name){

                      Expected 0 spaces before closing bracket; 1 found
                      Open

                              for ($i = 2; $i < $size; $i++ ) {

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                          $comments = $comment_handler->getObjects($criteria, TRUE);

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                              return FALSE; // do not display block

                      Expected 0 spaces before closing bracket; 1 found
                      Open

                          for ($i = 0; $i < $count; $i++ ) {

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                          return FALSE;

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                              $block['showgroups'] = TRUE;

                      Expected 0 spaces before closing bracket; 1 found
                      Open

                          for ($i = 2; $i < $size; $i++ ) {

                      Expected 0 spaces before closing bracket; 1 found
                      Open

                              for ($i = 0; $i < $total; $i++ ) {

                      Space found before closing bracket of FOR loop
                      Open

                              for ($i = 2; $i < $size; $i++ ) {

                      Space found before closing bracket of FOR loop
                      Open

                          for ($i = 2; $i < $size; $i++ ) {

                      Expected 1 space before opening brace; found 0
                      Open

                      function b_system_themes_show($options){

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                              return FALSE;

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                              $block['showgroups'] = FALSE;

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                              $block['index_enabled'] = TRUE;

                      Expected 1 space after "=>"; 0 found
                      Open

                          foreach ($language_tags as $tagkey=>$language_tag) {

                      TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
                      Open

                          return FALSE;

                      TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
                      Open

                              $block['priv_enabled'] = TRUE;

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Inline control structures are not allowed
                      Open

                              if($options[0]==1)

                      Inline control structures are not allowed
                      Open

                          if ($options[$i]) $block['provider'][$i] = array(

                      Expected 1 space after closing parenthesis; found 0
                      Open

                          foreach ($language_names as $namekey=>$language_name){

                      Expected 1 space after IF keyword; 0 found
                      Open

                              if($options[0]==1)

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $read_allowed is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_caption is not named in camelCase.
                      Open

                      function b_system_info_show($options) {
                          global $icmsConfig;
                          $block = array();
                          if (!empty($options[3])) {
                              $block['showgroups'] = TRUE;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $pm_handler is not named in camelCase.
                      Open

                      function b_system_user_show() {
                          if (is_object(icms::$user)) {
                              $pm_handler = icms::handler('icms_data_privmessage');
                              $block = array();
                              $block['lang_youraccount'] = _MB_SYSTEM_VACNT;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_tags is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_item is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $moduleperm_handler is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $moduleperm_handler is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $script_name is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_modid is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_config is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_config is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_modid is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $item_info is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_func is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $script_name is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_tags is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_tag is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_name is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_topposters_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $subscribed_events is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $script_url is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_tag is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_names is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_name is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_func is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $item_info is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_config is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_name is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_caption is not named in camelCase.
                      Open

                      function b_system_info_show($options) {
                          global $icmsConfig;
                          $block = array();
                          if (!empty($options[3])) {
                              $block['showgroups'] = TRUE;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_caption is not named in camelCase.
                      Open

                      function b_system_info_show($options) {
                          global $icmsConfig;
                          $block = array();
                          if (!empty($options[3])) {
                              $block['showgroups'] = TRUE;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $subscribed_events is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_config is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $moduleperm_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_config is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $language_names is not named in camelCase.
                      Open

                      function b_system_multilanguage_show()
                      {
                          global $icmsConfigMultilang, $icmsConfig;
                      
                          $block = array();

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_name is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_file is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_file is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_func is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $gperm_groupid is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $gperm_groupid is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $comment_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_item is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_func is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $item_info is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_modid is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $lookup_file is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_item is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $item_info is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $read_allowed is not named in camelCase.
                      Open

                      function b_system_main_show() {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $block['lang_home'] = _MB_SYSTEM_HOME;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_newmembers_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_topposters_show($options) {
                          global $icmsConfigUser;
                      
                          $block = array();
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $member_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $script_url is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $notification_handler is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $prev_item is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $online_handler is not named in camelCase.
                      Open

                      function b_system_online_show() {
                          $online_handler = icms::handler('icms_core_Online');
                          mt_srand((double) microtime() * 1000000);
                          // set gc probabillity to 10% for now..
                          if (mt_rand(1, 100) < 11) {

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $moduleperm_handler is not named in camelCase.
                      Open

                      function b_system_comments_show($options) {
                          $block = array();
                          include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
                          $comment_handler = icms::handler('icms_data_comment');
                          $criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $script_url is not named in camelCase.
                      Open

                      function b_system_notification_show() {
                          icms_loadLanguageFile('core', 'notification');
                          // Notification must be enabled, and user must be logged in
                          if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
                              return false; // do not display block

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_name is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $pm_handler is not named in camelCase.
                      Open

                      function b_system_user_show() {
                          if (is_object(icms::$user)) {
                              $pm_handler = icms::handler('icms_data_privmessage');
                              $block = array();
                              $block['lang_youraccount'] = _MB_SYSTEM_VACNT;

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $module_handler is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      The variable $not_config is not named in camelCase.
                      Open

                      function b_system_bookmarks_show() {
                          global $icmsConfig;
                          $block = array();
                          icms_loadLanguageFile('core', 'notification');
                          // User must be logged in

                      CamelCaseVariableName

                      Since: 0.2

                      It is considered best practice to use the camelCase notation to name variables.

                      Example

                      class ClassName {
                          public function doSomething() {
                              $data_module = new DataModule();
                          }
                      }

                      Source

                      There are no issues that match your filters.

                      Category
                      Status