b_system_login_show accesses the super-global variable $_COOKIE. Open
function b_system_login_show() {
global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
if (!icms::$user) {
$block = array();
$block['lang_username'] = _USERNAME;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_online_show accesses the super-global variable $_SERVER. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_online_show accesses the super-global variable $_SERVER. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_comments_show accesses the super-global variable $GLOBALS. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_comments_show accesses the super-global variable $GLOBALS. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_notification_show accesses the super-global variable $_SERVER. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_login_show accesses the super-global variable $_COOKIE. Open
function b_system_login_show() {
global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
if (!icms::$user) {
$block = array();
$block['lang_username'] = _USERNAME;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_info_show accesses the super-global variable $GLOBALS. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
b_system_info_show accesses the super-global variable $GLOBALS. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
File system_blocks.php
has 553 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
// $Id: system_blocks.php 12313 2013-09-15 21:14:35Z skenow $
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
Function b_system_bookmarks_show
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_system_info_show
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_comments_show
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
Function b_system_online_show
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_bookmarks_show
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
Method b_system_online_show
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
Method b_system_social_show
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_social_show($options) {
$block = array();
$block['provider'] = array();
$i = 0;
Function b_system_main_show
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_info_show
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
Method b_system_newmembers_show
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
Function b_system_comments_show
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_notification_show
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
Function b_system_topposters_show
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function b_system_topposters_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_system_newmembers_show
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_system_notification_show
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method b_system_main_show
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
Method b_system_topposters_show
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function b_system_topposters_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
Function b_system_login_show
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
function b_system_login_show() {
global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
if (!icms::$user) {
$block = array();
$block['lang_username'] = _USERNAME;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_system_topposters_edit
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
function b_system_topposters_edit($options) {
$inputtag = "<input type='text' name='options[]' value='" . (int) $options[0] . "' />";
$form = sprintf(_MB_SYSTEM_DISPLAY, $inputtag);
$form .= "<br />" . _MB_SYSTEM_DISPLAYA . " <input type='radio' id='options[]' name='options[]' value='1'";
if ($options[1] == 1) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function b_system_social_show
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function b_system_social_show($options) {
$block = array();
$block['provider'] = array();
$i = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The function b_system_newmembers_show() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function b_system_bookmarks_show() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['id'] = $i;
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['module'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/">' . $modules[$mid]->getVar('name') . '</a>';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['name'] = $category['name'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['description'] = $category['description'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
unset($com);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['poster'] = '<a href="' . ICMS_URL . '/userinfo.php?uid=' . $comments[$i]->getVar('com_uid') . '">' . $poster->getVar('uname') . '</a>';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$block['comments'][] = &$com;
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['icon'] = htmlspecialchars($comments[$i]->getVar('com_icon'), ENT_QUOTES);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['itemid'] = $category['item_id'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['title'] = $category['title'];
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$block['categories'][$category['name']] = $section;
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['events'][$event['name']] = array('name' => $event['name'], 'title' => $event['title'], 'caption' => $event['caption'], 'description' => $event['description'], 'subscribed' => $subscribed);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['icon'] = ($com['icon'] != '') ? $com['icon'] : 'icon1.gif';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['title'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/' . $comment_config[$mid]['pageName'] . '?' . $comment_config[$mid]['itemName'] . '=' . $comments[$i]->getVar('com_itemid') . '&com_id=' . $i . '&com_rootid=' . $comments[$i]->getVar('com_rootid') . '&' . htmlspecialchars($comments[$i]->getVar('com_exparams')) . '#comment' . $i . '">' . $comments[$i]->getVar('com_title') . '</a>';
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$com' which will lead to PHP notices. Open
$com['time'] = formatTimestamp($comments[$i]->getVar('com_created'), 'm');
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$section' which will lead to PHP notices. Open
$section['events'] = array();
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '80', column '45'). Open
$mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '197', column '22'). Open
$criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '293', column '75'). Open
$block['active'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '352', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '147', column '21'). Open
$criteria->add(new icms_db_criteria_Item('isactive', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '369', column '22'). Open
$criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '292', column '77'). Open
$block['inactive'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0)));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '376', column '45'). Open
$modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '757', column '16'). Open
$yesno = new icms_form_elements_Radioyn('', 'options[' . $i . ']', $option);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '264', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '196', column '19'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '146', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '146', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '196', column '46'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '361', column '22'). Open
$criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '315', column '22'). Open
$criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '360', column '46'). Open
$criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '291', column '79'). Open
$block['registered'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level')));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '360', column '19'). Open
$criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '311', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '311', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '352', column '18'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '148', column '21'). Open
$criteria->add(new icms_db_criteria_Item('weight', 0, '>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '264', column '45'). Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method b_system_newmembers_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['users'][$i]['avatar'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return FALSE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$uid = 0;
$uname = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'b_system_comments_show'. Open
$comment_handler = icms::handler('icms_data_comment');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_comments_show'. Open
$moduleperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_topposters_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['users'][$i]['avatar'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'. Open
$block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => ' ', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_comments_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'b_system_topposters_show'. Open
$member_handler = icms::handler('icms_member');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$online_handler->write($uid, $uname, time(), 0, $_SERVER['REMOTE_ADDR']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'b_system_user_show'. Open
$pm_handler = icms::handler('icms_data_privmessage');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_notification_show'. Open
$notification_handler = icms::handler('icms_data_notification');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_bookmarks_show'. Open
$notification_handler = icms::handler('icms_data_notification');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($userinfo['user_viewemail']) {
$block['groups'][$i]['users'][] = array(
'id' => $userinfo['uid'],
'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms_data_notification_Handler' in method 'b_system_notification_show'. Open
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_newmembers_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['users'][$i]['avatar'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_comments_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$com['poster'] = $GLOBALS['icmsConfig']['anonymous'];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_online_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$guests++ ;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_main_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['modules'][$i]['sublinks'] = array();
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'b_system_newmembers_show'. Open
$member_handler = icms::handler('icms_member');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_comments_show'. Open
$member_handler = icms::handler('icms_member');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_bookmarks_show'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'. Open
'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'. Open
'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_comments_show'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_online_show'. Open
$online_handler = icms::handler('icms_core_Online');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms' in method 'b_system_main_show'. Open
$moduleperm_handler = icms::handler('icms_member_groupperm');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['showgroups'] = FALSE;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_bookmarks_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$item_info = array('name' => '[' . _NOT_NAMENOTAVAILABLE . ']', 'url' => '');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'icms' in method 'b_system_main_show'. Open
$module_handler = icms::handler('icms_module');
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'icms_core_DataFilter' in method 'b_system_info_show'. Open
$block['groups'][$i]['name'] = icms_core_DataFilter::htmlSpecialChars($userinfo['groupname']);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method b_system_topposters_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['users'][$i]['avatar'] = '';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method b_system_info_show uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => ' ', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsConfig;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$icmsConfig'. Open
global $icmsConfig;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$icmsConfigAuth'. Open
global $icmsConfig, $icmsConfigAuth, $icmsConfigUser;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
FIXME found Open
// FIXME: better or more standardized way to do this?
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$uname = icms::$user->getVar('uname');
- Exclude checks
Reference to undeclared constant \_MEMBERS
(Did you mean $members) Open
$block['lang_members'] = _MEMBERS;
- Exclude checks
When fetching an array index from a value of type array,
found an array index of type null,
but expected the index to be of the non-nullable type int|string
Open
$block['unamevalue'] = $_COOKIE[$icmsConfig['usercookie']];
- Exclude checks
Reference to undeclared constant \_ONLINEPHRASEX
Open
$block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, icms::$module->getVar('name')) . ')';
- Exclude checks
Reference to undeclared constant \_USERNAME
Open
$block['lang_username'] = _USERNAME;
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));
- Exclude checks
Reference to undeclared constant \_LOGIN
Open
$block['lang_login'] = _LOGIN;
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
$block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, icms::$module->getVar('name')) . ')';
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$member_handler = icms::handler('icms_member');
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (is_object(icms::$user)) {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('hasmain', 1));
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
if (is_object(icms::$module)) {
- Exclude checks
Reference to undeclared constant \_GUESTS
(Did you mean $guests) Open
$block['lang_guests'] = _GUESTS;
- Exclude checks
Call to method htmlSpecialChars
from undeclared class \icms_core_DataFilter
Open
$block['groups'][$i]['name'] = icms_core_DataFilter::htmlSpecialChars($userinfo['groupname']);
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!icms::$user) {
- Exclude checks
Reference to undeclared constant \_NO
Open
$form .= ' <input type="radio" name="options[0]" value="0"' . $chk . ' />' . _NO;
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$uid = icms::$user->getVar('uid');
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
if (is_object(icms::$module)) {
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$online_handler = icms::handler('icms_core_Online');
- Exclude checks
Argument 1 (seed)
is float
but \mt_srand()
takes int
Open
mt_srand((double) microtime() * 1000000);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));
- Exclude checks
Reference to undeclared constant \_PASSWORD
Open
$block['lang_password'] = _PASSWORD;
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));
- Exclude checks
Reference to undeclared constant \_MORE
Open
$block['lang_more'] = _MORE;
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
$online_handler->write($uid, $uname, time(), icms::$module->getVar('mid'), $_SERVER['REMOTE_ADDR']);
- Exclude checks
Suspicious type null
of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
$block['sslloginlink'] = "<a href=\"javascript:openWithSelfMain('" . $icmsConfig['sslloginlink'] . "', 'ssllogin', 300, 200);\">" . _MB_SYSTEM_SECURE . "</a>";
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('isactive', 1));
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (isset(icms::$user) && is_object(icms::$user)) {
- Exclude checks
Call to method setLimit
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setLimit((int) $options[0]);
- Exclude checks
Saw an @param annotation for options,
but the param list of function b_system_notification_show() : array;
is empty Open
* @param array $options The block options
- Exclude checks
Reference to undeclared constant \_YES
Open
$form .= " /> " . _YES . "<input type='radio' id='options[1]' name='options[1]' value='0'";
- Exclude checks
Reference to undeclared constant \_NO
Open
$form .= " /> " . _NO . "";
- Exclude checks
Reference to undeclared constant \_YES
Open
$form .= "<input type='radio' name='options[3]' value='1'" . $chk . " /> " . _YES . "";
- Exclude checks
Reference to undeclared constant \_PROFILE
Open
$members .= ' <a href="' . ICMS_URL . '/userinfo.php?uid=' . $onlines[$i]['online_uid'] . '" title="' . $onlines[$i]['online_uname'] . '\'s ' . _PROFILE . '">' . $onlines[$i]['online_uname'] . '</a>, ';
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
$mytotal = $online_handler->getCount(new icms_db_criteria_Item('online_module', icms::$module->getVar('mid')));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));
- Exclude checks
Invalid offset "usercookie"
of array type array{template_set:mixed}
Open
if (isset($_COOKIE[$icmsConfig['usercookie']])) {
- Exclude checks
Reference to undeclared constant \_CLOSE
Open
$block['lang_close'] = _CLOSE;
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
if ((count($sublinks) > 0) && (!empty(icms::$module)) && ($i == icms::$module->getVar('mid'))) {
- Exclude checks
Reference to undeclared constant \_ONLINEPHRASE
Open
$block['online_total'] = sprintf(_ONLINEPHRASE, $total);
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$block['uid'] = icms::$user->getVar('uid');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$block['inactive'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0)));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$moduleperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Call to method setSort
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setSort('user_regdate');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$notification_handler = icms::handler('icms_data_notification');
- Exclude checks
Call to method setOrder
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setOrder('DESC');
- Exclude checks
Variable $section
was undeclared, but array fields are being added to it. Open
$section['name'] = $category['name'];
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));
- Exclude checks
Reference to undeclared constant \_NOT_UPDATENOW
Open
$block['submit_button'] = _NOT_UPDATENOW;
- Exclude checks
Reference to undeclared constant \_YES
Open
$form .= " /> " . _YES . "<input type='radio' id='options[2]' name='options[2]' value='0'";
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (empty(icms::$user)) {
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$notifications = &$notification_handler->getByUser(icms::$user->getVar('uid'));
- Exclude checks
When appending to a value of type array{},
found an array access index of type null,
but expected the index to be of type int|string
Open
$block[$module_name][] = array('name' => $item_info['name'], 'url' => $item_info['url']);
- Exclude checks
Invalid offset "usercookie"
of array type array{template_set:mixed}
Open
$block['unamevalue'] = $_COOKIE[$icmsConfig['usercookie']];
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$groups = is_object(icms::$user) ? icms::$user->getGroups() : XOOPS_GROUP_ANONYMOUS;
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (is_object(icms::$user)) {
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$pm_handler = icms::handler('icms_data_privmessage');
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$criteria->add(new icms_db_criteria_Item('to_userid', icms::$user->getVar('uid')));
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
if (icms::$xoopsDB->getRowsNum($result) > 0) {
- Exclude checks
Call to method setSort
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setSort('posts');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$comment_handler = icms::handler('icms_data_comment');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));
- Exclude checks
Reference to undeclared constant \_NOT_NAMENOTAVAILABLE
Open
$item_info = array('name' => '[' . _NOT_NAMENOTAVAILABLE . ']', 'url' => '');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$member_handler = icms::handler('icms_member');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$member_handler = icms::handler('icms_member');
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (!empty($event['admin_only']) && !icms::$user->isAdmin(icms::$module->getVar('mid'))) {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));
- Exclude checks
Invalid offset "language"
of array type array{template_set:mixed}
Open
$block['current_language'] = $icmsConfig['language'];
- Exclude checks
Reference to undeclared constant \_YES
Open
$form .= " /> " . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('weight', 0, '>'));
- Exclude checks
null
passed to foreach instead of array Open
foreach ($icmsConfig['theme_set_allowed'] as $theme) {
- Exclude checks
Invalid offset "theme_set"
of array type array{template_set:mixed}
Open
$block['theme_select'][$theme]['current'] = $theme == $icmsConfig['theme_set'];
- Exclude checks
Call to method __construct
from undeclared class \icms_form_elements_Radioyn
Open
$yesno = new icms_form_elements_Radioyn('', 'options[' . $i . ']', $option);
- Exclude checks
Invalid offset "use_ssl"
of array type array{template_set:mixed}
Open
if ($icmsConfig['use_ssl'] == 1 && $icmsConfig['sslloginlink'] != '') {
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Exclude checks
Invalid offset "sslloginlink"
of array type array{template_set:mixed}
Open
$block['sslloginlink'] = "<a href=\"javascript:openWithSelfMain('" . $icmsConfig['sslloginlink'] . "', 'ssllogin', 300, 200);\">" . _MB_SYSTEM_SECURE . "</a>";
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('weight', 0, '>'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$block['registered'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level')));
- Exclude checks
Returning type false
but b_system_notification_show()
is declared to return array
Open
return false;
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
$subscribed_events = $notification_handler->getSubscribedEvents($category['name'], $category['item_id'], icms::$module->getVar('mid'), icms::$user->getVar('uid'));
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$moduleperm_handler = icms::handler('icms_member_groupperm');
- Exclude checks
Invalid offset "theme_set_allowed"
of array type array{template_set:mixed}
Open
foreach ($icmsConfig['theme_set_allowed'] as $theme) {
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
$result = icms::$xoopsDB->query("SELECT u.uid, u.uname, u.email, u.user_viewemail, u.user_avatar, g.name AS groupname FROM " . icms::$xoopsDB->prefix("groups_users_link") . " l LEFT JOIN " . icms::$xoopsDB->prefix("users") . " u ON l.uid=u.uid LEFT JOIN " . icms::$xoopsDB->prefix("groups") . " g ON l.groupid=g.groupid WHERE g.group_type='Admin' ORDER BY l.groupid, u.uid");
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria1 = new icms_db_criteria_Compo(new icms_db_criteria_Item('gperm_name', 'module_read', '='));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$block['active'] = icms_conv_nr2local($member_handler->getUserCount(new icms_db_criteria_Item('level', 0, '>')));
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
- Exclude checks
Call to method setLimit
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setLimit($limit);
- Exclude checks
Reference to static property module
from undeclared class \icms
Open
if (!empty($event['admin_only']) && !icms::$user->isAdmin(icms::$module->getVar('mid'))) {
- Exclude checks
Returning type false
but b_system_notification_show()
is declared to return array
Open
return false; // do not display block
- Exclude checks
Returning type false
but b_system_bookmarks_show()
is declared to return array
Open
return FALSE; // do not display block
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$notification_handler = icms::handler('icms_data_notification');
- Exclude checks
Call to method setOrder
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setOrder('DESC');
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method setLimit
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setLimit($limit);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('com_modid', '(' . implode(',', $modIds) . ')', 'IN'));
- Exclude checks
Variable $com
was undeclared, but array fields are being added to it. Open
$com['module'] = '<a href="' . ICMS_MODULES_URL . '/' . $modules[$mid]->getVar('dirname') . '/">' . $modules[$mid]->getVar('name') . '</a>';
- Exclude checks
Call to method handler
from undeclared class \icms
Open
$module_handler = icms::handler('icms_module');
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('read_msg', 0));
- Exclude checks
Reference to static property xoopsDB
from undeclared class \icms
Open
while ($userinfo = icms::$xoopsDB->fetchArray($result)) {
- Exclude checks
Call to method htmlSpecialChars
from undeclared class \icms_core_DataFilter
Open
'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$gperm_groupid = is_object(icms::$user) ? icms::$user->getGroups() : array(XOOPS_GROUP_ANONYMOUS);
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria1->add(new icms_db_criteria_Item('gperm_groupid', '(' . implode(',', $gperm_groupid) . ')', 'IN'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);
- Exclude checks
Reference to undeclared constant \_NO
Open
$form .= " /> " . _NO . "";
- Exclude checks
Reference to undeclared constant \_NO
Open
$form .= " /> " . _NO . "";
- Exclude checks
Invalid offset "sslloginlink"
of array type array{template_set:mixed}
Open
if ($icmsConfig['use_ssl'] == 1 && $icmsConfig['sslloginlink'] != '') {
- Exclude checks
Call to method htmlSpecialChars
from undeclared class \icms_core_DataFilter
Open
$block['groups'][$i]['users'][] = array('id' => $userinfo['uid'], 'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']), 'msglink' => ' ', 'avatar' => ICMS_UPLOAD_URL . '/' . $userinfo['user_avatar']);
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Compo
Open
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Exclude checks
Call to method __construct
from undeclared class \icms_db_criteria_Item
Open
$criteria->add(new icms_db_criteria_Item('rank', $options[$i], '<>'));
- Exclude checks
Reference to static property security
from undeclared class \icms
Open
$block['notification_token'] = icms::$security->createToken();
- Exclude checks
Reference to undeclared constant \_NO
Open
$form .= " <input type='radio' name='options[3]' value='0'" . $chk . " />" . _NO . "";
- Exclude checks
Call to method add
from undeclared class \icms_db_criteria_Compo
Open
$criteria->add(new icms_db_criteria_Item('isactive', 1));
- Exclude checks
Call to method htmlSpecialChars
from undeclared class \icms_core_DataFilter
Open
'name' => icms_core_DataFilter::htmlSpecialChars($userinfo['uname']),
- Exclude checks
Call to method setOrder
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setOrder('DESC');
- Exclude checks
Call to method setSort
from undeclared class \icms_db_criteria_Compo
Open
$criteria->setSort('com_created');
- Exclude checks
Call to method isEnabled
from undeclared class \icms_data_notification_Handler
Open
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
- Exclude checks
Reference to static property user
from undeclared class \icms
Open
$subscribed_events = $notification_handler->getSubscribedEvents($category['name'], $category['item_id'], icms::$module->getVar('mid'), icms::$user->getVar('uid'));
- Exclude checks
Invalid offset "theme_set"
of array type array{template_set:mixed}
Open
$block['current_theme'] = $icmsConfig['theme_set'];
- Exclude checks
Reference to undeclared constant \_YES
Open
$form .= "<input type='radio' name='options[0]' value='1'" . $chk . " /> " . _YES;
- Exclude checks
Call to method render
from undeclared class \icms_form_elements_Radioyn
Open
$form .= '<tr><td width="25%">' . constant('_MB_SYSTEM_SOCIAL_PROVIDER_' . $i) . '</td><td>' . $yesno->render() . '</td></tr>';
- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ($options[1] == 1) {
if ($topposters[$i]->getVar('user_avatar') && $topposters[$i]->getVar('user_avatar') != 'blank.gif' && $topposters[$i]->getVar('user_avatar') != '') {
$block['users'][$i]['avatar'] = ICMS_UPLOAD_URL . '/' . $topposters[$i]->getVar('user_avatar');
} elseif ($icmsConfigUser['avatar_allow_gravatar'] == 1) {
$block['users'][$i]['avatar'] = $topposters[$i]->gravatar('G', $icmsConfigUser['avatar_width']);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ($options[1] == 1) {
if ($newmembers[$i]->getVar('user_avatar') && $newmembers[$i]->getVar('user_avatar') != 'blank.gif' && $newmembers[$i]->getVar('user_avatar') != '') {
$block['users'][$i]['avatar'] = ICMS_UPLOAD_URL . '/' . $newmembers[$i]->getVar('user_avatar');
} elseif ($icmsConfigUser['avatar_allow_gravatar'] == 1) {
$block['users'][$i]['avatar'] = $newmembers[$i]->gravatar('G', $icmsConfigUser['avatar_width']);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!empty($not_config['lookup_file'])) {
$lookup_file = ICMS_MODULES_PATH . '/' . $module->getVar('dirname') . '/' . $not_config['lookup_file'];
if (file_exists($lookup_file)) {
include_once $lookup_file;
if (!empty($not_config['lookup_func']) && function_exists($not_config['lookup_func'])) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 0;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE !== $onlines) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$perms = $moduleperm_handler->getObjects($criteria1, TRUE);
- Exclude checks
Opening brace should be on the same line as the declaration Open
{
- Exclude checks
Expected 1 space after "=>"; 0 found Open
foreach ($language_names as $namekey=>$language_name){
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $total; $i++ ) {
- Exclude checks
Expected 1 space before "=>"; 0 found Open
foreach ($language_tags as $tagkey=>$language_tag) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$modules = $module_handler->getObjects(new icms_db_criteria_Item('hascomments', 1), TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$modules = $module_handler->getObjects($criteria, TRUE);
- Exclude checks
Blank line found at end of control structure Open
- Exclude checks
Expected 1 space before "=>"; 0 found Open
foreach ($language_names as $namekey=>$language_name){
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 2; $i < $size; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$comments = $comment_handler->getObjects($criteria, TRUE);
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE; // do not display block
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $count; $i++ ) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$block['showgroups'] = TRUE;
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 2; $i < $size; $i++ ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
for ($i = 0; $i < $total; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 2; $i < $size; $i++ ) {
- Exclude checks
Space found before closing bracket of FOR loop Open
for ($i = 2; $i < $size; $i++ ) {
- Exclude checks
Expected 1 space before opening brace; found 0 Open
function b_system_themes_show($options){
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$block['showgroups'] = FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$block['index_enabled'] = TRUE;
- Exclude checks
Expected 1 space after "=>"; 0 found Open
foreach ($language_tags as $tagkey=>$language_tag) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
return FALSE;
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE" Open
$block['priv_enabled'] = TRUE;
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Inline control structures are not allowed Open
if($options[0]==1)
- Exclude checks
Inline control structures are not allowed Open
if ($options[$i]) $block['provider'][$i] = array(
- Exclude checks
Expected 1 space after closing parenthesis; found 0 Open
foreach ($language_names as $namekey=>$language_name){
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if($options[0]==1)
- Exclude checks
The variable $module_handler is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $read_allowed is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_caption is not named in camelCase. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $pm_handler is not named in camelCase. Open
function b_system_user_show() {
if (is_object(icms::$user)) {
$pm_handler = icms::handler('icms_data_privmessage');
$block = array();
$block['lang_youraccount'] = _MB_SYSTEM_VACNT;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_tags is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_item is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $moduleperm_handler is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $moduleperm_handler is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $script_name is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_modid is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_config is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_config is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_modid is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $item_info is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_func is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $script_name is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_tags is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_tag is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_name is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_topposters_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $subscribed_events is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $script_url is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_tag is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_names is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_name is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_func is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $item_info is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_config is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_name is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_caption is not named in camelCase. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_caption is not named in camelCase. Open
function b_system_info_show($options) {
global $icmsConfig;
$block = array();
if (!empty($options[3])) {
$block['showgroups'] = TRUE;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $subscribed_events is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_config is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $moduleperm_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_config is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $language_names is not named in camelCase. Open
function b_system_multilanguage_show()
{
global $icmsConfigMultilang, $icmsConfig;
$block = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_name is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_file is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_file is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_func is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_groupid is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $gperm_groupid is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $comment_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_item is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_func is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $item_info is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_modid is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $lookup_file is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_item is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $item_info is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $read_allowed is not named in camelCase. Open
function b_system_main_show() {
global $icmsConfigUser;
$block = array();
$block['lang_home'] = _MB_SYSTEM_HOME;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_newmembers_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_topposters_show($options) {
global $icmsConfigUser;
$block = array();
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('level', 0, '>'));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $member_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $script_url is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $notification_handler is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $prev_item is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $online_handler is not named in camelCase. Open
function b_system_online_show() {
$online_handler = icms::handler('icms_core_Online');
mt_srand((double) microtime() * 1000000);
// set gc probabillity to 10% for now..
if (mt_rand(1, 100) < 11) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $moduleperm_handler is not named in camelCase. Open
function b_system_comments_show($options) {
$block = array();
include_once ICMS_ROOT_PATH . '/include/comment_constants.php';
$comment_handler = icms::handler('icms_data_comment');
$criteria = new icms_db_criteria_Compo(new icms_db_criteria_Item('com_status', XOOPS_COMMENT_ACTIVE));
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $script_url is not named in camelCase. Open
function b_system_notification_show() {
icms_loadLanguageFile('core', 'notification');
// Notification must be enabled, and user must be logged in
if (empty(icms::$user) || !icms_data_notification_Handler::isEnabled('block')) {
return false; // do not display block
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_name is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $pm_handler is not named in camelCase. Open
function b_system_user_show() {
if (is_object(icms::$user)) {
$pm_handler = icms::handler('icms_data_privmessage');
$block = array();
$block['lang_youraccount'] = _MB_SYSTEM_VACNT;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $module_handler is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $not_config is not named in camelCase. Open
function b_system_bookmarks_show() {
global $icmsConfig;
$block = array();
icms_loadLanguageFile('core', 'notification');
// User must be logged in
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}