Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
// $Id: admin.php 11023 2011-02-15 01:30:36Z skenow $
//%%%%%% File Name admin.php %%%%%
//define('_MD_AM_CONFIG','System Configuration');
define('_INVALID_ADMIN_FUNCTION', 'Invalid Admin Function');- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 717.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
No space found after comma in function call Open
define('_MD_AM_PREF_DSC',"ImpressCMS Site Preferences");- Exclude checks
No space found after comma in function call Open
define('_MD_AM_BKAD','Blocks');- Exclude checks
Newline required after opening brace Open
if (!defined('_MD_AM_AUTOTASKS')) {define('_MD_AM_AUTOTASKS', 'Auto Tasks');}- Exclude checks
No space found after comma in function call Open
define('_MD_AM_SMLS','Smilies');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_PREF','Preferences');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_VRSN','Version Checker');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_ADGS','Groups');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_MDAD','Modules Admin');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_PAGES','Symlink Manager');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_RANK','User Ranks');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_USER','Edit Users');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_BKPOSAD','Block Positions');- Exclude checks
No space found after comma in function call Open
define('_MD_AM_PERMRESETNG','Could not reset group permission for module %s');- Exclude checks
Closing brace must be on a line by itself Open
if (!defined('_MD_AM_AUTOTASKS')) {define('_MD_AM_AUTOTASKS', 'Auto Tasks');}- Exclude checks
No space found after comma in function call Open
define('_MD_AM_PERMADDOK','Added %s permission to %s for group %s');- Exclude checks