htdocs/modules/system/language/english/admin/blocksadmin.php
TODO found Open
Open
* TODO: Add the rest of the fields, are added only the ones which are shown.- Exclude checks
Similar blocks of code found in 3 locations. Consider refactoring. Open
Open
<?php
// $Id: blocksadmin.php 11329 2011-08-28 11:04:24Z phoenyx $
//%%%%%% Admin Module Name Blocks %%%%%
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}
- Read upRead up
htdocs/modules/system/language/francais/admin/blocksadmin.php on lines 1..123
htdocs/modules/system/language/nederlands/admin/blocksadmin.php on lines 1..128
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1368.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Closing brace must be on a line by itself Open
Open
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}- Exclude checks
No space found after comma in function call Open
Open
define("_AM_LISTBLOCK","List all blocks");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_BLKDESC","Block Description");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_RIGHT","Right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBLEFT","Center Block - Left");- Exclude checks
No space found after comma in function call Open
Open
define('_AM_BLOCKS_PERMGROUPS','Groups allowed to view this block');- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SBRIGHT_ADMIN","Admin Side Block - Right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOMRIGHT_ADMIN","Admin Center Block - Bottom right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_POSCONTT","Position of the additional content");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_BLOCKTAG1","%s will print %s");- Exclude checks
Newline required after opening brace Open
Open
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}- Exclude checks
No space found after comma in function call Open
Open
define('_AM_BPADMIN',"Block Positions Administration");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_DELETE","Delete");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CTYPE","Content Type");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SBLEFT_ADMIN","Admin Side Block - Left");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBCENTER_ADMIN","Admin Center Block - Center");- Exclude checks
A closing tag is not permitted at the end of a PHP file Open
Open
?>- Exclude checks
No space found after comma in function call Open
Open
define("_AM_PHP","PHP Script");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_RUSUREDEL","Are you sure you want to delete block '%s'?");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBRIGHT","Center Block - Right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SUBMIT","Submit");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CENTER","Center");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOMLEFT","Center Block - Bottom left");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_AFNOSMILE","Auto Format (smilies disabled)");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CUSTOMPHP","Custom Block (PHP)");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_MODULECANT","This block cannot be deleted directly! If you wish to disable this block, deactivate the module.");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_BLKTYPE","Block Type");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_LEFT","Left");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_VISIBLE","Visible");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SAVECHANGES","Save Changes");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBLEFT_ADMIN","Admin Center Block - Left");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOM_ADMIN","Admin Center Block - Bottom");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SIDE","Side");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_ADDBLOCK","Add a new block");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOM","Center Block - Bottom");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_AFTERORG","After the original content");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_HTML","HTML");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_BADMIN","Blocks Administration");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_AFWSMILE","Auto Format (smilies enabled)");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_TITLE","Title");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CUSTOMSMILE","Custom Block (Auto Format + smilies)");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_ABOVEORG","Above the original content");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SYSTEMCANT","System blocks cannot be deleted!");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_EDITBLOCK","Edit a block");- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
?>- Exclude checks
No space found after comma in function call Open
Open
define("_AM_WEIGHT","Weight");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SBLEFT","Side Block - Left");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_SBRIGHT","Side Block - Right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CUSTOMNOSMILE","Custom Block (Auto Format)");- Exclude checks
Newline required after opening brace Open
Open
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}- Exclude checks
Closing brace must be on a line by itself Open
Open
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}- Exclude checks
No space found after comma in function call Open
Open
define("_AM_EDIT","Edit");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOMRIGHT","Center Block - Bottom right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_OPTIONS","Options");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_DISPRIGHT","Display only rightblocks");- Exclude checks
No space found after comma in function call Open
Open
if (!defined('_AM_DBUPDATED')) {if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}}- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBCENTER","Center Block - Center");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_ACTION","Action");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CONTENT","Content");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_NAME","Name");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CUSTOMHTML","Custom Block (HTML)");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_USEFULTAGS","Useful Tags:");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBRIGHT_ADMIN","Admin Center Block - Right");- Exclude checks
No space found after comma in function call Open
Open
define("_AM_CBBOTTOMLEFT_ADMIN","Admin Center Block - Bottom left");- Exclude checks