ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/language/english/admin/findusers.php

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php
// $Id: findusers.php 11344 2011-08-30 16:33:29Z phoenyx $
//%%%%%%    File Name findusers.php     %%%%%

define("_AM_FINDUS","Find Users");
Severity: Major
Found in htdocs/modules/system/language/english/admin/findusers.php and 5 other locations - About 3 days to fix
htdocs/modules/system/language/francais/admin/findusers.php on lines 1..54
htdocs/modules/system/language/italiano/admin/findusers.php on lines 1..63
htdocs/modules/system/language/italiano/admin/groups.php on lines 1..70
htdocs/modules/system/language/italiano/modinfo.php on lines 1..75
htdocs/modules/system/language/nederlands/admin/findusers.php on lines 1..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 625.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

No space found after comma in function call
Open

define("_AM_REGDATE","Joined Date");

No space found after comma in function call
Open

define("_AM_FINDUS","Find Users");

No space found after comma in function call
Open

define("_AM_REALNAME","Real Name");

No space found after comma in function call
Open

define("_AM_URLC","URL contains");

No space found after comma in function call
Open

define("_AM_SORT","Sort by");

No space found after comma in function call
Open

define("_AM_AIM","AIM Handle");

No space found after comma in function call
Open

define("_AM_NEXT","Next");

No space found after comma in function call
Open

define("_AM_UNAME","User Name");

No space found after comma in function call
Open

define("_AM_ICQ","ICQ Number");

No space found after comma in function call
Open

define("_AM_YIM","YIM Handle");

No space found after comma in function call
Open

define("_AM_INTEREST","Interest contains");

No space found after comma in function call
Open

define("_AM_ASC","Ascending order");

No space found after comma in function call
Open

define("_AM_MSNM","MSNM Handle");

No space found after comma in function call
Open

define("_AM_LOCATION","Location contains");

No space found after comma in function call
Open

define("_AM_POSTS","Number of posts");

No space found after comma in function call
Open

define("_AM_LIMIT","Number of users per page");

No space found after comma in function call
Open

define("_AM_LOGINNAME","Login Name");

No space found after comma in function call
Open

define("_AM_ACTIONS","Actions");

No space found after comma in function call
Open

define("_AM_LASTLOGMORE","Last login is more than <span style='color:#ff0000;'>X</span> days ago");

No space found after comma in function call
Open

define("_AM_DESC","Descending order");

No space found after comma in function call
Open

define("_AM_USERSFOUND","%s user(s) found");

No space found after comma in function call
Open

define("_AM_REGMORE","Joined date is more than <span style='color:#ff0000;'>X</span> days ago");

No space found after comma in function call
Open

define("_AM_PREVIOUS","Previous");

No space found after comma in function call
Open

define("_AM_REGLESS","Joined date is less than <span style='color:#ff0000;'>X</span> days ago");

No space found after comma in function call
Open

define("_AM_ORDER","Order");

No space found after comma in function call
Open

define("_AM_LASTLOGIN","Last login");

No space found after comma in function call
Open

define("_AM_ACTIVE","Only active users");

No space found after comma in function call
Open

define("_AM_LASTLOGLESS","Last login is less than <span style='color:#ff0000;'>X</span> days ago");

No space found after comma in function call
Open

define("_AM_MAILNG","Only users that don't accept mail");

No space found after comma in function call
Open

define("_AM_EMAIL","Email");

No space found after comma in function call
Open

define("_AM_OCCUPATION","Occupation contains");

No space found after comma in function call
Open

define("_AM_POSTSLESS","Number of Posts is less than <span style='color:#ff0000;'>X</span>");

No space found after comma in function call
Open

define("_AM_PM","PM");

No space found after comma in function call
Open

define("_AM_URL","URL");

No space found after comma in function call
Open

define("_AM_INACTIVE","Only inactive users");

No space found after comma in function call
Open

define("_AM_AVATAR","Avatar");

No space found after comma in function call
Open

define("_AM_POSTSMORE","Number of Posts is greater than <span style='color:#ff0000;'>X</span>");

No space found after comma in function call
Open

define("_AM_NOFOUND","No Users Found");

No space found after comma in function call
Open

define("_AM_MAILOK","Only users that accept mail");

Expected 1 newline at end of file; 0 found
Open

define("_AM_ACTIONS","Actions");

There are no issues that match your filters.

Category
Status