Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
// $Id: groups.php 10326 2010-07-11 18:54:25Z malanciault $
//%%%%%% Admin Module Name AdminGroup %%%%%
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 639.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
No space found after comma in function call Open
define("_AM_NONMEMBERS","Non-members");
- Exclude checks
No space found after comma in function call Open
define("_AM_SBRIGHT","Side Block - Right");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBCENTER","Center Block - Center");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOMLEFT_ADMIN","Admin Center Block - Bottom left");
- Exclude checks
A closing tag is not permitted at the end of a PHP file Open
?>
- Exclude checks
No space found after comma in function call Open
define("_AM_EDITADG","Edit Groups");
- Exclude checks
No space found after comma in function call Open
define("_AM_MODIFY","Modify");
- Exclude checks
No space found after comma in function call Open
define("_AM_UPDATEADG","Update Group");
- Exclude checks
No space found after comma in function call Open
define("_AM_MODIFYADG","Modify Group");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBLEFT","Center Block - Left");
- Exclude checks
No space found after comma in function call Open
define("_AM_ACCESSRIGHTS","Can access the following modules");
- Exclude checks
No space found after comma in function call Open
define("_AM_SBLEFT","Side Block - Left");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOMLEFT","Center Block - Bottom left");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOM","Center Block - Bottom");
- Exclude checks
No space found after comma in function call Open
define("_AM_DEBUG_PERM","Can see the Debug Mode in the following modules");
- Exclude checks
No space found after comma in function call Open
define("_AM_IFADMIN","If admin right for a module is checked, access right for the module will always be enabled.");
- Exclude checks
No space found after comma in function call Open
define("_AM_SBLEFT_ADMIN","Admin Side Block - Left");
- Exclude checks
No space found after comma in function call Open
define("_AM_EDPERM","Can use the WYSIWYG editor in the following modules");
- Exclude checks
No space found after comma in function call Open
define("_AM_YES","Yes");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBLEFT_ADMIN","Admin Center Block - Left");
- Exclude checks
Closing brace must be on a line by itself Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOMRIGHT_ADMIN","Admin Center Block - Bottom right");
- Exclude checks
No space found after comma in function call Open
define("_AM_ACTIVERIGHTS","Can administrate the following modules");
- Exclude checks
No space found after comma in function call Open
define("_AM_DELETEADG","Delete Group");
- Exclude checks
No space found after comma in function call Open
define("_AM_BLOCKRIGHTS","Can see the following blocks");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBRIGHT","Center Block - Right");
- Exclude checks
Expected 1 newline at end of file; 0 found Open
?>
- Exclude checks
No space found after comma in function call Open
define("_AM_DELETE","Delete");
- Exclude checks
No space found after comma in function call Open
define("_AM_NAME","Name");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOMRIGHT","Center Block - Bottom right");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBCENTER_ADMIN","Admin Center Block - Center");
- Exclude checks
No space found after comma in function call Open
define("_AM_SYSTEMRIGHTS","Can administrate the following System features");
- Exclude checks
No space found after comma in function call Open
define("_AM_UNEED2ENTER","You need to enter required info!");
- Exclude checks
No space found after comma in function call Open
define("_AM_GROUPMANAGER_PERM","Can change permissions on these groups");
- Exclude checks
No space found after comma in function call Open
define("_AM_CREATENEWADG","Create New Group");
- Exclude checks
No space found after comma in function call Open
define("_AM_DELBUTTON","<--delete");
- Exclude checks
No space found after comma in function call Open
define("_AM_SBRIGHT_ADMIN","Admin Side Block - Right");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBBOTTOM_ADMIN","Admin Center Block - Bottom");
- Exclude checks
No space found after comma in function call Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}
- Exclude checks
No space found after comma in function call Open
define("_AM_MEMBERS","Members");
- Exclude checks
Newline required after opening brace Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}
- Exclude checks
No space found after comma in function call Open
define("_AM_DESCRIPTION","Description");
- Exclude checks
No space found after comma in function call Open
define("_AM_INDICATES","* indicates required fields");
- Exclude checks
No space found after comma in function call Open
define("_AM_AREUSUREDEL","Are you sure you want to delete this group?");
- Exclude checks
No space found after comma in function call Open
define("_AM_NO","No");
- Exclude checks
No space found after comma in function call Open
define("_AM_ADDBUTTON"," add --> ");
- Exclude checks
No space found after comma in function call Open
define("_AM_CBRIGHT_ADMIN","Admin Center Block - Right");
- Exclude checks
No space found after comma in function call Open
define("_AM_EDITMEMBER","Edit Members of this Group");
- Exclude checks