ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/language/english/admin/groups.php

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
// $Id: groups.php 10326 2010-07-11 18:54:25Z malanciault $
//%%%%%%    Admin Module Name  AdminGroup     %%%%%
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

Severity: Major
Found in htdocs/modules/system/language/english/admin/groups.php and 1 other location - About 3 days to fix
htdocs/modules/system/language/nederlands/admin/groups.php on lines 1..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 639.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

No space found after comma in function call
Open

define("_AM_NONMEMBERS","Non-members");

No space found after comma in function call
Open

define("_AM_SBRIGHT","Side Block - Right");

No space found after comma in function call
Open

define("_AM_CBCENTER","Center Block - Center");

No space found after comma in function call
Open

define("_AM_CBBOTTOMLEFT_ADMIN","Admin Center Block - Bottom left");

A closing tag is not permitted at the end of a PHP file
Open

?>

No space found after comma in function call
Open

define("_AM_EDITADG","Edit Groups");

No space found after comma in function call
Open

define("_AM_MODIFY","Modify");

No space found after comma in function call
Open

define("_AM_UPDATEADG","Update Group");

No space found after comma in function call
Open

define("_AM_MODIFYADG","Modify Group");

No space found after comma in function call
Open

define("_AM_CBLEFT","Center Block - Left");

No space found after comma in function call
Open

define("_AM_ACCESSRIGHTS","Can access the following modules");

No space found after comma in function call
Open

define("_AM_SBLEFT","Side Block - Left");

No space found after comma in function call
Open

define("_AM_CBBOTTOMLEFT","Center Block - Bottom left");

No space found after comma in function call
Open

define("_AM_CBBOTTOM","Center Block - Bottom");

No space found after comma in function call
Open

define("_AM_DEBUG_PERM","Can see the Debug Mode in the following modules");

No space found after comma in function call
Open

define("_AM_IFADMIN","If admin right for a module is checked, access right for the module will always be enabled.");

No space found after comma in function call
Open

define("_AM_SBLEFT_ADMIN","Admin Side Block - Left");

No space found after comma in function call
Open

define("_AM_EDPERM","Can use the WYSIWYG editor in the following modules");

No space found after comma in function call
Open

define("_AM_YES","Yes");

No space found after comma in function call
Open

define("_AM_CBLEFT_ADMIN","Admin Center Block - Left");

Closing brace must be on a line by itself
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_CBBOTTOMRIGHT_ADMIN","Admin Center Block - Bottom right");

No space found after comma in function call
Open

define("_AM_ACTIVERIGHTS","Can administrate the following modules");

No space found after comma in function call
Open

define("_AM_DELETEADG","Delete Group");

No space found after comma in function call
Open

define("_AM_BLOCKRIGHTS","Can see the following blocks");

No space found after comma in function call
Open

define("_AM_CBRIGHT","Center Block - Right");

Expected 1 newline at end of file; 0 found
Open

?>

No space found after comma in function call
Open

define("_AM_DELETE","Delete");

No space found after comma in function call
Open

define("_AM_NAME","Name");

No space found after comma in function call
Open

define("_AM_CBBOTTOMRIGHT","Center Block - Bottom right");

No space found after comma in function call
Open

define("_AM_CBCENTER_ADMIN","Admin Center Block - Center");

No space found after comma in function call
Open

define("_AM_SYSTEMRIGHTS","Can administrate the following System features");

No space found after comma in function call
Open

define("_AM_UNEED2ENTER","You need to enter required info!");

No space found after comma in function call
Open

define("_AM_GROUPMANAGER_PERM","Can change permissions on these groups");

No space found after comma in function call
Open

define("_AM_CREATENEWADG","Create New Group");

No space found after comma in function call
Open

define("_AM_DELBUTTON","<--delete");

No space found after comma in function call
Open

define("_AM_SBRIGHT_ADMIN","Admin Side Block - Right");

No space found after comma in function call
Open

define("_AM_CBBOTTOM_ADMIN","Admin Center Block - Bottom");

No space found after comma in function call
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_MEMBERS","Members");

Newline required after opening brace
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_DESCRIPTION","Description");

No space found after comma in function call
Open

define("_AM_INDICATES","* indicates required fields");

No space found after comma in function call
Open

define("_AM_AREUSUREDEL","Are you sure you want to delete this group?");

No space found after comma in function call
Open

define("_AM_NO","No");

No space found after comma in function call
Open

define("_AM_ADDBUTTON"," add --> ");

No space found after comma in function call
Open

define("_AM_CBRIGHT_ADMIN","Admin Center Block - Right");

No space found after comma in function call
Open

define("_AM_EDITMEMBER","Edit Members of this Group");

There are no issues that match your filters.

Category
Status