Similar blocks of code found in 3 locations. Consider refactoring. Open
<?php
// $Id: images.php 11445 2011-11-18 08:17:59Z sato-san $
//%%%%%% Image Manager %%%%%
define('_MD_IMGMAIN','Image Manager Main');- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 820.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
No space found after comma in function call Open
define('_MD_ASFILE',' Store as files (in the directory %s)<br />');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATWGRP','Select groups allowed to upload images:<br /><br /><span style="font-weight: normal;">Typical usage is for moderator and admin groups.</span>');- Exclude checks
No space found after comma in function call Open
define('_MD_STRTYOPENG','This can not be changed afterwards!');- Exclude checks
No space found after comma in function call Open
define('_MD_ADDIMGCAT','Add Image Category:');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATNAME','Category Name:');- Exclude checks
No space found after comma in function call Open
define('_MD_ADDIMGBTN','Add new image');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATPARENT','Parent Category:');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATDISPLAY','Display this category?');- Exclude checks
No space found after comma in function call Open
define('_MD_RUDELIMG','Are you sure that you want to delete this images file?');- Exclude checks
No space found after comma in function call Open
define('_MD_DELETEIMGCAT','Delete Image Category');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATWEIGHT','Display order in image manager:');- Exclude checks
No space found after comma in function call Open
define('_MD_RUDELIMGCAT','Are you sure that you want to delete this category and all of its images files?');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGMAIN','Image Manager Main');- Exclude checks
No space found after comma in function call Open
define('_MD_EDITIMGCAT','Edit Image Category:');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATSTRTYPE','Images are uploaded to:');- Exclude checks
No space found after comma in function call Open
define('_MD_INDB',' Store in the database (as binary "blob" data)');- Exclude checks
Expected 1 newline at end of file; 0 found Open
define('IMANAGER_NOPERM', 'You are not authorised to access this area!');- Exclude checks
No space found after comma in function call Open
define('_MD_IMGCATRGRP','Select groups for image manager use:<br /><br /><span style="font-weight: normal;">These are groups allowed to use the image manager for selecting images but not uploading. Webmaster has automatic access.</span>');- Exclude checks
No space found after comma in function call Open
define('_MD_ADDIMGCATBTN','Add new category');- Exclude checks