Similar blocks of code found in 3 locations. Consider refactoring. Open
<?php
// $Id: mailusers.php 10326 2010-07-11 18:54:25Z malanciault $
//%%%%%% Admin Module Name MailUsers %%%%%
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 431.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Closing brace must be on a line by itself Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}- Exclude checks
No space found after comma in function call Open
define("_AM_MAILFMAIL","From Email (email only)");- Exclude checks
No space found after comma in function call Open
define("_AM_REGDMAX","Registered date is before");- Exclude checks
No space found after comma in function call Open
define("_AM_IDLEMORE","Last Login was more than X days ago (optional)");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILSUBJECT","Subject");- Exclude checks
No space found after comma in function call Open
define("_AM_LASTLOGMAX","Last Login is before");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILTAGS","Useful Tags:");- Exclude checks
No space found after comma in function call Open
define("_AM_SENDTOUSERS2","Send to:");- Exclude checks
No space found after comma in function call Open
define("_AM_LASTLOGMIN","Last Login is after");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILFNAME","From Name (email only)");- Exclude checks
No space found after comma in function call Open
define("_AM_EMAIL","Email");- Exclude checks
No space found after comma in function call Open
define("_AM_SENDTO","Send to");- Exclude checks
Newline required after opening brace Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}- Exclude checks
No space found after comma in function call Open
define("_AM_MAILOK","Send message only to users that accept notification messages (optional)");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILTAGS4","{X_UACTLINK} will print user activation link");- Exclude checks
No space found after comma in function call Open
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}- Exclude checks
No space found after comma in function call Open
define("_AM_REGDMIN","Registered date is after");- Exclude checks
No space found after comma in function call Open
define("_AM_IDLELESS","Last Login was less than X days ago (optional)");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILTAGS1","{X_UID} will print user id");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILTAGS2","{X_UNAME} will print user name");- Exclude checks
Expected 1 newline at end of file; 0 found Open
?>- Exclude checks
A closing tag is not permitted at the end of a PHP file Open
?>- Exclude checks
No space found after comma in function call Open
define("_AM_INACTIVE","Send message to inactive users only (optional)");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILTAGS3","{X_UEMAIL} will print user email");- Exclude checks
No space found after comma in function call Open
define("_AM_PM","Private Message");- Exclude checks
No space found after comma in function call Open
define("_AM_SENDTOUSERS","Send message to users whose:");- Exclude checks
No space found after comma in function call Open
define("_AM_GROUPIS","Group is (optional)");- Exclude checks
No space found after comma in function call Open
define("_AM_MAILBODY","Body");- Exclude checks