Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
// $Id: tplsets.php 11344 2011-08-30 16:33:29Z phoenyx $
//%%%%%% Template Manager %%%%%
define('_MD_TPLMAIN','Template Set Manager');
define('_MD_INSTALL','Install');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1223.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
No space found after comma in function call Open
define('_MD_IMGDELETE','Delete');
- Exclude checks
Expected 1 newline at end of file; 0 found Open
define("_MD_TPLSET_ACTIONS", "Actions");
- Exclude checks
No space found after comma in function call Open
define('_MD_IMPORT','Import');
- Exclude checks
No space found after comma in function call Open
define('_MD_NOFILE','No File');
- Exclude checks
No space found after comma in function call Open
define('_MD_ACTION','Action');
- Exclude checks
No space found after comma in function call Open
define('_MD_EDITSKINIMG','Edit skin image files');
- Exclude checks
No space found after comma in function call Open
define('_MD_ADDSKINIMG','Add skin image file');
- Exclude checks
No space found after comma in function call Open
define('_MD_FILEMOD','Last modified (file)');
- Exclude checks
No space found after comma in function call Open
define('_MD_NEWNAME','Enter new template set name');
- Exclude checks
No space found after comma in function call Open
define('_MD_IMGFILE','File name');
- Exclude checks
No space found after comma in function call Open
define('_MD_CLONETHEME','Clone a template set');
- Exclude checks
No space found after comma in function call Open
define('_MD_TEMPLATES','Templates');
- Exclude checks
No space found after comma in function call Open
define('_MD_THEMENAME','Base template set');
- Exclude checks
No space found after comma in function call Open
define('_MD_COPYDEFAULT','Copy default file');
- Exclude checks
No space found after comma in function call Open
define('_MD_GENERATE','Generate');
- Exclude checks
No space found after comma in function call Open
define('_MD_CONTENT','Content');
- Exclude checks
No space found after comma in function call Open
define('_MD_VIEWTEMPLATE','View template file');
- Exclude checks
No space found after comma in function call Open
define('_MD_EDITSKIN','Edit skin');
- Exclude checks
No space found after comma in function call Open
define('_MD_SKINIMGS','Skin image files');
- Exclude checks
No space found after comma in function call Open
define('_MD_VIEWDEFAULT','View default template');
- Exclude checks
No space found after comma in function call Open
define('_MD_DLDEFAULT','Download default file');
- Exclude checks
No space found after comma in function call Open
define('_MD_DOWNLOAD','Download');
- Exclude checks
No space found after comma in function call Open
define('_MD_FILEDESC','Description');
- Exclude checks
No space found after comma in function call Open
define('_MD_FILECSS','CSS');
- Exclude checks
No space found after comma in function call Open
define('_MD_IMGNEWFILE','Upload new file');
- Exclude checks
No space found after comma in function call Open
define('_MD_TPLMAIN','Template Set Manager');
- Exclude checks
No space found after comma in function call Open
define('_MD_LASTMOD','Last modified');
- Exclude checks
No space found after comma in function call Open
define('_MD_TITLE','Title');
- Exclude checks
No space found after comma in function call Open
define('_MD_EDITTEMPLATE','Edit template file');
- Exclude checks
No space found after comma in function call Open
define('_MD_SKIN','Skin');
- Exclude checks
No space found after comma in function call Open
define('_MD_VIEW','View');
- Exclude checks
No space found after comma in function call Open
define('_MD_FILEHTML','HTML');
- Exclude checks
No space found after comma in function call Open
define('_MD_DEFAULTTHEME','Your site uses this template set as default');
- Exclude checks
No space found after comma in function call Open
define('_MD_INSTALL','Install');
- Exclude checks
No space found after comma in function call Open
define('_MD_FILENAME','File name');
- Exclude checks
No space found after comma in function call Open
define('_MD_THMSETNAME','Name');
- Exclude checks
No space found after comma in function call Open
define('_MD_CREATED','Created');
- Exclude checks
No space found after comma in function call Open
define('_MD_UPLOAD','Upload');
- Exclude checks